[lworld] Integrated: 8378000: [lworld] Move ArrayProperties to its own class
Joel Sikström
jsikstro at openjdk.org
Fri Feb 27 15:25:23 UTC 2026
On Mon, 16 Feb 2026 14:51:52 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:
> Hello,
>
> We should consider moving the enum ArrayProperties from ArrayKlass to its own class, ArrayProperties. In addition to making the code easier to read and understand, this allows us to have explicit setters/getters, replacing the bit-fiddling expressions that are used in many places. The ArrayProperties-specific methods in ArrayKlass have been moved to be methods in the new ArrayProperties class instead.
>
> Perhaps the most controversial change in this PR is the removal of `ArrayKlass::ArrayProperties::DEFAULT` in favor of using a default constructor for ArrayProperties. The semantics are still the same, i.e., asking `.is_null_restricted()` or `.is_non_atomic()` will be false for the default constructed property. With this I've also removed the unused fields from ArrayProperties (DUMMY and comments).
>
> I did consider using define macros to generate enum+getters+setters, but I opted for the stamped-out version instead.
>
> Testing:
> * Oracle's tier1-4
This pull request has now been integrated.
Changeset: c1bb865c
Author: Joel Sikström <jsikstro at openjdk.org>
URL: https://git.openjdk.org/valhalla/commit/c1bb865cf4e66c686fce98bb7f8dbf1b8b21ce2f
Stats: 274 lines in 25 files changed: 106 ins; 52 del; 116 mod
8378000: [lworld] Move ArrayProperties to its own class
Reviewed-by: fparain, phubner
-------------
PR: https://git.openjdk.org/valhalla/pull/2114
More information about the valhalla-dev
mailing list