Integrated: 8374633: Bang in signatures should go before the type

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Jan 6 18:30:43 UTC 2026


On Tue, 6 Jan 2026 18:12:56 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This PR tweaks signature generation so that bangs are added before the type being restricted, not after.
> 
> After fixing this I realized that no test was failing :-) so I added a separate compilation test to test `ClassReader`.
> The test revealed some gaps in parsing of generic type test patterns with null-restriction, which I have fixed.
> 
> Also, the test revealed issues with type substitution, as type substitution was not preserving the null-restrictions in the "from" types. This is also now fixed.

This pull request has now been integrated.

Changeset: 15ad4769
Author:    Maurizio Cimadamore <mcimadamore at openjdk.org>
URL:       https://git.openjdk.org/valhalla/commit/15ad476921b66b66c095036bc61a05a5c998ee65
Stats:     121 lines in 7 files changed: 100 ins; 15 del; 6 mod

8374633: Bang in signatures should go before the type

Reviewed-by: vromero

-------------

PR: https://git.openjdk.org/valhalla/pull/1860


More information about the valhalla-dev mailing list