[lworld] Integrated: 8374093: [lworld] Cleanup and polish around vgetfield/vputfield

Joel Sikström jsikstro at openjdk.org
Wed Jan 7 13:47:08 UTC 2026


On Fri, 19 Dec 2025 09:19:49 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:

> Hello,
> 
> I've been looking at the new internal bytecodes vgetfield and vputfield and their callchains from the interpreter down to InlineKlass and have some cleanups. I've not looked at templateTable_x86 so far, only templateTable_aarch64.
> 
> Some notes:
> * The `dest_is_initialized` parameter in InlineKlass::write_value_to_addr is `true` for all callers, so I've removed it and inlined `true` to the call to `copy_payload_to_addr`.
> * There seems to be an unnecessary `mark_payload_as_non_null((address)src);` in InlineKlass::copy_payload_to_addr, as the payload should already be non_null if it doesn't match `is_payload_marked_as_null` in the if-statement just above.
> 
> Testing:
> * hotspot_valhalla, jdk_valhalla and tier1

This pull request has now been integrated.

Changeset: b51d2eb2
Author:    Joel Sikström <jsikstro at openjdk.org>
Committer: Frederic Parain <fparain at openjdk.org>
URL:       https://git.openjdk.org/valhalla/commit/b51d2eb28ff8271f22e489dde556828e9ae4c844
Stats:     37 lines in 10 files changed: 0 ins; 4 del; 33 mod

8374093: [lworld] Cleanup and polish around vgetfield/vputfield

Reviewed-by: fparain

-------------

PR: https://git.openjdk.org/valhalla/pull/1840


More information about the valhalla-dev mailing list