[lworld] RFR: 8373930: [lworld] Restore Objects.equals use of identity check [v2]
Ryan Hallock
duke at openjdk.org
Fri Jan 9 21:33:28 UTC 2026
On Fri, 9 Jan 2026 21:30:08 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Revert "8366841: [lworld] Objects.equals without identity comparison". (Almost all)
>> Removing the condition on --enable-preview.
>> Correct the .equals method in test SimplValueGraphs.SimpleValue.
>
> Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Reverted to remove the no longer unnecessary @ForceInline.
> Update copyright.
> - Merge branch 'lworld' into 8373930-objects-equals-revert
> - Restore the mainline implementation of Objects.equal
> removing the condition on --enable-preview.
> Correct the .equals method of SimplValueGraphs.SimpleValue.
> Revert "8366841: [lworld] Objects.equals without identity comparison"
src/java.base/share/classes/java/util/Objects.java line 62:
> 60: * @see Object#equals(Object)
> 61: */
> 62: @ForceInline
Is this still required? I thought the reasoning behind 8368884: https://github.com/openjdk/valhalla/pull/1643 was that equals was too large.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1836#discussion_r2672926785
More information about the valhalla-dev
mailing list