RFR: fixing bugs in NullChecksWriter [v2]

[Vicente Romero]

> fixing some bugs in NullChecksWriter, reported by John Rose. In particular there was no null check being generated by javac for code like:
> 
> 
> class Test {
>     void m(String someObject) {
>         String! x = "foo";
>         x = (String)someObject;  // no null check generated here
>     }
> 
>     public static void main(String... args) {
>         new Test().m(null);
>     }
> }

Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:

  review comments

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/1883/files
  - new: https://git.openjdk.org/valhalla/pull/1883/files/9bd8f1a3..610e6376

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1883&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1883&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/valhalla/pull/1883.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1883/head:pull/1883

PR: https://git.openjdk.org/valhalla/pull/1883