[lworld] RFR: 8373202: [lworld] ObjectReference.equals should follow == semantics for value objects
Chris Plummer
cjplummer at openjdk.org
Wed Jan 14 04:47:22 UTC 2026
On Mon, 12 Jan 2026 22:25:59 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Updated implementation of ObjectReference.equals and ObjectReference.hashCode to comply the spec for value objects.
>> Added the test for value object ctor debugging, the test verifies the behaviour is expected.
>> There is an issue with instance filter, it till be fixed separately (it's not yet clear how it would be better to fix it)
>>
>> testing: tier1..4, hs-tier5-svc
>
> src/java.se/share/data/jdwp/jdwp.spec line 1830:
>
>> 1828: (Error VM_DEAD)
>> 1829: )
>> 1830: )
>
> I wonder if the `(Error NOT_IMPLEMENTED)` should also be included. Should we also consider to introduce one more field in the `CapabilitiesNew=17` command?
We didn't do similar for Loom related APIs. I looked through the current canXXX list, and they all seem related to JVMTI capabilities, which don't apply to these two APIs. I think the expectation should be that the user checks the JDWP version to determine if it is implemented.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1834#discussion_r2688886477
More information about the valhalla-dev
mailing list