RFR: add use site null checks [v7]

[Maurizio Cimadamore]

On Fri, 16 Jan 2026 01:37:05 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Adding use site null checks for method invocations. They are added by default but if option: `noUseSiteNullChecks` is passed, the compiler won't generate them
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changes to tests

Looks good

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/NullChecksWriter.java line 219:

> 217:             actualArgsTmp = actualArgsTmp.tail;
> 218:         }
> 219:         // now add the last vararg argument if applicable

Maybe add in the comment that no check is needed here, and that this is already translated by Lower into an array

test/langtools/tools/javac/nullability/RuntimeNullChecks.java line 507:

> 505: 
> 506:     @Test
> 507:     public void testClientSideChecksSepCompilation(Path base) throws Exception {

Nice tests!

-------------

Marked as reviewed by mcimadamore (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1910#pullrequestreview-3670098723
PR Review Comment: https://git.openjdk.org/valhalla/pull/1910#discussion_r2697911024
PR Review Comment: https://git.openjdk.org/valhalla/pull/1910#discussion_r2697918823