[lworld] RFR: 8375526: [lworld] Missing newline in fieldDescriptor::print_on_for
Marc Chevalier
mchevalier at openjdk.org
Fri Jan 16 11:16:47 UTC 2026
On Fri, 16 Jan 2026 10:47:00 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> There is a missing newline in the output of `fieldDescriptor::print_on_for`.
>
> Without the fix:
>
> "Executing pp"
> java.lang.Runtime$Version
> {0x00000007ffd0c9e0} - klass: 'java/lang/Runtime$Version' - flags:
>
> - ---- fields (total size 5 words):
> - private final value 'version' 'Ljava/util/List;' @12 a 'java/util/ImmutableCollections$List12'{0x00000007ffd0ca08} (0xfffa1941)
> - private final value 'pre' 'Ljava/util/Optional;' @16 Flat inline type field 'java/util/Optional': null - private final value 'build' 'Ljava/util/Optional;' @24 Flat inline type field 'java/util/Optional': null - private final value 'optional' 'Ljava/util/Optional;' @32 Flat inline type field 'java/util/Optional': null$1 = (void *) 0x0
>
>
> With the fix:
>
> "Executing pp"
> java.lang.Runtime$Version
> {0x00000007ffd0ced8} - klass: 'java/lang/Runtime$Version' - flags:
>
> - ---- fields (total size 5 words):
> - private final value 'version' 'Ljava/util/List;' @12 a 'java/util/ImmutableCollections$List12'{0x00000007ffd0cf00} (0xfffa19e0)
> - private final value 'pre' 'Ljava/util/Optional;' @16 Flat inline type field 'java/util/Optional': null
> - private final value 'build' 'Ljava/util/Optional;' @24 Flat inline type field 'java/util/Optional': null
> - private final value 'optional' 'Ljava/util/Optional;' @32 Flat inline type field 'java/util/Optional': null
>
>
> Thanks,
> Tobias
Good. Trivial.
-------------
Marked as reviewed by mchevalier (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1920#pullrequestreview-3670378200
More information about the valhalla-dev
mailing list