[lworld] RFR: 8375602: [lworld] Test verifiers should verify the equivalence of the objects if possible [v2]
Quan Anh Mai
qamai at openjdk.org
Tue Jan 20 11:17:14 UTC 2026
> Hi,
>
> There are numerous tests of which verifiers assert that the hash value of 2 objects are equal to verify that those objects are equal. As `acmp` has become more mature, this PR updates those to verify that 2 objects are equal. This is more straightforward and it produces a nicer debug message in case of failures. I changed the order of some asserts that are changed or nearby. This is because the argument order of assert is `(expected, actual)`, and the assertion message would be `expected: ..., but was: ...`, so changing the order to the correct one gives us a more intuitive message.
>
> A side effect of this PR is that it helps reproduce [JDK-8372824](https://bugs.openjdk.org/browse/JDK-8372824) in a consistent manner with `-XX:+UnlockExperimentalVMOptions -XX:PerMethodSpecTrapLimit=0 -XX:PerMethodTrapLimit=0`.
>
> Please take a look and leave your reviews, thanks a lot.
Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
copyright year
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/1929/files
- new: https://git.openjdk.org/valhalla/pull/1929/files/19bac703..674656de
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=1929&range=01
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1929&range=00-01
Stats: 8 lines in 8 files changed: 0 ins; 0 del; 8 mod
Patch: https://git.openjdk.org/valhalla/pull/1929.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1929/head:pull/1929
PR: https://git.openjdk.org/valhalla/pull/1929
More information about the valhalla-dev
mailing list