RFR: Classfile signature bang support [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Jan 21 16:01:33 UTC 2026
On Tue, 20 Jan 2026 21:23:41 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Support parsing ! signatures in ClassFile API.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Review, various cleanup
> - Merge branch 'bworld' of https://github.com/openjdk/valhalla into feature/cf-bang-sig
> - Classfile signature bang support
src/java.base/share/classes/java/lang/classfile/ClassSignature.java line 84:
> 82: * @param superclassSignature the superclass
> 83: * @param superinterfaceSignatures the interfaces
> 84: * @throws IllegalArgumentException if any signature has null marker
Suggestion:
* @throws IllegalArgumentException if any signature has null markers
src/java.base/share/classes/java/lang/classfile/ClassSignature.java line 96:
> 94: * @param superclassSignature the superclass
> 95: * @param superinterfaceSignatures the interfaces
> 96: * @throws IllegalArgumentException if any signature has null marker
Suggestion:
* @throws IllegalArgumentException if any signature has null markers
src/java.base/share/classes/java/lang/classfile/MethodSignature.java line 136:
> 134: * @param arguments signatures for the method parameters
> 135: * @throws IllegalArgumentException if any of {@code arguments} is void or
> 136: * any of the exceptions signatures has null marker
Suggestion:
* any of the exceptions signatures has null markers
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1933#discussion_r2713228222
PR Review Comment: https://git.openjdk.org/valhalla/pull/1933#discussion_r2713228897
PR Review Comment: https://git.openjdk.org/valhalla/pull/1933#discussion_r2713229939
More information about the valhalla-dev
mailing list