[lworld] RFR: 8376088: [lworld] value class creation in CompileJavaModules.gmk leaves unnecessary files [v2]

David Beaumont duke at openjdk.org
Thu Jan 22 21:01:50 UTC 2026


On Thu, 22 Jan 2026 20:53:09 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove problem list entry
>
> make/CompileJavaModules.gmk line 185:
> 
>> 183: 		$(TOUCH) $@
>> 184: 
>> 185:     TARGETS += $(MODULE_OUTPUTDIR)/_the.java.base.valueclasses
> 
> Maybe not call this `java.base` since this code isn't explicitly specific to the java.base module.

*doh* - that needs to use `$(MODULE)` - thanks.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1949#discussion_r2718610564


More information about the valhalla-dev mailing list