RFR: Remove redundant null checks [v5]
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Jan 23 15:29:21 UTC 2026
On Fri, 23 Jan 2026 13:33:31 GMT, Vicente Romero <vromero at openjdk.org> wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/NullChecksWriter.java line 213:
>>
>>> 211:
>>> 212: private boolean isInThisSameCompUnit(Symbol sym) {
>>> 213: return env.toplevel.getTypeDecls().stream()
>>
>> Isn't this the same as `env.enclClass.sym.outermostClass() == sym.outermostClass()` ?
>
> not sure, what if there are more than one top level class in the same compilation unit?
Ah ok -- if you count aux classes, then yeah
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1947#discussion_r2721688010
More information about the valhalla-dev
mailing list