[lworld] RFR: 8376088: [lworld] value class creation in CompileJavaModules.gmk leaves unnecessary files [v5]

David Beaumont duke at openjdk.org
Mon Jan 26 15:57:06 UTC 2026


> This is a tidying up of the value class generation and management.
> It solves JDK-8376088, but also simplifies the two-step process for creating the `META-INF/preview` class files.
> 
> Short description of changes:
> 1. Remove JAR file creation (no longer needed, this is the proximal fix for JDK-8376088).
> 2. Stop adding the "intermediate" target for the compilation to the TARGETS list (rely on the subsequent copy).
> 3. Copy directories directly from the output directory to the preview directory (does not copy marker files).
> 4. Make the marker file appear alongside other markers for the module compilation.
> 5. Rename marker file to be consistent with other sibling marker files.
> 
> The marker files in `build/linux-x64/jdk/modules/java.base/` are now:
> 
> 
> _the.java.base_batch
> _the.java.base_batch.cmdline
> _the.java.base_batch.filelist
> _the.java.base_batch.log
> _the.java.base_batch.modfiles
> _the.java.base_batch.modfiles.fixed
> _the.java.base.config_vardeps
> _the.java.base_internalapi
> _the.java.base-javacserver.conf
> _the.java.base_pubapi
> _the.java.base.valueclasses   <-- moved/renamed mark file
> _the.java.base.vardeps
> 
> 
> I've added a couple of notes where there could be choices about the implementation.

David Beaumont has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Merge branch 'lworld' into makefile_tidying

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/1949/files
  - new: https://git.openjdk.org/valhalla/pull/1949/files/3f47c150..902239bc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1949&range=04
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1949&range=03-04

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/valhalla/pull/1949.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1949/head:pull/1949

PR: https://git.openjdk.org/valhalla/pull/1949


More information about the valhalla-dev mailing list