[lworld] RFR: 8359147: [lworld] Print early_larval_frame in VerifyError reporting
Matias Saavedra Silva
matsaave at openjdk.org
Mon Jan 26 17:44:02 UTC 2026
On Mon, 26 Jan 2026 17:01:37 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:
>> This patch updates stackMapTableFormat.hpp to handle early_larval frames so they can be correctly printed in the case of verification errors, especially those introduced with the handling of early_larval frames and strict fields. Note that early_larval frames "wrap" normal stack map frames so they are handled differently. Verified with tier 1-5 tests.
>
> src/hotspot/share/classfile/stackMapTableFormat.hpp line 408:
>
>> 406: return 0; }
>> 407: static u1 offset_delta_to_frame_type(int offset_delta) {
>> 408: return checked_cast<u1>(246); }
>
> Putting the closing `}` on the same line as the return is an odd formatting convention. I know it matches the frame definition above but it's the kind of thing I wouldn't propagate
Thanks for catching that, I don't like it either. I can just fix all of them in this patch.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1973#discussion_r2728596247
More information about the valhalla-dev
mailing list