[lworld] RFR: 8376042: [lworld] Revert changes to --patch-module handling [v3]

Matias Saavedra Silva matsaave at openjdk.org
Mon Jan 26 18:32:24 UTC 2026


On Fri, 23 Jan 2026 18:39:31 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restore assert
>
> src/hotspot/share/classfile/systemDictionary.cpp line 953:
> 
>> 951:                                                PackageEntry* pkg_entry,
>> 952:                                                Handle class_loader) {
>> 953:   assert(!CDSConfig::module_patching_disables_cds(), "Cannot use CDS");
> 
> Mainline has a different assert here, should it be restored to have identical code between lworld and jdk/master?

This was probably removed from lworld because it would have triggered with the migrated value classes jar. I think it's safe to restore it.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1950#discussion_r2728763461


More information about the valhalla-dev mailing list