[lworld] RFR: 8376221: [lworld] Do not store array of InlineLayoutInfo for all InstanceKlasses [v4]

[Joel Sikström]

On Mon, 26 Jan 2026 10:29:29 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Joel Sikström has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Exception check should really be an assert
>>  - Move inlineable check to static helper
>
> src/hotspot/share/classfile/fieldLayoutBuilder.cpp line 848:
> 
>> 846:           || (!fieldinfo.field_flags().is_injected()
>> 847:               && _inline_layout_info_array != nullptr && _inline_layout_info_array->adr_at(field_index)->klass() != nullptr
>> 848:               && !_inline_layout_info_array->adr_at(field_index)->klass()->is_identity_class())) {
> 
> Pre-existing:
> I wonder if this should be a helper function. (Maybe the whole predicate should be)
> 
> But we are really asking is the klass of field type at `field_index` not an identity class. The null checks seems like implementation details.

I moved the entire predicate to a helper function with some comments, which I agree is easier to read and understand.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1966#discussion_r2731171434