[lworld] RFR: 8374786: [lworld] C2: Missing asserts in parse3.cpp after merging JDK-8341411
Tobias Hartmann
thartmann at openjdk.org
Tue Jan 27 14:04:44 UTC 2026
On Tue, 27 Jan 2026 13:45:00 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
> When merging in [JDK-8341411](https://bugs.openjdk.org/browse/JDK-8341411), we wrongly dropped the following two similar asserts:
>
> assert(C->get_alias_index(adr_type) == C->get_alias_index(_gvn.type(adr)->isa_ptr()),
> "slice of address and input slice don't match");
>
> This was difficult to spot because `adr` was only defined further down in the code at the time of the merge. [JDK-8357474](https://bugs.openjdk.org/browse/JDK-8357474) moved `adr` up to the place where we also define it in mainline which is how it was noticed that they are missing. This patch simply adds the asserts again
>
> Thanks,
> Christian
Looks good.
-------------
Marked as reviewed by thartmann (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1982#pullrequestreview-3711377177
More information about the valhalla-dev
mailing list