RFR: fixing bug in null checks generation [v5]
Vicente Romero
vromero at openjdk.org
Wed Jan 28 16:09:19 UTC 2026
> Javac is generating erroneous null checks for code like, test case provided by Jan:
>
>
> public class Main {
> public String g() {
> return Other.str = "";
> }
> }
> class Other {
> public static String! str = "";
> }
>
> so there is no point in generating null checks on the left side of an assignment statement. So the proposal is to use a switch to indicate when null checks shouldn't be generated.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
unrolling assignop in Lower
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/1972/files
- new: https://git.openjdk.org/valhalla/pull/1972/files/520289e3..c352b108
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=1972&range=04
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1972&range=03-04
Stats: 89 lines in 3 files changed: 74 ins; 12 del; 3 mod
Patch: https://git.openjdk.org/valhalla/pull/1972.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1972/head:pull/1972
PR: https://git.openjdk.org/valhalla/pull/1972
More information about the valhalla-dev
mailing list