[lworld] RFR: 8374025: [lworld] valhalla/valuetypes/SubstitutabilityTest.java fails due to argument clashes
Paul Hübner
phubner at openjdk.org
Thu Jan 29 14:57:14 UTC 2026
On Thu, 29 Jan 2026 14:49:34 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> Is there a clear reason that SubstitutabilityTest needs to be run with -Xshare:off? I can't think of a direct case where CDS or no-CDS has any impact on substitutability. If there's a clear need it should be documented.
Good point. We split it up for easier problem listing. I think initially, we used `-Xshare:off` because CDS didn't support the new subst. test. I suppose this isn't strictly needed anymore (we support it!), but another argument could be that this is a good sanity check for CDS. I'm not particularly opinionated one way or another.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1995#issuecomment-3818202864
More information about the valhalla-dev
mailing list