RFR: [type-classes] 8375482: Basic tests for UnsignedInt [v2]
Joe Darcy
darcy at openjdk.org
Thu Jan 29 20:13:35 UTC 2026
On Thu, 29 Jan 2026 18:20:35 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix min/max typo.
>
> src/java.base/share/classes/java/lang/UnsignedInt.java line 41:
>
>> 39: // implementing Serializable. Might implement Comparable<UnsignedInt>.
>> 40:
>> 41: private static Integral<UnsignedInt> INT = new Integral<UnsignedInt>() {
>
> Suggestion:
>
> private static final Integral<UnsignedInt> INT = new Integral<UnsignedInt>() {
Sure; I'll final-ize that next time I'm updating the file. I'm going to experiment with adding a public Integral witness to unlock the bit-wise operations.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1991#discussion_r2743332791
More information about the valhalla-dev
mailing list