[lworld] RFR: 8376135: [lworld] Add JIT support for NULLABLE_NON_ATOMIC_FLAT layout [v5]
Frederic Parain
fparain at openjdk.org
Fri Jan 30 15:27:24 UTC 2026
On Tue, 27 Jan 2026 09:37:06 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add assert
>
> test/hotspot/jtreg/runtime/valhalla/inlinetypes/FlatArraysTest.java line 474:
>
>> 472: }
>> 473:
>> 474: static value class FieldsHolder {
>
> I don't see why this class needs to be `value`, and making it `value` allows `nav` to be a `NULLABLE_NON_ATOMIC`, to which there is no corresponding array.
This test was written before NULLABLE_NON_ATOMIC_FLAT layout exists. It is correct for the test to make the FieldHolder class an identity class.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1970#discussion_r2746791071
More information about the valhalla-dev
mailing list