<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Aptos;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:12.0pt;
font-family:"Aptos",sans-serif;
mso-ligatures:standardcontextual;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#467886;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Aptos",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1336304627;
mso-list-template-ids:1208091838;}
@list l0:level1
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:36.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:72.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:"Courier New";
mso-bidi-font-family:"Times New Roman";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:108.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:144.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:180.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:216.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:252.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:288.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:324.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l1
{mso-list-id:1674910944;
mso-list-template-ids:-728988334;}
@list l2
{mso-list-id:1761636828;
mso-list-template-ids:-1552273708;}
@list l3
{mso-list-id:1932228244;
mso-list-template-ids:-1033480076;}
@list l3:level1
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:36.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l3:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:72.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:"Courier New";
mso-bidi-font-family:"Times New Roman";}
@list l3:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:108.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l3:level4
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:144.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l3:level5
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:180.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l3:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:216.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l3:level7
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:252.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l3:level8
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:288.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l3:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:324.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-IN" link="#467886" vlink="#96607D" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi All,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I have just merged the latest lworld code into lworld+vector branch after 3+ months.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">PR : <a href="https://github.com/openjdk/valhalla/pull/1436">
https://github.com/openjdk/valhalla/pull/1436</a><o:p></o:p></p>
<p class="MsoNormal">Commit : <a href="https://github.com/openjdk/valhalla/commit/50897b2885b98977fbfef5bc522847be099e289c">
https://github.com/openjdk/valhalla/commit/50897b2885b98977fbfef5bc522847be099e289c</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">There are some jtreg failures with different validation configurations after this merge which I plan to fix in subsequent bug fix PRs.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please refer to the following commit notes for details.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best Regards,<o:p></o:p></p>
<p class="MsoNormal">Jatin<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>Commit Notes:-<o:p></o:p></b></p>
<ul style="margin-top:0cm" type="disc">
<li class="MsoNormal" style="mso-list:l0 level1 lfo1">Removed @ImplicitlyConstructibleValue annotation from all VectorPayloadMF* classes.<o:p></o:p></li><li class="MsoNormal" style="mso-list:l0 level1 lfo1">Annotated multifield backed payload with <a href="https://github.com/strict"><b>@strict</b></a> annotation.<o:p></o:p></li><li class="MsoNormal" style="mso-list:l0 level1 lfo1">Re-alignment of the new shuffle implementation with multifield-backed payloads.<o:p></o:p></li><li class="MsoNormal" style="mso-list:l0 level1 lfo1">Fine tuning to skip over value forwarding vector boxes to handle non-flat payloads with -XX:-UseNonAtomicValueFlattening) in see_through_inline_type.<o:p></o:p></li><li class="MsoNormal" style="mso-list:l0 level1 lfo1">Fix in PhaseMacroExpand::eliminate_allocate_node to skip over the elimination of larval allocations.<o:p></o:p></li><li class="MsoNormal" style="mso-list:l0 level1 lfo1">New InlineTypeNode Identity transform to forward VectorBoxes tied to oop fields.<br>
Such patterns are generated during incremental inlining when vector intrinsic call is replaced<br>
by an equivalent VetorBoxNode. At this point, we don't require rematerializing InlineTypeNode chain<br>
earlier tied to vector oop returned by intrinsic call.<o:p></o:p></li><li class="MsoNormal" style="mso-list:l0 level1 lfo1">Turning off AbortVMOnCompilationFailure for test/hotspot/jtreg/compiler/vectorapi/VectorMemoryAlias.java<br>
to avoid test failures due to compilation bailouts related make/finish private buffer intrinsic.<o:p></o:p></li></ul>
<p class="MsoNormal" style="margin-left:36.0pt"><o:p> </o:p></p>
<p class="MsoNormal"><b>Functional Validation:-<o:p></o:p></b></p>
<p class="MsoNormal">Valhalla JTREG tests configuration tested:-<o:p></o:p></p>
<ol style="margin-top:0cm" start="1" type="1">
<li class="MsoNormal" style="mso-list:l2 level1 lfo2">Default Settings [2 FAILURES<br>
compiler/valhalla/inlinetypes/TestFieldNullMarkers.java compiler/valhalla/inlinetypes/TestLWorld.java<br>
]<o:p></o:p></li><li class="MsoNormal" style="mso-list:l2 level1 lfo2">With -XX:+DeoptimizeALot -XX:+SafePointALot [4 FAILURES]<br>
compiler/valhalla/inlinetypes/TestAllocationMergeAndFolding.java<br>
compiler/valhalla/inlinetypes/TestC2CCalls.java<br>
compiler/valhalla/inlinetypes/TestFieldNullMarkers.java<br>
compiler/valhalla/inlinetypes/TestLWorld.java ]<o:p></o:p></li></ol>
<p class="MsoNormal">VectorAPI JTREG test configurations tested:-<o:p></o:p></p>
<ol style="margin-top:0cm" start="1" type="1">
<li class="MsoNormal" style="mso-list:l1 level1 lfo3">Default Settings - [ALL GREEN]<o:p></o:p></li><li class="MsoNormal" style="mso-list:l1 level1 lfo3">With -XX:+DeoptimizeALot -XX:+SafePointALot [ Intermittent failures ]<o:p></o:p></li><li class="MsoNormal" style="mso-list:l1 level1 lfo3">With-XX:-UseNonAtomicValueFlattening [ALL GREEN except 1 failure compiler/vectorapi/TestReverseByteTransforms.java on KNL]<o:p></o:p></li></ol>
<p class="MsoNormal" style="margin-left:36.0pt"><o:p> </o:p></p>
<p class="MsoNormal"><b>Additional Notes:-<o:p></o:p></b></p>
<ul style="margin-top:0cm" type="disc">
<li class="MsoNormal" style="mso-list:l3 level1 lfo4">With the removal of the flat field size capping runtime flag 'InlineTypeMaxFlatSize', all vector payload fields<br>
by default have a flat layout within concrete vector containers.<o:p></o:p></li><li class="MsoNormal" style="mso-list:l3 level1 lfo4">Since VectorPayloadMF* classes are decorated with LooselyConsistentValue annotation and payload fields are marked<br>
as @NullRestricted with <a href="https://github.com/strict"><b>@strict</b></a> field semantics, the only way to prevent payload flattening is through runtime flag -XX:-UseNonAtomicValueFlattening.<o:p></o:p></li></ul>
<p class="MsoNormal" style="margin-left:36.0pt"><o:p> </o:p></p>
<p class="MsoNormal"><b>Performance:-<o:p></o:p></b></p>
<p class="MsoNormal">Fixed redundant boxing hitting performance of almost all vector kernels. After incremental inlining, VectorBox was getting connected to safepoint nodes through a series of InlineTypeNodes, which were materialized from the return value of
CallStaticJavaNode IR created for vector intrinsic entry points after parsing. Removing redundantly materialized InlineTypeNode through an InlineTypeNode::Identity transform directly connects the VectorBoxNode to the Safepoint, thereby enabling box elimination.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>