hg: verona/stage/jdk: 8087202: Add support for PATCH field and remove unused fields of new version string

[Magnus Ihse Bursie]

On 2015-08-19 14:47, Alejandro E Murillo wrote:
>
>
> On 8/18/2015 6:19 AM, Magnus Ihse Bursie wrote:
>> On 2015-06-22 22:08, alejandro.murillo at oracle.com wrote:
>>> Changeset: 60387e5d6822
>>> Author:    amurillo
>>> Date:      2015-06-19 10:58 -0700
>>> URL: http://hg.openjdk.java.net/verona/stage/jdk/rev/60387e5d6822
>>>
>>> 8087202: Add support for PATCH field and remove unused fields of new 
>>> version string
>>> Reviewed-by: dholmes, alanb
>>>
>>> ! make/mapfiles/libjava/mapfile-vers
>>> ! src/java.base/share/classes/sun/misc/Version.java.template
>>> ! src/java.base/share/native/include/jvm.h
>>> ! src/java.base/share/native/libjava/Version.c
>>> ! src/java.base/share/native/libjava/jdk_util.c
>>> ! test/sun/misc/Version/Version.java
>>>
>> Hi Alejandro,
>>
>> A question about test/sun/misc/Version/Version.java. The toString() 
>> function seems to not follow the JEP rules about no trailing zeros? 
>> Or am I missing something?
>>
>> /Magnus
> Hi Magnus,
> welcome back

Thanks :)
> haven't seen that code in a while now,
> but I suspect it might need some tweaking to avoid outputting
> extra zeros when some version fields are not defined.
> I was off yesterday and off today and Friday
> might not have time to look at it Thursday,
> so I won't probably get to that until next week,
> so feel free to work on that if you have a chance,

I'll gladly leave it to you. :) I just noticed that it looked weird when 
I skimmed through the accumulated mails and pushes.
> as we are approaching the integration deadline
> (although this is a test, so it can be fixed afterward as well).
>
> Also, it might need to be changed to use the new Version class

Is that available now? I never saw the commit for that.

/Magnus

>
> Thanks
>