How will the webrev script in existing repos be updated?

Mike Duigou mike.duigou at oracle.com
Tue Jan 7 10:58:59 PST 2014


On Jan 7 2014, at 10:50 , Stuart Marks <stuart.marks at oracle.com> wrote:

> On 1/7/14 10:37 AM, Mike Duigou wrote:
>> I have been working on a patch in the JDK 9 repo, JDK-8029512, which I have now moved to CODETOOLS as CODETOOLS-7900304 (https://bugs.openjdk.java.net/browse/CODETOOLS-7900304). I am ready to push this change but curious what is supposed to happen afterwards. I would like to see the updated webrev pushed into jdk7u60, jdk8u20 and jdk9 repos.
> 
> Shouldn't we just remove webrev from the other repos? Either it'll have to be patched into each different release (more busywork) or it'll get out of date.

Yes, busywork indeed. There are many places that the updated should be installed--every repo it appears in actually.

> Do the different releases have any different requirements on webrev?

No. Since they all try to generate links to the same bug database it's actually appropriate for all projects to be using the same version of webrev.

> I hope not. I'd like to have one copy in CODETOOLS that everybody can use.

Yep. Getting it to people is going to be the issue. I have heard grumblings about the annoyance of installing/updating jcheck locally. I suspect that with moving to CODETOOLS we are going to see more incidents of people using stale webrev again. It had been nice for a while in 8 that people were moving towards using the bundled up-to-date webrev rather than some hoary old version. Perhaps this might be a case where we can legitimately use mecurial sub-projects?

> There are probably README and wiki pages that need to be updated to point to the new location.

Yes. As you had to remind me just before the holiday break (and I promptly forgot), there is now a webrev project! I suspect that few people would find it on their own.

Mike


More information about the webrev-dev mailing list