From mike.duigou at oracle.com Sat Jul 12 02:11:33 2014 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 11 Jul 2014 19:11:33 -0700 Subject: RFR: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo In-Reply-To: <53AC5B69.6090300@oracle.com> References: <53AC4D67.8080908@oracle.com> <53AC4F3A.1060101@oracle.com> <53AC5B69.6090300@oracle.com> Message-ID: On Jun 26 2014, at 10:42 , Daniel Fuchs wrote: > Hi Jon, > > On 6/26/14 6:50 PM, Jonathan Gibbons wrote: >> Daniel, >> >> Do you want to update the version string near the head of the file, or should I? > Oh - does it need to be updated again? Yes, every time. :-) >> >> Why so many apparent white-space diffs? > > I'm not seeing any white space diff? Nor am I Mike > -- daniel > >> >> -- Jon >> >> On 06/26/2014 09:42 AM, Daniel Fuchs wrote: >>> Hi, >>> >>> Please find below a patch for: >>> >>> CODETOOLS-7900964 - [webrev] Option -f does not generate >>> diffs for files whose path happens to >>> contain the name of their repo >>> >>> https://bugs.openjdk.java.net/browse/CODETOOLS-7900964 >>> >>> http://cr.openjdk.java.net/~dfuchs/webrev_CODETOOLS-7900964/webrev.00/ >>> >>> The change is simple: >>> >>> The only case where should *not* print the name of the tree is when >>> the index returned by index($1,tree) is 1 - so changing (n == 0) in >>> (n != 1) solves the issue. >>> >>> best regards, >>> >>> -- daniel >> > From mike.duigou at oracle.com Sat Jul 12 02:13:30 2014 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 11 Jul 2014 19:13:30 -0700 Subject: RFR: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo In-Reply-To: <53AC4D67.8080908@oracle.com> References: <53AC4D67.8080908@oracle.com> Message-ID: Looks fine to me. Mike On Jun 26 2014, at 09:42 , Daniel Fuchs wrote: > Hi, > > Please find below a patch for: > > CODETOOLS-7900964 - [webrev] Option -f does not generate > diffs for files whose path happens to > contain the name of their repo > > https://bugs.openjdk.java.net/browse/CODETOOLS-7900964 > > http://cr.openjdk.java.net/~dfuchs/webrev_CODETOOLS-7900964/webrev.00/ > > The change is simple: > > The only case where should *not* print the name of the tree is when > the index returned by index($1,tree) is 1 - so changing (n == 0) in > (n != 1) solves the issue. > > best regards, > > -- daniel From daniel.fuchs at oracle.com Tue Jul 15 09:02:02 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 15 Jul 2014 11:02:02 +0200 Subject: RFR: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo In-Reply-To: References: <53AC4D67.8080908@oracle.com> Message-ID: <53C4EE0A.5040002@oracle.com> On 7/12/14 4:13 AM, Mike Duigou wrote: > Looks fine to me. > > Mike > Thanks Mike! I have generated a changeset that can be hg imported: http://cr.openjdk.java.net/~dfuchs/webrev_CODETOOLS-7900964/webrev.01/webrev.changeset and updated the version string to WEBREV_UPDATED=25.5-hg+openjdk.java.net (only difference compared to previous webrev of webrev ;-)) Jon, will you be able to sponsor it? best regards, -- daniel From jonathan.gibbons at oracle.com Tue Jul 15 17:27:22 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 15 Jul 2014 10:27:22 -0700 Subject: RFR: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo In-Reply-To: <53C4EE0A.5040002@oracle.com> References: <53AC4D67.8080908@oracle.com> <53C4EE0A.5040002@oracle.com> Message-ID: <53C5647A.3010201@oracle.com> Will try and push it this afternoon. -- Jon On 07/15/2014 02:02 AM, Daniel Fuchs wrote: > On 7/12/14 4:13 AM, Mike Duigou wrote: >> Looks fine to me. >> >> Mike >> > > Thanks Mike! > > I have generated a changeset that can be hg imported: > > http://cr.openjdk.java.net/~dfuchs/webrev_CODETOOLS-7900964/webrev.01/webrev.changeset > > > and updated the version string to > WEBREV_UPDATED=25.5-hg+openjdk.java.net > (only difference compared to previous webrev of webrev ;-)) > > Jon, will you be able to sponsor it? > > best regards, > > -- daniel From jonathan.gibbons at oracle.com Wed Jul 16 01:34:37 2014 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 16 Jul 2014 01:34:37 +0000 Subject: hg: code-tools/webrev: 7900964: [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo Message-ID: <201407160134.s6G1YbQR012267@aojmv0008> Changeset: 6c87867c3837 Author: dfuchs Date: 2014-07-15 10:54 +0200 URL: http://hg.openjdk.java.net/code-tools/webrev/rev/6c87867c3837 7900964: [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo Summary: changed (n == 0) into (n != 1) - n == 0 means the pattern is not found, n != 1 means it does not start with the pattern but may contain it elsewhere. Reviewed-by: mduigou ! webrev.ksh From jonathan.gibbons at oracle.com Wed Jul 16 00:49:19 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 15 Jul 2014 17:49:19 -0700 Subject: RFR: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo In-Reply-To: <53C4EE0A.5040002@oracle.com> References: <53AC4D67.8080908@oracle.com> <53C4EE0A.5040002@oracle.com> Message-ID: <53C5CC0F.2000409@oracle.com> On 07/15/2014 02:02 AM, Daniel Fuchs wrote: > Jon, will you be able to sponsor it? > > best regards, > > -- daniel done From mike.duigou at oracle.com Wed Jul 16 19:04:07 2014 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 16 Jul 2014 12:04:07 -0700 Subject: RFR: 7900976: [webrev] preformat for author comments Message-ID: Hello all; This is a patch provided by Roger Riggs. It adds 
 around the included (-i option) author comments or webrev-info. This patch assumes that the content to be included is text. If anyone has been using this feature to include html then this change will no longer include the text correctly. The other option would be to make a separate option for including html vs including text. If nobody expects that the included text is html then we can just go ahead with this change. Googling for ["Code Review" webrev "Author comments"] found that the feature was very sparsely used and in only one case was the comment not plain text, http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2007-December/000045.html

The webrev includes a sample of preformatted included text with line breaks.

webrev: http://cr.openjdk.java.net/~mduigou/CODETOOLS-7900976/0/webrev/

Mike

From daniel.fuchs at oracle.com  Thu Jul 17 12:25:54 2014
From: daniel.fuchs at oracle.com (Daniel Fuchs)
Date: Thu, 17 Jul 2014 14:25:54 +0200
Subject: RFR: 7900976: [webrev] preformat for author comments
In-Reply-To: 
References: 
Message-ID: <53C7C0D2.70102@oracle.com>

Looks good Mike.

I applied the patch and tried it. I didn't know about the -i
option, but I think I'm going to use that now :-)

And BTW there's still a work around if you really want to
write your author comments in HTML:
You just need to start with  and end with 
 such as in

webrev-info:
-------------------------

    

  1. first line
    2. 

  2. second line
    3. 

      -------------------------

best regards,

-- daniel


On 7/16/14 9:04 PM, Mike Duigou wrote:
> Hello all;
>
> This is a patch provided by Roger Riggs. It adds 
       around the included (-i option) author comments or webrev-info. This patch assumes that the content to be included is text. If anyone has been using this feature to include html then this change will no longer include the text correctly. The other option would be to make a separate option for including html vs including text. If nobody expects that the included text is html then we can just go ahead with this change. Googling for ["Code Review" webrev "Author comments"] found that the feature was very sparsely used and in only one case was the comment not plain text, http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2007-December/000045.html
>
> The webrev includes a sample of preformatted included text with line breaks.
>
> webrev: http://cr.openjdk.java.net/~mduigou/CODETOOLS-7900976/0/webrev/
>
> Mike
>


From mike.duigou at oracle.com  Thu Jul 17 15:22:18 2014
From: mike.duigou at oracle.com (Mike Duigou)
Date: Thu, 17 Jul 2014 08:22:18 -0700
Subject: RFR: 7900976: [webrev] preformat for author comments
In-Reply-To: <53C7C0D2.70102@oracle.com>
References: 
	<53C7C0D2.70102@oracle.com>
Message-ID: 


On Jul 17 2014, at 05:25 , Daniel Fuchs  wrote:

> Looks good Mike.
> 
> I applied the patch and tried it. I didn't know about the -i
> option, but I think I'm going to use that now :-)
> 
> And BTW there's still a work around if you really want to
> write your author comments in HTML:
> You just need to start with 
       and end with 
       such as in
> 
> webrev-info:
> -------------------------
> 
        
> 
      1. first line
        2. 
> 
      2. second line
        3. 
> 
          > -------------------------

Heh, Cool trick! It should suffice.

Mike

> 
> best regards,
> 
> -- daniel
> 
> 
> On 7/16/14 9:04 PM, Mike Duigou wrote:
>> Hello all;
>> 
>> This is a patch provided by Roger Riggs. It adds 
           around the included (-i option) author comments or webrev-info. This patch assumes that the content to be included is text. If anyone has been using this feature to include html then this change will no longer include the text correctly. The other option would be to make a separate option for including html vs including text. If nobody expects that the included text is html then we can just go ahead with this change. Googling for ["Code Review" webrev "Author comments"] found that the feature was very sparsely used and in only one case was the comment not plain text, http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2007-December/000045.html
>> 
>> The webrev includes a sample of preformatted included text with line breaks.
>> 
>> webrev: http://cr.openjdk.java.net/~mduigou/CODETOOLS-7900976/0/webrev/
>> 
>> Mike
>> 
>