RFR: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo

[Mike Duigou]

On Jun 26 2014, at 10:42 , Daniel Fuchs <daniel.fuchs at oracle.com> wrote:

> Hi Jon,
> 
> On 6/26/14 6:50 PM, Jonathan Gibbons wrote:
>> Daniel,
>> 
>> Do you want to update the version string near the head of the file, or should I?
> Oh - does it need to be updated again?

Yes, every time. :-)

>> 
>> Why so many apparent white-space diffs?
> 
> I'm not seeing any white space diff?

Nor am I

Mike


> -- daniel
> 
>> 
>> -- Jon
>> 
>> On 06/26/2014 09:42 AM, Daniel Fuchs wrote:
>>> Hi,
>>> 
>>> Please find below a patch for:
>>> 
>>> CODETOOLS-7900964 - [webrev] Option -f does not generate
>>>                    diffs for files whose path happens to
>>>                    contain the name of their repo
>>> 
>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7900964
>>> 
>>> http://cr.openjdk.java.net/~dfuchs/webrev_CODETOOLS-7900964/webrev.00/
>>> 
>>> The change is simple:
>>> 
>>> The only case where should *not* print the name of the tree is when
>>> the index returned by index($1,tree) is 1 - so changing (n == 0) in
>>> (n != 1) solves the issue.
>>> 
>>> best regards,
>>> 
>>> -- daniel
>> 
>