RFR: 7900976: [webrev] preformat for author comments

Mike Duigou mike.duigou at oracle.com
Wed Jul 16 19:04:07 UTC 2014


Hello all;

This is a patch provided by Roger Riggs. It adds <pre></pre> around the included (-i option) author comments or webrev-info. This patch assumes that the content to be included is text. If anyone has been using this feature to include html then this change will no longer include the text correctly. The other option would be to make a separate option for including html vs including text. If nobody expects that the included text is html then we can just go ahead with this change. Googling for ["Code Review" webrev "Author comments"] found that the feature was very sparsely used and in only one case was the comment not plain text, http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2007-December/000045.html

The webrev includes a sample of preformatted included text with line breaks.

webrev: http://cr.openjdk.java.net/~mduigou/CODETOOLS-7900976/0/webrev/

Mike


More information about the webrev-dev mailing list