RFR: 7900976: [webrev] preformat for author comments

[Mike Duigou]

On Jul 17 2014, at 05:25 , Daniel Fuchs <daniel.fuchs at oracle.com> wrote:

> Looks good Mike.
> 
> I applied the patch and tried it. I didn't know about the -i
> option, but I think I'm going to use that now :-)
> 
> And BTW there's still a work around if you really want to
> write your author comments in HTML:
> You just need to start with </pre> and end with <pre> such as in
> 
> webrev-info:
> -------------------------
> </pre><ol>
> <li>first line</li>
> <li>second line</li>
> <ol><pre>
> -------------------------

Heh, Cool trick! It should suffice.

Mike

> 
> best regards,
> 
> -- daniel
> 
> 
> On 7/16/14 9:04 PM, Mike Duigou wrote:
>> Hello all;
>> 
>> This is a patch provided by Roger Riggs. It adds <pre></pre> around the included (-i option) author comments or webrev-info. This patch assumes that the content to be included is text. If anyone has been using this feature to include html then this change will no longer include the text correctly. The other option would be to make a separate option for including html vs including text. If nobody expects that the included text is html then we can just go ahead with this change. Googling for ["Code Review" webrev "Author comments"] found that the feature was very sparsely used and in only one case was the comment not plain text, http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2007-December/000045.html
>> 
>> The webrev includes a sample of preformatted included text with line breaks.
>> 
>> webrev: http://cr.openjdk.java.net/~mduigou/CODETOOLS-7900976/0/webrev/
>> 
>> Mike
>> 
>