From mike.duigou at oracle.com Wed Jun 25 18:37:01 2014 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 25 Jun 2014 11:37:01 -0700 Subject: Push of CODETOOLS-7900327 and CODETOOLS -7900311 Message-ID: Both of these issues have been reviewed with the changes in use for quite some time. Would it be possible to push them? The only caution I can suggest is to make sure that the version number gets updated correctly. Mike From jonathan.gibbons at oracle.com Thu Jun 26 02:32:50 2014 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 26 Jun 2014 02:32:50 +0000 Subject: hg: code-tools/webrev: 7900311: webrev -r doesn't produce an exported changeset file Message-ID: <201406260232.s5Q2WoUJ019046@aojmv0008> Changeset: 09eb35524f9a Author: smarks Date: 2014-06-25 19:31 -0700 URL: http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a 7900311: webrev -r doesn't produce an exported changeset file Reviewed-by: mduigou ! webrev.ksh From jonathan.gibbons at oracle.com Thu Jun 26 02:40:26 2014 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 26 Jun 2014 02:40:26 +0000 Subject: hg: code-tools/webrev: 7900327: Change webrev to use 'trees' instead of 'forest' Message-ID: <201406260240.s5Q2eQ4H020355@aojmv0008> Changeset: 350bbc9b56d3 Author: dfuchs Date: 2014-06-25 19:40 -0700 URL: http://hg.openjdk.java.net/code-tools/webrev/rev/350bbc9b56d3 7900327: Change webrev to use 'trees' instead of 'forest' Reviewed-by: mduigou ! webrev.ksh From jonathan.gibbons at oracle.com Thu Jun 26 02:41:04 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 25 Jun 2014 19:41:04 -0700 Subject: Push of CODETOOLS-7900327 and CODETOOLS -7900311 In-Reply-To: References: Message-ID: <53AB8840.5040205@oracle.com> Done. Version updated in second patch. -- Jon On 06/25/2014 11:37 AM, Mike Duigou wrote: > Both of these issues have been reviewed with the changes in use for quite some time. Would it be possible to push them? > > The only caution I can suggest is to make sure that the version number gets updated correctly. > > Mike From daniel.fuchs at oracle.com Thu Jun 26 16:42:15 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Thu, 26 Jun 2014 18:42:15 +0200 Subject: RFR: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo Message-ID: <53AC4D67.8080908@oracle.com> Hi, Please find below a patch for: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo https://bugs.openjdk.java.net/browse/CODETOOLS-7900964 http://cr.openjdk.java.net/~dfuchs/webrev_CODETOOLS-7900964/webrev.00/ The change is simple: The only case where should *not* print the name of the tree is when the index returned by index($1,tree) is 1 - so changing (n == 0) in (n != 1) solves the issue. best regards, -- daniel From jonathan.gibbons at oracle.com Thu Jun 26 16:50:02 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 26 Jun 2014 09:50:02 -0700 Subject: RFR: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo In-Reply-To: <53AC4D67.8080908@oracle.com> References: <53AC4D67.8080908@oracle.com> Message-ID: <53AC4F3A.1060101@oracle.com> Daniel, Do you want to update the version string near the head of the file, or should I? Why so many apparent white-space diffs? -- Jon On 06/26/2014 09:42 AM, Daniel Fuchs wrote: > Hi, > > Please find below a patch for: > > CODETOOLS-7900964 - [webrev] Option -f does not generate > diffs for files whose path happens to > contain the name of their repo > > https://bugs.openjdk.java.net/browse/CODETOOLS-7900964 > > http://cr.openjdk.java.net/~dfuchs/webrev_CODETOOLS-7900964/webrev.00/ > > The change is simple: > > The only case where should *not* print the name of the tree is when > the index returned by index($1,tree) is 1 - so changing (n == 0) in > (n != 1) solves the issue. > > best regards, > > -- daniel From daniel.fuchs at oracle.com Thu Jun 26 17:42:01 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Thu, 26 Jun 2014 19:42:01 +0200 Subject: RFR: CODETOOLS-7900964 - [webrev] Option -f does not generate diffs for files whose path happens to contain the name of their repo In-Reply-To: <53AC4F3A.1060101@oracle.com> References: <53AC4D67.8080908@oracle.com> <53AC4F3A.1060101@oracle.com> Message-ID: <53AC5B69.6090300@oracle.com> Hi Jon, On 6/26/14 6:50 PM, Jonathan Gibbons wrote: > Daniel, > > Do you want to update the version string near the head of the file, or > should I? Oh - does it need to be updated again? > > Why so many apparent white-space diffs? I'm not seeing any white space diff? -- daniel > > -- Jon > > On 06/26/2014 09:42 AM, Daniel Fuchs wrote: >> Hi, >> >> Please find below a patch for: >> >> CODETOOLS-7900964 - [webrev] Option -f does not generate >> diffs for files whose path happens to >> contain the name of their repo >> >> https://bugs.openjdk.java.net/browse/CODETOOLS-7900964 >> >> http://cr.openjdk.java.net/~dfuchs/webrev_CODETOOLS-7900964/webrev.00/ >> >> The change is simple: >> >> The only case where should *not* print the name of the tree is when >> the index returned by index($1,tree) is 1 - so changing (n == 0) in >> (n != 1) solves the issue. >> >> best regards, >> >> -- daniel >