From bengt.rutisson at oracle.com Wed Oct 1 08:56:41 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 01 Oct 2014 10:56:41 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs Message-ID: <542BC1C9.9000204@oracle.com> Hi everyone, (This is a patch for webrev, but I am cross posting to the JDK 9 dev list since I'm not sure how many are on the webrev-dev list and most JDK developers might have opinions about this change.) Can I get a couple of reviews for this small enhancement to the webrev tool? CODETOOLS-7901044: Add next/prev links to navigate between diffs https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 Webrev: http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ Background: When browsing review requests that span many files it is quite time consuming to have to go back to the index page to view to the next or previous file. This patch adds links to the next and previous files in the diff views (including frames). The above webrev is generated with this new version, but since it only contains a single file it is not that interesting. Here is an example of what the new webrev looks like for a larger change (the G1 class unloading change): http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ Thanks, Bengt From daniel.fuchs at oracle.com Wed Oct 1 13:53:38 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Wed, 01 Oct 2014 15:53:38 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <542BC1C9.9000204@oracle.com> References: <542BC1C9.9000204@oracle.com> Message-ID: <542C0762.5070700@oracle.com> Hi Bengt, This is a really cool feature! I have downloaded your patch and applied it in my local webrev repo - and played with the new webrev in a couple of repositories where I have pending uncommitted changes. This seems to work well. I have used: webrev -fN from top level repo webrev -N from jdk repo webrev -fN from jdk repo (with changes in test/closed) I also had a cursory look at your patch. The only thing I noticed is that 'typeset' is not consistently used in the original webrev file. I'm not sure whether that's intended or not. I believe that's ok - but I've been bitten by not using typeset before ;-( - maybe - for the sake of uniformity - you could use typeset at least in those functions that already use it for their parameters? For instance lines 532-534, and possibly line 560 as well? Or did you intentionally not used it? Also you should increment the version of webrev. IIRC that would be 25.6: - WEBREV_UPDATED=25.5-hg+openjdk.java.net + WEBREV_UPDATED=25.6-hg+openjdk.java.net best regards, -- daniel On 01/10/14 10:56, Bengt Rutisson wrote: > > Hi everyone, > > (This is a patch for webrev, but I am cross posting to the JDK 9 dev > list since I'm not sure how many are on the webrev-dev list and most JDK > developers might have opinions about this change.) > > Can I get a couple of reviews for this small enhancement to the webrev > tool? > > CODETOOLS-7901044: Add next/prev links to navigate between diffs > https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 > > Webrev: > http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ > > > Background: > When browsing review requests that span many files it is quite time > consuming to have to go back to the index page to view to the next or > previous file. This patch adds links to the next and previous files in > the diff views (including frames). > > The above webrev is generated with this new version, but since it only > contains a single file it is not that interesting. Here is an example of > what the new webrev looks like for a larger change (the G1 class > unloading change): > > http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ > > Thanks, > Bengt > From bengt.rutisson at oracle.com Wed Oct 1 13:57:18 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 01 Oct 2014 15:57:18 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <542C0762.5070700@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> Message-ID: <542C083E.40208@oracle.com> Hi Daniel, Thanks for looking at this! On 2014-10-01 15:53, Daniel Fuchs wrote: > Hi Bengt, > > This is a really cool feature! Thanks! > > I have downloaded your patch and applied it in my > local webrev repo - and played with the new > webrev in a couple of repositories where I have > pending uncommitted changes. > > This seems to work well. > > I have used: > > webrev -fN from top level repo > webrev -N from jdk repo > webrev -fN from jdk repo (with changes in test/closed) > Great that you tired it out. > I also had a cursory look at your patch. The only thing > I noticed is that 'typeset' is not consistently used in > the original webrev file. I'm not sure whether that's > intended or not. > I believe that's ok - but I've been bitten by not using > typeset before ;-( - maybe - for the sake of uniformity - > you could use typeset at least in those functions that > already use it for their parameters? For instance > lines 532-534, and possibly line 560 as well? > Or did you intentionally not used it? I also noticed the inconsistent use of typeset. I fixed the lines you pointed out. I wasn't sure which way to go. But I think your suggestion is good. > > Also you should increment the version of webrev. > IIRC that would be 25.6: > > - WEBREV_UPDATED=25.5-hg+openjdk.java.net > + WEBREV_UPDATED=25.6-hg+openjdk.java.net Thanks, didn't think of that. New webrev: http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ Diff compared to the first version: http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ Thanks, Bengt > > best regards, > > -- daniel > > On 01/10/14 10:56, Bengt Rutisson wrote: >> >> Hi everyone, >> >> (This is a patch for webrev, but I am cross posting to the JDK 9 dev >> list since I'm not sure how many are on the webrev-dev list and most JDK >> developers might have opinions about this change.) >> >> Can I get a couple of reviews for this small enhancement to the webrev >> tool? >> >> CODETOOLS-7901044: Add next/prev links to navigate between diffs >> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >> >> Webrev: >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >> >> >> Background: >> When browsing review requests that span many files it is quite time >> consuming to have to go back to the index page to view to the next or >> previous file. This patch adds links to the next and previous files in >> the diff views (including frames). >> >> The above webrev is generated with this new version, but since it only >> contains a single file it is not that interesting. Here is an example of >> what the new webrev looks like for a larger change (the G1 class >> unloading change): >> >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >> >> >> Thanks, >> Bengt >> > From bengt.rutisson at oracle.com Wed Oct 1 14:00:42 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 01 Oct 2014 16:00:42 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: References: <542BC1C9.9000204@oracle.com> Message-ID: <542C090A.5030901@oracle.com> Hi David, On 2014-10-01 15:59, David Chase wrote: > I thought we had that in what I know of as ?webrev-new?, see for example: > > http://cr.openjdk.java.net/~drchase/8037816/webrev-9.05-09b/src/cpu/x86/vm/c1_LinearScan_x86.cpp.sdiff.html This looks like the version I know as "Tom's webrev" :) I think it is nice too. But it does not have next/prev for frames. The main problem with it, though, is that as far as I know there is no official policy that this is the preferred tool. I'd like to get this feature in to the official tool, which as far as I know is in the code-tools repo. > > But yours is also nice :-). Thanks. :) Bengt > > David > > On 2014-10-01, at 4:56 AM, Bengt Rutisson wrote: > >> Hi everyone, >> >> (This is a patch for webrev, but I am cross posting to the JDK 9 dev list since I'm not sure how many are on the webrev-dev list and most JDK developers might have opinions about this change.) >> >> Can I get a couple of reviews for this small enhancement to the webrev tool? >> >> CODETOOLS-7901044: Add next/prev links to navigate between diffs >> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >> >> Webrev: >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >> >> >> Background: >> When browsing review requests that span many files it is quite time consuming to have to go back to the index page to view to the next or previous file. This patch adds links to the next and previous files in the diff views (including frames). >> >> The above webrev is generated with this new version, but since it only contains a single file it is not that interesting. Here is an example of what the new webrev looks like for a larger change (the G1 class unloading change): >> >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >> >> Thanks, >> Bengt >> From daniel.fuchs at oracle.com Wed Oct 1 14:27:16 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Wed, 01 Oct 2014 16:27:16 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <542C083E.40208@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> Message-ID: <542C0F44.1000009@oracle.com> Hi Bengt, The new version looks good to me, but I am not a reviewer fore CODE_TOOLS. Hopefully someone who is will step in :-) best regards, -- daniel On 01/10/14 15:57, Bengt Rutisson wrote: > > Hi Daniel, > > Thanks for looking at this! > > On 2014-10-01 15:53, Daniel Fuchs wrote: >> Hi Bengt, >> >> This is a really cool feature! > > Thanks! > >> >> I have downloaded your patch and applied it in my >> local webrev repo - and played with the new >> webrev in a couple of repositories where I have >> pending uncommitted changes. >> >> This seems to work well. >> >> I have used: >> >> webrev -fN from top level repo >> webrev -N from jdk repo >> webrev -fN from jdk repo (with changes in test/closed) >> > > Great that you tired it out. > >> I also had a cursory look at your patch. The only thing >> I noticed is that 'typeset' is not consistently used in >> the original webrev file. I'm not sure whether that's >> intended or not. >> I believe that's ok - but I've been bitten by not using >> typeset before ;-( - maybe - for the sake of uniformity - >> you could use typeset at least in those functions that >> already use it for their parameters? For instance >> lines 532-534, and possibly line 560 as well? >> Or did you intentionally not used it? > > I also noticed the inconsistent use of typeset. I fixed the lines you > pointed out. I wasn't sure which way to go. But I think your suggestion > is good. > >> >> Also you should increment the version of webrev. >> IIRC that would be 25.6: >> >> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >> + WEBREV_UPDATED=25.6-hg+openjdk.java.net > > Thanks, didn't think of that. > > New webrev: > http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ > > Diff compared to the first version: > http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ > > Thanks, > Bengt > >> >> best regards, >> >> -- daniel >> >> On 01/10/14 10:56, Bengt Rutisson wrote: >>> >>> Hi everyone, >>> >>> (This is a patch for webrev, but I am cross posting to the JDK 9 dev >>> list since I'm not sure how many are on the webrev-dev list and most JDK >>> developers might have opinions about this change.) >>> >>> Can I get a couple of reviews for this small enhancement to the webrev >>> tool? >>> >>> CODETOOLS-7901044: Add next/prev links to navigate between diffs >>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>> >>> Webrev: >>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>> >>> >>> Background: >>> When browsing review requests that span many files it is quite time >>> consuming to have to go back to the index page to view to the next or >>> previous file. This patch adds links to the next and previous files in >>> the diff views (including frames). >>> >>> The above webrev is generated with this new version, but since it only >>> contains a single file it is not that interesting. Here is an example of >>> what the new webrev looks like for a larger change (the G1 class >>> unloading change): >>> >>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>> >>> >>> Thanks, >>> Bengt >>> >> > From bengt.rutisson at oracle.com Wed Oct 1 21:11:13 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 01 Oct 2014 23:11:13 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <542C0F44.1000009@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> Message-ID: <542C6DF1.1060409@oracle.com> Hi Daniel, On 10/1/14 4:27 PM, Daniel Fuchs wrote: > Hi Bengt, > > The new version looks good to me, but I am not a reviewer > fore CODE_TOOLS. Thanks for looking at this Daniel! > Hopefully someone who is will step in :-) Yes, and I am not a committer in code-tools so I need a sponsor for the patch too. Thanks, Bengt > > best regards, > > -- daniel > > On 01/10/14 15:57, Bengt Rutisson wrote: >> >> Hi Daniel, >> >> Thanks for looking at this! >> >> On 2014-10-01 15:53, Daniel Fuchs wrote: >>> Hi Bengt, >>> >>> This is a really cool feature! >> >> Thanks! >> >>> >>> I have downloaded your patch and applied it in my >>> local webrev repo - and played with the new >>> webrev in a couple of repositories where I have >>> pending uncommitted changes. >>> >>> This seems to work well. >>> >>> I have used: >>> >>> webrev -fN from top level repo >>> webrev -N from jdk repo >>> webrev -fN from jdk repo (with changes in test/closed) >>> >> >> Great that you tired it out. >> >>> I also had a cursory look at your patch. The only thing >>> I noticed is that 'typeset' is not consistently used in >>> the original webrev file. I'm not sure whether that's >>> intended or not. >>> I believe that's ok - but I've been bitten by not using >>> typeset before ;-( - maybe - for the sake of uniformity - >>> you could use typeset at least in those functions that >>> already use it for their parameters? For instance >>> lines 532-534, and possibly line 560 as well? >>> Or did you intentionally not used it? >> >> I also noticed the inconsistent use of typeset. I fixed the lines you >> pointed out. I wasn't sure which way to go. But I think your suggestion >> is good. >> >>> >>> Also you should increment the version of webrev. >>> IIRC that would be 25.6: >>> >>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >> >> Thanks, didn't think of that. >> >> New webrev: >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >> >> Diff compared to the first version: >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >> >> >> Thanks, >> Bengt >> >>> >>> best regards, >>> >>> -- daniel >>> >>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>> >>>> Hi everyone, >>>> >>>> (This is a patch for webrev, but I am cross posting to the JDK 9 dev >>>> list since I'm not sure how many are on the webrev-dev list and >>>> most JDK >>>> developers might have opinions about this change.) >>>> >>>> Can I get a couple of reviews for this small enhancement to the webrev >>>> tool? >>>> >>>> CODETOOLS-7901044: Add next/prev links to navigate between diffs >>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>> >>>> >>>> Background: >>>> When browsing review requests that span many files it is quite time >>>> consuming to have to go back to the index page to view to the next or >>>> previous file. This patch adds links to the next and previous files in >>>> the diff views (including frames). >>>> >>>> The above webrev is generated with this new version, but since it only >>>> contains a single file it is not that interesting. Here is an >>>> example of >>>> what the new webrev looks like for a larger change (the G1 class >>>> unloading change): >>>> >>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>> >>>> >>>> >>>> Thanks, >>>> Bengt >>>> >>> >> > From bengt.rutisson at oracle.com Thu Oct 2 06:38:31 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Thu, 02 Oct 2014 08:38:31 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <21548.35184.576946.43474@mykonos.us.oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> Message-ID: <542CF2E7.3010202@oracle.com> On 2014-10-02 01:08, John Coomes wrote: > Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >> Hi Daniel, >> >> On 10/1/14 4:27 PM, Daniel Fuchs wrote: >>> Hi Bengt, >>> >>> The new version looks good to me, but I am not a reviewer >>> fore CODE_TOOLS. >> Thanks for looking at this Daniel! >> >>> Hopefully someone who is will step in :-) >> Yes, and I am not a committer in code-tools so I need a sponsor for the >> patch too. > Looks good to me; I'll sponsor it. Send me (privately) the result of > "hg export --git" and I'll push that. Thanks for looking at this, John! And thanks for sponsoring the change. I'll send you the export in a separate email. Bengt > > -John > >>> best regards, >>> >>> -- daniel >>> >>> On 01/10/14 15:57, Bengt Rutisson wrote: >>>> Hi Daniel, >>>> >>>> Thanks for looking at this! >>>> >>>> On 2014-10-01 15:53, Daniel Fuchs wrote: >>>>> Hi Bengt, >>>>> >>>>> This is a really cool feature! >>>> Thanks! >>>> >>>>> I have downloaded your patch and applied it in my >>>>> local webrev repo - and played with the new >>>>> webrev in a couple of repositories where I have >>>>> pending uncommitted changes. >>>>> >>>>> This seems to work well. >>>>> >>>>> I have used: >>>>> >>>>> webrev -fN from top level repo >>>>> webrev -N from jdk repo >>>>> webrev -fN from jdk repo (with changes in test/closed) >>>>> >>>> Great that you tired it out. >>>> >>>>> I also had a cursory look at your patch. The only thing >>>>> I noticed is that 'typeset' is not consistently used in >>>>> the original webrev file. I'm not sure whether that's >>>>> intended or not. >>>>> I believe that's ok - but I've been bitten by not using >>>>> typeset before ;-( - maybe - for the sake of uniformity - >>>>> you could use typeset at least in those functions that >>>>> already use it for their parameters? For instance >>>>> lines 532-534, and possibly line 560 as well? >>>>> Or did you intentionally not used it? >>>> I also noticed the inconsistent use of typeset. I fixed the lines you >>>> pointed out. I wasn't sure which way to go. But I think your suggestion >>>> is good. >>>> >>>>> Also you should increment the version of webrev. >>>>> IIRC that would be 25.6: >>>>> >>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >>>> Thanks, didn't think of that. >>>> >>>> New webrev: >>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >>>> >>>> Diff compared to the first version: >>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >>>> >>>> >>>> Thanks, >>>> Bengt >>>> >>>>> best regards, >>>>> >>>>> -- daniel >>>>> >>>>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>>>> Hi everyone, >>>>>> >>>>>> (This is a patch for webrev, but I am cross posting to the JDK 9 dev >>>>>> list since I'm not sure how many are on the webrev-dev list and >>>>>> most JDK >>>>>> developers might have opinions about this change.) >>>>>> >>>>>> Can I get a couple of reviews for this small enhancement to the webrev >>>>>> tool? >>>>>> >>>>>> CODETOOLS-7901044: Add next/prev links to navigate between diffs >>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>>>> >>>>>> Webrev: >>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>>>> >>>>>> >>>>>> Background: >>>>>> When browsing review requests that span many files it is quite time >>>>>> consuming to have to go back to the index page to view to the next or >>>>>> previous file. This patch adds links to the next and previous files in >>>>>> the diff views (including frames). >>>>>> >>>>>> The above webrev is generated with this new version, but since it only >>>>>> contains a single file it is not that interesting. Here is an >>>>>> example of >>>>>> what the new webrev looks like for a larger change (the G1 class >>>>>> unloading change): >>>>>> >>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>>>> >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Bengt >>>>>> From bengt.rutisson at oracle.com Fri Oct 3 07:58:32 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Fri, 03 Oct 2014 09:58:32 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <21549.50683.903473.289915@mykonos.us.oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> <542CF2E7.3010202@oracle.com> <21549.50683.903473.289915@mykonos.us.oracle.com> Message-ID: <542E5728.8010709@oracle.com> On 2014-10-02 23:39, John Coomes wrote: > Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >> On 2014-10-02 01:08, John Coomes wrote: >>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>> Hi Daniel, >>>> >>>> On 10/1/14 4:27 PM, Daniel Fuchs wrote: >>>>> Hi Bengt, >>>>> >>>>> The new version looks good to me, but I am not a reviewer >>>>> fore CODE_TOOLS. >>>> Thanks for looking at this Daniel! >>>> >>>>> Hopefully someone who is will step in :-) >>>> Yes, and I am not a committer in code-tools so I need a sponsor for the >>>> patch too. >>> Looks good to me; I'll sponsor it. Send me (privately) the result of >>> "hg export --git" and I'll push that. >> Thanks for looking at this, John! And thanks for sponsoring the change. >> I'll send you the export in a separate email. > Got it; it's been pushed. Thanks for pushing this, John! Bengt > > -John > >>>>> best regards, >>>>> >>>>> -- daniel >>>>> >>>>> On 01/10/14 15:57, Bengt Rutisson wrote: >>>>>> Hi Daniel, >>>>>> >>>>>> Thanks for looking at this! >>>>>> >>>>>> On 2014-10-01 15:53, Daniel Fuchs wrote: >>>>>>> Hi Bengt, >>>>>>> >>>>>>> This is a really cool feature! >>>>>> Thanks! >>>>>> >>>>>>> I have downloaded your patch and applied it in my >>>>>>> local webrev repo - and played with the new >>>>>>> webrev in a couple of repositories where I have >>>>>>> pending uncommitted changes. >>>>>>> >>>>>>> This seems to work well. >>>>>>> >>>>>>> I have used: >>>>>>> >>>>>>> webrev -fN from top level repo >>>>>>> webrev -N from jdk repo >>>>>>> webrev -fN from jdk repo (with changes in test/closed) >>>>>>> >>>>>> Great that you tired it out. >>>>>> >>>>>>> I also had a cursory look at your patch. The only thing >>>>>>> I noticed is that 'typeset' is not consistently used in >>>>>>> the original webrev file. I'm not sure whether that's >>>>>>> intended or not. >>>>>>> I believe that's ok - but I've been bitten by not using >>>>>>> typeset before ;-( - maybe - for the sake of uniformity - >>>>>>> you could use typeset at least in those functions that >>>>>>> already use it for their parameters? For instance >>>>>>> lines 532-534, and possibly line 560 as well? >>>>>>> Or did you intentionally not used it? >>>>>> I also noticed the inconsistent use of typeset. I fixed the lines you >>>>>> pointed out. I wasn't sure which way to go. But I think your suggestion >>>>>> is good. >>>>>> >>>>>>> Also you should increment the version of webrev. >>>>>>> IIRC that would be 25.6: >>>>>>> >>>>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>>>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >>>>>> Thanks, didn't think of that. >>>>>> >>>>>> New webrev: >>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >>>>>> >>>>>> Diff compared to the first version: >>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Bengt >>>>>> >>>>>>> best regards, >>>>>>> >>>>>>> -- daniel >>>>>>> >>>>>>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>>>>>> Hi everyone, >>>>>>>> >>>>>>>> (This is a patch for webrev, but I am cross posting to the JDK 9 dev >>>>>>>> list since I'm not sure how many are on the webrev-dev list and >>>>>>>> most JDK >>>>>>>> developers might have opinions about this change.) >>>>>>>> >>>>>>>> Can I get a couple of reviews for this small enhancement to the webrev >>>>>>>> tool? >>>>>>>> >>>>>>>> CODETOOLS-7901044: Add next/prev links to navigate between diffs >>>>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>>>>>> >>>>>>>> Webrev: >>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>>>>>> >>>>>>>> >>>>>>>> Background: >>>>>>>> When browsing review requests that span many files it is quite time >>>>>>>> consuming to have to go back to the index page to view to the next or >>>>>>>> previous file. This patch adds links to the next and previous files in >>>>>>>> the diff views (including frames). >>>>>>>> >>>>>>>> The above webrev is generated with this new version, but since it only >>>>>>>> contains a single file it is not that interesting. Here is an >>>>>>>> example of >>>>>>>> what the new webrev looks like for a larger change (the G1 class >>>>>>>> unloading change): >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Bengt >>>>>>>> From david.r.chase at oracle.com Wed Oct 1 13:59:54 2014 From: david.r.chase at oracle.com (David Chase) Date: Wed, 1 Oct 2014 09:59:54 -0400 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <542BC1C9.9000204@oracle.com> References: <542BC1C9.9000204@oracle.com> Message-ID: I thought we had that in what I know of as ?webrev-new?, see for example: http://cr.openjdk.java.net/~drchase/8037816/webrev-9.05-09b/src/cpu/x86/vm/c1_LinearScan_x86.cpp.sdiff.html But yours is also nice :-). David On 2014-10-01, at 4:56 AM, Bengt Rutisson wrote: > > Hi everyone, > > (This is a patch for webrev, but I am cross posting to the JDK 9 dev list since I'm not sure how many are on the webrev-dev list and most JDK developers might have opinions about this change.) > > Can I get a couple of reviews for this small enhancement to the webrev tool? > > CODETOOLS-7901044: Add next/prev links to navigate between diffs > https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 > > Webrev: > http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ > > > Background: > When browsing review requests that span many files it is quite time consuming to have to go back to the index page to view to the next or previous file. This patch adds links to the next and previous files in the diff views (including frames). > > The above webrev is generated with this new version, but since it only contains a single file it is not that interesting. Here is an example of what the new webrev looks like for a larger change (the G1 class unloading change): > > http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ > > Thanks, > Bengt > From John.Coomes at oracle.com Wed Oct 1 23:08:32 2014 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 1 Oct 2014 16:08:32 -0700 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <542C6DF1.1060409@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> Message-ID: <21548.35184.576946.43474@mykonos.us.oracle.com> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: > > Hi Daniel, > > On 10/1/14 4:27 PM, Daniel Fuchs wrote: > > Hi Bengt, > > > > The new version looks good to me, but I am not a reviewer > > fore CODE_TOOLS. > > Thanks for looking at this Daniel! > > > Hopefully someone who is will step in :-) > > Yes, and I am not a committer in code-tools so I need a sponsor for the > patch too. Looks good to me; I'll sponsor it. Send me (privately) the result of "hg export --git" and I'll push that. -John > > best regards, > > > > -- daniel > > > > On 01/10/14 15:57, Bengt Rutisson wrote: > >> > >> Hi Daniel, > >> > >> Thanks for looking at this! > >> > >> On 2014-10-01 15:53, Daniel Fuchs wrote: > >>> Hi Bengt, > >>> > >>> This is a really cool feature! > >> > >> Thanks! > >> > >>> > >>> I have downloaded your patch and applied it in my > >>> local webrev repo - and played with the new > >>> webrev in a couple of repositories where I have > >>> pending uncommitted changes. > >>> > >>> This seems to work well. > >>> > >>> I have used: > >>> > >>> webrev -fN from top level repo > >>> webrev -N from jdk repo > >>> webrev -fN from jdk repo (with changes in test/closed) > >>> > >> > >> Great that you tired it out. > >> > >>> I also had a cursory look at your patch. The only thing > >>> I noticed is that 'typeset' is not consistently used in > >>> the original webrev file. I'm not sure whether that's > >>> intended or not. > >>> I believe that's ok - but I've been bitten by not using > >>> typeset before ;-( - maybe - for the sake of uniformity - > >>> you could use typeset at least in those functions that > >>> already use it for their parameters? For instance > >>> lines 532-534, and possibly line 560 as well? > >>> Or did you intentionally not used it? > >> > >> I also noticed the inconsistent use of typeset. I fixed the lines you > >> pointed out. I wasn't sure which way to go. But I think your suggestion > >> is good. > >> > >>> > >>> Also you should increment the version of webrev. > >>> IIRC that would be 25.6: > >>> > >>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net > >>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net > >> > >> Thanks, didn't think of that. > >> > >> New webrev: > >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ > >> > >> Diff compared to the first version: > >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ > >> > >> > >> Thanks, > >> Bengt > >> > >>> > >>> best regards, > >>> > >>> -- daniel > >>> > >>> On 01/10/14 10:56, Bengt Rutisson wrote: > >>>> > >>>> Hi everyone, > >>>> > >>>> (This is a patch for webrev, but I am cross posting to the JDK 9 dev > >>>> list since I'm not sure how many are on the webrev-dev list and > >>>> most JDK > >>>> developers might have opinions about this change.) > >>>> > >>>> Can I get a couple of reviews for this small enhancement to the webrev > >>>> tool? > >>>> > >>>> CODETOOLS-7901044: Add next/prev links to navigate between diffs > >>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 > >>>> > >>>> Webrev: > >>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ > >>>> > >>>> > >>>> Background: > >>>> When browsing review requests that span many files it is quite time > >>>> consuming to have to go back to the index page to view to the next or > >>>> previous file. This patch adds links to the next and previous files in > >>>> the diff views (including frames). > >>>> > >>>> The above webrev is generated with this new version, but since it only > >>>> contains a single file it is not that interesting. Here is an > >>>> example of > >>>> what the new webrev looks like for a larger change (the G1 class > >>>> unloading change): > >>>> > >>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ > >>>> > >>>> > >>>> > >>>> Thanks, > >>>> Bengt > >>>> > >>> > >> > > > From john.coomes at oracle.com Thu Oct 2 21:37:01 2014 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 02 Oct 2014 21:37:01 +0000 Subject: hg: code-tools/webrev: 7901044: Add next/prev links to navigate between diffs Message-ID: <201410022137.s92Lb1VJ003304@aojmv0008> Changeset: 66c93fc5184e Author: brutisso Date: 2014-10-02 08:24 +0200 URL: http://hg.openjdk.java.net/code-tools/webrev/rev/66c93fc5184e 7901044: Add next/prev links to navigate between diffs Reviewed-by: jcoomes, dfuchs ! webrev.ksh From John.Coomes at oracle.com Thu Oct 2 21:39:07 2014 From: John.Coomes at oracle.com (John Coomes) Date: Thu, 2 Oct 2014 14:39:07 -0700 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <542CF2E7.3010202@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> <542CF2E7.3010202@oracle.com> Message-ID: <21549.50683.903473.289915@mykonos.us.oracle.com> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: > > On 2014-10-02 01:08, John Coomes wrote: > > Bengt Rutisson (bengt.rutisson at oracle.com) wrote: > >> Hi Daniel, > >> > >> On 10/1/14 4:27 PM, Daniel Fuchs wrote: > >>> Hi Bengt, > >>> > >>> The new version looks good to me, but I am not a reviewer > >>> fore CODE_TOOLS. > >> Thanks for looking at this Daniel! > >> > >>> Hopefully someone who is will step in :-) > >> Yes, and I am not a committer in code-tools so I need a sponsor for the > >> patch too. > > Looks good to me; I'll sponsor it. Send me (privately) the result of > > "hg export --git" and I'll push that. > > Thanks for looking at this, John! And thanks for sponsoring the change. > I'll send you the export in a separate email. Got it; it's been pushed. -John > >>> best regards, > >>> > >>> -- daniel > >>> > >>> On 01/10/14 15:57, Bengt Rutisson wrote: > >>>> Hi Daniel, > >>>> > >>>> Thanks for looking at this! > >>>> > >>>> On 2014-10-01 15:53, Daniel Fuchs wrote: > >>>>> Hi Bengt, > >>>>> > >>>>> This is a really cool feature! > >>>> Thanks! > >>>> > >>>>> I have downloaded your patch and applied it in my > >>>>> local webrev repo - and played with the new > >>>>> webrev in a couple of repositories where I have > >>>>> pending uncommitted changes. > >>>>> > >>>>> This seems to work well. > >>>>> > >>>>> I have used: > >>>>> > >>>>> webrev -fN from top level repo > >>>>> webrev -N from jdk repo > >>>>> webrev -fN from jdk repo (with changes in test/closed) > >>>>> > >>>> Great that you tired it out. > >>>> > >>>>> I also had a cursory look at your patch. The only thing > >>>>> I noticed is that 'typeset' is not consistently used in > >>>>> the original webrev file. I'm not sure whether that's > >>>>> intended or not. > >>>>> I believe that's ok - but I've been bitten by not using > >>>>> typeset before ;-( - maybe - for the sake of uniformity - > >>>>> you could use typeset at least in those functions that > >>>>> already use it for their parameters? For instance > >>>>> lines 532-534, and possibly line 560 as well? > >>>>> Or did you intentionally not used it? > >>>> I also noticed the inconsistent use of typeset. I fixed the lines you > >>>> pointed out. I wasn't sure which way to go. But I think your suggestion > >>>> is good. > >>>> > >>>>> Also you should increment the version of webrev. > >>>>> IIRC that would be 25.6: > >>>>> > >>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net > >>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net > >>>> Thanks, didn't think of that. > >>>> > >>>> New webrev: > >>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ > >>>> > >>>> Diff compared to the first version: > >>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ > >>>> > >>>> > >>>> Thanks, > >>>> Bengt > >>>> > >>>>> best regards, > >>>>> > >>>>> -- daniel > >>>>> > >>>>> On 01/10/14 10:56, Bengt Rutisson wrote: > >>>>>> Hi everyone, > >>>>>> > >>>>>> (This is a patch for webrev, but I am cross posting to the JDK 9 dev > >>>>>> list since I'm not sure how many are on the webrev-dev list and > >>>>>> most JDK > >>>>>> developers might have opinions about this change.) > >>>>>> > >>>>>> Can I get a couple of reviews for this small enhancement to the webrev > >>>>>> tool? > >>>>>> > >>>>>> CODETOOLS-7901044: Add next/prev links to navigate between diffs > >>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 > >>>>>> > >>>>>> Webrev: > >>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ > >>>>>> > >>>>>> > >>>>>> Background: > >>>>>> When browsing review requests that span many files it is quite time > >>>>>> consuming to have to go back to the index page to view to the next or > >>>>>> previous file. This patch adds links to the next and previous files in > >>>>>> the diff views (including frames). > >>>>>> > >>>>>> The above webrev is generated with this new version, but since it only > >>>>>> contains a single file it is not that interesting. Here is an > >>>>>> example of > >>>>>> what the new webrev looks like for a larger change (the G1 class > >>>>>> unloading change): > >>>>>> > >>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ > >>>>>> > >>>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> Bengt > >>>>>> > From jonathan.gibbons at oracle.com Mon Oct 13 22:20:33 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 13 Oct 2014 15:20:33 -0700 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <542E5728.8010709@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> <542CF2E7.3010202@oracle.com> <21549.50683.903473.289915@mykonos.us.oracle.com> <542E5728.8010709@oracle.com> Message-ID: <543C5031.2020000@oracle.com> Bengt, There may be problems with the latest version of webrev. Eric McCorkle is reporting syntax errors from his version of ksh. patch cdiffs udiffs sdiffs frames old new src/jdk.javadoc/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ../../tl/make/scripts/webrev.ksh[2241]: build_old_new[1714]: build_old_new_mercurial[1666]: [: : arithmetic syntax error -- Jon On 10/03/2014 12:58 AM, Bengt Rutisson wrote: > > On 2014-10-02 23:39, John Coomes wrote: >> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>> On 2014-10-02 01:08, John Coomes wrote: >>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>> Hi Daniel, >>>>> >>>>> On 10/1/14 4:27 PM, Daniel Fuchs wrote: >>>>>> Hi Bengt, >>>>>> >>>>>> The new version looks good to me, but I am not a reviewer >>>>>> fore CODE_TOOLS. >>>>> Thanks for looking at this Daniel! >>>>> >>>>>> Hopefully someone who is will step in :-) >>>>> Yes, and I am not a committer in code-tools so I need a sponsor >>>>> for the >>>>> patch too. >>>> Looks good to me; I'll sponsor it. Send me (privately) the result of >>>> "hg export --git" and I'll push that. >>> Thanks for looking at this, John! And thanks for sponsoring the change. >>> I'll send you the export in a separate email. >> Got it; it's been pushed. > > Thanks for pushing this, John! > > Bengt > >> >> -John >> >>>>>> best regards, >>>>>> >>>>>> -- daniel >>>>>> >>>>>> On 01/10/14 15:57, Bengt Rutisson wrote: >>>>>>> Hi Daniel, >>>>>>> >>>>>>> Thanks for looking at this! >>>>>>> >>>>>>> On 2014-10-01 15:53, Daniel Fuchs wrote: >>>>>>>> Hi Bengt, >>>>>>>> >>>>>>>> This is a really cool feature! >>>>>>> Thanks! >>>>>>> >>>>>>>> I have downloaded your patch and applied it in my >>>>>>>> local webrev repo - and played with the new >>>>>>>> webrev in a couple of repositories where I have >>>>>>>> pending uncommitted changes. >>>>>>>> >>>>>>>> This seems to work well. >>>>>>>> >>>>>>>> I have used: >>>>>>>> >>>>>>>> webrev -fN from top level repo >>>>>>>> webrev -N from jdk repo >>>>>>>> webrev -fN from jdk repo (with changes in test/closed) >>>>>>>> >>>>>>> Great that you tired it out. >>>>>>> >>>>>>>> I also had a cursory look at your patch. The only thing >>>>>>>> I noticed is that 'typeset' is not consistently used in >>>>>>>> the original webrev file. I'm not sure whether that's >>>>>>>> intended or not. >>>>>>>> I believe that's ok - but I've been bitten by not using >>>>>>>> typeset before ;-( - maybe - for the sake of uniformity - >>>>>>>> you could use typeset at least in those functions that >>>>>>>> already use it for their parameters? For instance >>>>>>>> lines 532-534, and possibly line 560 as well? >>>>>>>> Or did you intentionally not used it? >>>>>>> I also noticed the inconsistent use of typeset. I fixed the >>>>>>> lines you >>>>>>> pointed out. I wasn't sure which way to go. But I think your >>>>>>> suggestion >>>>>>> is good. >>>>>>> >>>>>>>> Also you should increment the version of webrev. >>>>>>>> IIRC that would be 25.6: >>>>>>>> >>>>>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>>>>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >>>>>>> Thanks, didn't think of that. >>>>>>> >>>>>>> New webrev: >>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >>>>>>> >>>>>>> Diff compared to the first version: >>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >>>>>>> >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Bengt >>>>>>> >>>>>>>> best regards, >>>>>>>> >>>>>>>> -- daniel >>>>>>>> >>>>>>>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>>>>>>> Hi everyone, >>>>>>>>> >>>>>>>>> (This is a patch for webrev, but I am cross posting to the JDK >>>>>>>>> 9 dev >>>>>>>>> list since I'm not sure how many are on the webrev-dev list and >>>>>>>>> most JDK >>>>>>>>> developers might have opinions about this change.) >>>>>>>>> >>>>>>>>> Can I get a couple of reviews for this small enhancement to >>>>>>>>> the webrev >>>>>>>>> tool? >>>>>>>>> >>>>>>>>> CODETOOLS-7901044: Add next/prev links to navigate between diffs >>>>>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>>>>>>> >>>>>>>>> Webrev: >>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>>>>>>> >>>>>>>>> >>>>>>>>> Background: >>>>>>>>> When browsing review requests that span many files it is quite >>>>>>>>> time >>>>>>>>> consuming to have to go back to the index page to view to the >>>>>>>>> next or >>>>>>>>> previous file. This patch adds links to the next and previous >>>>>>>>> files in >>>>>>>>> the diff views (including frames). >>>>>>>>> >>>>>>>>> The above webrev is generated with this new version, but since >>>>>>>>> it only >>>>>>>>> contains a single file it is not that interesting. Here is an >>>>>>>>> example of >>>>>>>>> what the new webrev looks like for a larger change (the G1 class >>>>>>>>> unloading change): >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Bengt >>>>>>>>> > From daniel.fuchs at oracle.com Tue Oct 14 09:05:25 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 14 Oct 2014 11:05:25 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <543C5031.2020000@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> <542CF2E7.3010202@oracle.com> <21549.50683.903473.289915@mykonos.us.oracle.com> <542E5728.8010709@oracle.com> <543C5031.2020000@oracle.com> Message-ID: <543CE755.6060900@oracle.com> On 14/10/14 00:20, Jonathan Gibbons wrote: > Bengt, > > There may be problems with the latest version of webrev. > > Eric McCorkle is reporting syntax errors from his version of ksh. > > patch cdiffs udiffs sdiffs frames old new > src/jdk.javadoc/share/classes/com/sun/tools/javadoc/SeeTagImpl.java > ../../tl/make/scripts/webrev.ksh[2241]: > build_old_new[1714]: build_old_new_mercurial[1666]: [: : arithmetic > syntax error Hi Jon, These line numbers do not seem to correspond to the latest version of webrev.ksh. line 2241 is a comment line 1714 is ' if [ -f $F ]; then' in build_old_new_mercurial (an not in build_old_new) line 1666 is ' fi' in look_for_prog (an not build_old_new_mercurial) Could you maybe check that we're speaking of the same version of webrev.ksh? best regards, -- daniel > > -- Jon > > On 10/03/2014 12:58 AM, Bengt Rutisson wrote: >> >> On 2014-10-02 23:39, John Coomes wrote: >>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>> On 2014-10-02 01:08, John Coomes wrote: >>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>> Hi Daniel, >>>>>> >>>>>> On 10/1/14 4:27 PM, Daniel Fuchs wrote: >>>>>>> Hi Bengt, >>>>>>> >>>>>>> The new version looks good to me, but I am not a reviewer >>>>>>> fore CODE_TOOLS. >>>>>> Thanks for looking at this Daniel! >>>>>> >>>>>>> Hopefully someone who is will step in :-) >>>>>> Yes, and I am not a committer in code-tools so I need a sponsor >>>>>> for the >>>>>> patch too. >>>>> Looks good to me; I'll sponsor it. Send me (privately) the result of >>>>> "hg export --git" and I'll push that. >>>> Thanks for looking at this, John! And thanks for sponsoring the change. >>>> I'll send you the export in a separate email. >>> Got it; it's been pushed. >> >> Thanks for pushing this, John! >> >> Bengt >> >>> >>> -John >>> >>>>>>> best regards, >>>>>>> >>>>>>> -- daniel >>>>>>> >>>>>>> On 01/10/14 15:57, Bengt Rutisson wrote: >>>>>>>> Hi Daniel, >>>>>>>> >>>>>>>> Thanks for looking at this! >>>>>>>> >>>>>>>> On 2014-10-01 15:53, Daniel Fuchs wrote: >>>>>>>>> Hi Bengt, >>>>>>>>> >>>>>>>>> This is a really cool feature! >>>>>>>> Thanks! >>>>>>>> >>>>>>>>> I have downloaded your patch and applied it in my >>>>>>>>> local webrev repo - and played with the new >>>>>>>>> webrev in a couple of repositories where I have >>>>>>>>> pending uncommitted changes. >>>>>>>>> >>>>>>>>> This seems to work well. >>>>>>>>> >>>>>>>>> I have used: >>>>>>>>> >>>>>>>>> webrev -fN from top level repo >>>>>>>>> webrev -N from jdk repo >>>>>>>>> webrev -fN from jdk repo (with changes in test/closed) >>>>>>>>> >>>>>>>> Great that you tired it out. >>>>>>>> >>>>>>>>> I also had a cursory look at your patch. The only thing >>>>>>>>> I noticed is that 'typeset' is not consistently used in >>>>>>>>> the original webrev file. I'm not sure whether that's >>>>>>>>> intended or not. >>>>>>>>> I believe that's ok - but I've been bitten by not using >>>>>>>>> typeset before ;-( - maybe - for the sake of uniformity - >>>>>>>>> you could use typeset at least in those functions that >>>>>>>>> already use it for their parameters? For instance >>>>>>>>> lines 532-534, and possibly line 560 as well? >>>>>>>>> Or did you intentionally not used it? >>>>>>>> I also noticed the inconsistent use of typeset. I fixed the >>>>>>>> lines you >>>>>>>> pointed out. I wasn't sure which way to go. But I think your >>>>>>>> suggestion >>>>>>>> is good. >>>>>>>> >>>>>>>>> Also you should increment the version of webrev. >>>>>>>>> IIRC that would be 25.6: >>>>>>>>> >>>>>>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>>>>>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >>>>>>>> Thanks, didn't think of that. >>>>>>>> >>>>>>>> New webrev: >>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >>>>>>>> >>>>>>>> Diff compared to the first version: >>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Bengt >>>>>>>> >>>>>>>>> best regards, >>>>>>>>> >>>>>>>>> -- daniel >>>>>>>>> >>>>>>>>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>>>>>>>> Hi everyone, >>>>>>>>>> >>>>>>>>>> (This is a patch for webrev, but I am cross posting to the JDK >>>>>>>>>> 9 dev >>>>>>>>>> list since I'm not sure how many are on the webrev-dev list and >>>>>>>>>> most JDK >>>>>>>>>> developers might have opinions about this change.) >>>>>>>>>> >>>>>>>>>> Can I get a couple of reviews for this small enhancement to >>>>>>>>>> the webrev >>>>>>>>>> tool? >>>>>>>>>> >>>>>>>>>> CODETOOLS-7901044: Add next/prev links to navigate between diffs >>>>>>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>>>>>>>> >>>>>>>>>> Webrev: >>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Background: >>>>>>>>>> When browsing review requests that span many files it is quite >>>>>>>>>> time >>>>>>>>>> consuming to have to go back to the index page to view to the >>>>>>>>>> next or >>>>>>>>>> previous file. This patch adds links to the next and previous >>>>>>>>>> files in >>>>>>>>>> the diff views (including frames). >>>>>>>>>> >>>>>>>>>> The above webrev is generated with this new version, but since >>>>>>>>>> it only >>>>>>>>>> contains a single file it is not that interesting. Here is an >>>>>>>>>> example of >>>>>>>>>> what the new webrev looks like for a larger change (the G1 class >>>>>>>>>> unloading change): >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Bengt >>>>>>>>>> >> > From bengt.rutisson at oracle.com Tue Oct 14 18:47:31 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Tue, 14 Oct 2014 20:47:31 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <543CE755.6060900@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> <542CF2E7.3010202@oracle.com> <21549.50683.903473.289915@mykonos.us.oracle.com> <542E5728.8010709@oracle.com> <543C5031.2020000@oracle.com> <543CE755.6060900@oracle.com> Message-ID: <543D6FC3.7020604@oracle.com> On 10/14/14 11:05 AM, Daniel Fuchs wrote: > On 14/10/14 00:20, Jonathan Gibbons wrote: >> Bengt, >> >> There may be problems with the latest version of webrev. >> >> Eric McCorkle is reporting syntax errors from his version of ksh. >> >> patch cdiffs udiffs sdiffs frames old new >> src/jdk.javadoc/share/classes/com/sun/tools/javadoc/SeeTagImpl.java >> ../../tl/make/scripts/webrev.ksh[2241]: >> build_old_new[1714]: build_old_new_mercurial[1666]: [: : arithmetic >> syntax error > > Hi Jon, > > These line numbers do not seem to correspond to the latest version > of webrev.ksh. > > line 2241 is a comment > line 1714 is ' if [ -f $F ]; then' in build_old_new_mercurial > (an not in build_old_new) > line 1666 is ' fi' in look_for_prog > (an not build_old_new_mercurial) > > Could you maybe check that we're speaking of the same version of > webrev.ksh? Daniel, Thanks for pointing this out. It also does not seem to be the lines that I changed. Jon, I'm running the webrev script with ksh and it seems to work fine. Do you know which version ksh and which platform Eric is using? Thanks, Bengt > > best regards, > > -- daniel > > > > >> >> -- Jon >> >> On 10/03/2014 12:58 AM, Bengt Rutisson wrote: >>> >>> On 2014-10-02 23:39, John Coomes wrote: >>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>> On 2014-10-02 01:08, John Coomes wrote: >>>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>>> Hi Daniel, >>>>>>> >>>>>>> On 10/1/14 4:27 PM, Daniel Fuchs wrote: >>>>>>>> Hi Bengt, >>>>>>>> >>>>>>>> The new version looks good to me, but I am not a reviewer >>>>>>>> fore CODE_TOOLS. >>>>>>> Thanks for looking at this Daniel! >>>>>>> >>>>>>>> Hopefully someone who is will step in :-) >>>>>>> Yes, and I am not a committer in code-tools so I need a sponsor >>>>>>> for the >>>>>>> patch too. >>>>>> Looks good to me; I'll sponsor it. Send me (privately) the >>>>>> result of >>>>>> "hg export --git" and I'll push that. >>>>> Thanks for looking at this, John! And thanks for sponsoring the >>>>> change. >>>>> I'll send you the export in a separate email. >>>> Got it; it's been pushed. >>> >>> Thanks for pushing this, John! >>> >>> Bengt >>> >>>> >>>> -John >>>> >>>>>>>> best regards, >>>>>>>> >>>>>>>> -- daniel >>>>>>>> >>>>>>>> On 01/10/14 15:57, Bengt Rutisson wrote: >>>>>>>>> Hi Daniel, >>>>>>>>> >>>>>>>>> Thanks for looking at this! >>>>>>>>> >>>>>>>>> On 2014-10-01 15:53, Daniel Fuchs wrote: >>>>>>>>>> Hi Bengt, >>>>>>>>>> >>>>>>>>>> This is a really cool feature! >>>>>>>>> Thanks! >>>>>>>>> >>>>>>>>>> I have downloaded your patch and applied it in my >>>>>>>>>> local webrev repo - and played with the new >>>>>>>>>> webrev in a couple of repositories where I have >>>>>>>>>> pending uncommitted changes. >>>>>>>>>> >>>>>>>>>> This seems to work well. >>>>>>>>>> >>>>>>>>>> I have used: >>>>>>>>>> >>>>>>>>>> webrev -fN from top level repo >>>>>>>>>> webrev -N from jdk repo >>>>>>>>>> webrev -fN from jdk repo (with changes in test/closed) >>>>>>>>>> >>>>>>>>> Great that you tired it out. >>>>>>>>> >>>>>>>>>> I also had a cursory look at your patch. The only thing >>>>>>>>>> I noticed is that 'typeset' is not consistently used in >>>>>>>>>> the original webrev file. I'm not sure whether that's >>>>>>>>>> intended or not. >>>>>>>>>> I believe that's ok - but I've been bitten by not using >>>>>>>>>> typeset before ;-( - maybe - for the sake of uniformity - >>>>>>>>>> you could use typeset at least in those functions that >>>>>>>>>> already use it for their parameters? For instance >>>>>>>>>> lines 532-534, and possibly line 560 as well? >>>>>>>>>> Or did you intentionally not used it? >>>>>>>>> I also noticed the inconsistent use of typeset. I fixed the >>>>>>>>> lines you >>>>>>>>> pointed out. I wasn't sure which way to go. But I think your >>>>>>>>> suggestion >>>>>>>>> is good. >>>>>>>>> >>>>>>>>>> Also you should increment the version of webrev. >>>>>>>>>> IIRC that would be 25.6: >>>>>>>>>> >>>>>>>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>>>>>>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >>>>>>>>> Thanks, didn't think of that. >>>>>>>>> >>>>>>>>> New webrev: >>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >>>>>>>>> >>>>>>>>> Diff compared to the first version: >>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Bengt >>>>>>>>> >>>>>>>>>> best regards, >>>>>>>>>> >>>>>>>>>> -- daniel >>>>>>>>>> >>>>>>>>>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>>>>>>>>> Hi everyone, >>>>>>>>>>> >>>>>>>>>>> (This is a patch for webrev, but I am cross posting to the JDK >>>>>>>>>>> 9 dev >>>>>>>>>>> list since I'm not sure how many are on the webrev-dev list and >>>>>>>>>>> most JDK >>>>>>>>>>> developers might have opinions about this change.) >>>>>>>>>>> >>>>>>>>>>> Can I get a couple of reviews for this small enhancement to >>>>>>>>>>> the webrev >>>>>>>>>>> tool? >>>>>>>>>>> >>>>>>>>>>> CODETOOLS-7901044: Add next/prev links to navigate between >>>>>>>>>>> diffs >>>>>>>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>>>>>>>>> >>>>>>>>>>> Webrev: >>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Background: >>>>>>>>>>> When browsing review requests that span many files it is quite >>>>>>>>>>> time >>>>>>>>>>> consuming to have to go back to the index page to view to the >>>>>>>>>>> next or >>>>>>>>>>> previous file. This patch adds links to the next and previous >>>>>>>>>>> files in >>>>>>>>>>> the diff views (including frames). >>>>>>>>>>> >>>>>>>>>>> The above webrev is generated with this new version, but since >>>>>>>>>>> it only >>>>>>>>>>> contains a single file it is not that interesting. Here is an >>>>>>>>>>> example of >>>>>>>>>>> what the new webrev looks like for a larger change (the G1 >>>>>>>>>>> class >>>>>>>>>>> unloading change): >>>>>>>>>>> >>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Bengt >>>>>>>>>>> >>> >> > From jonathan.gibbons at oracle.com Tue Oct 14 19:12:52 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 14 Oct 2014 12:12:52 -0700 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <543D6FC3.7020604@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> <542CF2E7.3010202@oracle.com> <21549.50683.903473.289915@mykonos.us.oracle.com> <542E5728.8010709@oracle.com> <543C5031.2020000@oracle.com> <543CE755.6060900@oracle.com> <543D6FC3.7020604@oracle.com> Message-ID: <543D75B4.8060708@oracle.com> Eric, Can you provide info on the OS and version of ksh you are using that caused the problems you experienced with webrev? -- Jon On 10/14/2014 11:47 AM, Bengt Rutisson wrote: > On 10/14/14 11:05 AM, Daniel Fuchs wrote: >> On 14/10/14 00:20, Jonathan Gibbons wrote: >>> Bengt, >>> >>> There may be problems with the latest version of webrev. >>> >>> Eric McCorkle is reporting syntax errors from his version of ksh. >>> >>> patch cdiffs udiffs sdiffs frames old new >>> src/jdk.javadoc/share/classes/com/sun/tools/javadoc/SeeTagImpl.java >>> ../../tl/make/scripts/webrev.ksh[2241]: >>> build_old_new[1714]: build_old_new_mercurial[1666]: [: : arithmetic >>> syntax error >> >> Hi Jon, >> >> These line numbers do not seem to correspond to the latest version >> of webrev.ksh. >> >> line 2241 is a comment >> line 1714 is ' if [ -f $F ]; then' in build_old_new_mercurial >> (an not in build_old_new) >> line 1666 is ' fi' in look_for_prog >> (an not build_old_new_mercurial) >> >> Could you maybe check that we're speaking of the same version of >> webrev.ksh? > > Daniel, Thanks for pointing this out. > > It also does not seem to be the lines that I changed. > > Jon, I'm running the webrev script with ksh and it seems to work > fine. Do you know which version ksh and which platform Eric is using? > > Thanks, > Bengt > > >> >> best regards, >> >> -- daniel >> >> >> >> >>> >>> -- Jon >>> >>> On 10/03/2014 12:58 AM, Bengt Rutisson wrote: >>>> >>>> On 2014-10-02 23:39, John Coomes wrote: >>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>> On 2014-10-02 01:08, John Coomes wrote: >>>>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>>>> Hi Daniel, >>>>>>>> >>>>>>>> On 10/1/14 4:27 PM, Daniel Fuchs wrote: >>>>>>>>> Hi Bengt, >>>>>>>>> >>>>>>>>> The new version looks good to me, but I am not a reviewer >>>>>>>>> fore CODE_TOOLS. >>>>>>>> Thanks for looking at this Daniel! >>>>>>>> >>>>>>>>> Hopefully someone who is will step in :-) >>>>>>>> Yes, and I am not a committer in code-tools so I need a sponsor >>>>>>>> for the >>>>>>>> patch too. >>>>>>> Looks good to me; I'll sponsor it. Send me (privately) the >>>>>>> result of >>>>>>> "hg export --git" and I'll push that. >>>>>> Thanks for looking at this, John! And thanks for sponsoring the >>>>>> change. >>>>>> I'll send you the export in a separate email. >>>>> Got it; it's been pushed. >>>> >>>> Thanks for pushing this, John! >>>> >>>> Bengt >>>> >>>>> >>>>> -John >>>>> >>>>>>>>> best regards, >>>>>>>>> >>>>>>>>> -- daniel >>>>>>>>> >>>>>>>>> On 01/10/14 15:57, Bengt Rutisson wrote: >>>>>>>>>> Hi Daniel, >>>>>>>>>> >>>>>>>>>> Thanks for looking at this! >>>>>>>>>> >>>>>>>>>> On 2014-10-01 15:53, Daniel Fuchs wrote: >>>>>>>>>>> Hi Bengt, >>>>>>>>>>> >>>>>>>>>>> This is a really cool feature! >>>>>>>>>> Thanks! >>>>>>>>>> >>>>>>>>>>> I have downloaded your patch and applied it in my >>>>>>>>>>> local webrev repo - and played with the new >>>>>>>>>>> webrev in a couple of repositories where I have >>>>>>>>>>> pending uncommitted changes. >>>>>>>>>>> >>>>>>>>>>> This seems to work well. >>>>>>>>>>> >>>>>>>>>>> I have used: >>>>>>>>>>> >>>>>>>>>>> webrev -fN from top level repo >>>>>>>>>>> webrev -N from jdk repo >>>>>>>>>>> webrev -fN from jdk repo (with changes in test/closed) >>>>>>>>>>> >>>>>>>>>> Great that you tired it out. >>>>>>>>>> >>>>>>>>>>> I also had a cursory look at your patch. The only thing >>>>>>>>>>> I noticed is that 'typeset' is not consistently used in >>>>>>>>>>> the original webrev file. I'm not sure whether that's >>>>>>>>>>> intended or not. >>>>>>>>>>> I believe that's ok - but I've been bitten by not using >>>>>>>>>>> typeset before ;-( - maybe - for the sake of uniformity - >>>>>>>>>>> you could use typeset at least in those functions that >>>>>>>>>>> already use it for their parameters? For instance >>>>>>>>>>> lines 532-534, and possibly line 560 as well? >>>>>>>>>>> Or did you intentionally not used it? >>>>>>>>>> I also noticed the inconsistent use of typeset. I fixed the >>>>>>>>>> lines you >>>>>>>>>> pointed out. I wasn't sure which way to go. But I think your >>>>>>>>>> suggestion >>>>>>>>>> is good. >>>>>>>>>> >>>>>>>>>>> Also you should increment the version of webrev. >>>>>>>>>>> IIRC that would be 25.6: >>>>>>>>>>> >>>>>>>>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>>>>>>>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >>>>>>>>>> Thanks, didn't think of that. >>>>>>>>>> >>>>>>>>>> New webrev: >>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Diff compared to the first version: >>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Bengt >>>>>>>>>> >>>>>>>>>>> best regards, >>>>>>>>>>> >>>>>>>>>>> -- daniel >>>>>>>>>>> >>>>>>>>>>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>>>>>>>>>> Hi everyone, >>>>>>>>>>>> >>>>>>>>>>>> (This is a patch for webrev, but I am cross posting to the JDK >>>>>>>>>>>> 9 dev >>>>>>>>>>>> list since I'm not sure how many are on the webrev-dev list >>>>>>>>>>>> and >>>>>>>>>>>> most JDK >>>>>>>>>>>> developers might have opinions about this change.) >>>>>>>>>>>> >>>>>>>>>>>> Can I get a couple of reviews for this small enhancement to >>>>>>>>>>>> the webrev >>>>>>>>>>>> tool? >>>>>>>>>>>> >>>>>>>>>>>> CODETOOLS-7901044: Add next/prev links to navigate between >>>>>>>>>>>> diffs >>>>>>>>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>>>>>>>>>> >>>>>>>>>>>> Webrev: >>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Background: >>>>>>>>>>>> When browsing review requests that span many files it is quite >>>>>>>>>>>> time >>>>>>>>>>>> consuming to have to go back to the index page to view to the >>>>>>>>>>>> next or >>>>>>>>>>>> previous file. This patch adds links to the next and previous >>>>>>>>>>>> files in >>>>>>>>>>>> the diff views (including frames). >>>>>>>>>>>> >>>>>>>>>>>> The above webrev is generated with this new version, but since >>>>>>>>>>>> it only >>>>>>>>>>>> contains a single file it is not that interesting. Here is an >>>>>>>>>>>> example of >>>>>>>>>>>> what the new webrev looks like for a larger change (the G1 >>>>>>>>>>>> class >>>>>>>>>>>> unloading change): >>>>>>>>>>>> >>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Bengt >>>>>>>>>>>> >>>> >>> >> > From daniel.fuchs at oracle.com Tue Oct 14 19:55:09 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 14 Oct 2014 21:55:09 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <543D75B4.8060708@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> <542CF2E7.3010202@oracle.com> <21549.50683.903473.289915@mykonos.us.oracle.com> <542E5728.8010709@oracle.com> <543C5031.2020000@oracle.com> <543CE755.6060900@oracle.com> <543D6FC3.7020604@oracle.com> <543D75B4.8060708@oracle.com> Message-ID: <543D7F9D.2000908@oracle.com> On 10/14/14 9:12 PM, Jonathan Gibbons wrote: > Eric, > > Can you provide info on the OS and version of ksh you are using that > caused the problems you experienced with webrev? And also the version of webrev please :-) -- daniel > > -- Jon > > On 10/14/2014 11:47 AM, Bengt Rutisson wrote: >> On 10/14/14 11:05 AM, Daniel Fuchs wrote: >>> On 14/10/14 00:20, Jonathan Gibbons wrote: >>>> Bengt, >>>> >>>> There may be problems with the latest version of webrev. >>>> >>>> Eric McCorkle is reporting syntax errors from his version of ksh. >>>> >>>> patch cdiffs udiffs sdiffs frames old new >>>> src/jdk.javadoc/share/classes/com/sun/tools/javadoc/SeeTagImpl.java >>>> ../../tl/make/scripts/webrev.ksh[2241]: >>>> build_old_new[1714]: build_old_new_mercurial[1666]: [: : arithmetic >>>> syntax error >>> >>> Hi Jon, >>> >>> These line numbers do not seem to correspond to the latest version >>> of webrev.ksh. >>> >>> line 2241 is a comment >>> line 1714 is ' if [ -f $F ]; then' in build_old_new_mercurial >>> (an not in build_old_new) >>> line 1666 is ' fi' in look_for_prog >>> (an not build_old_new_mercurial) >>> >>> Could you maybe check that we're speaking of the same version of >>> webrev.ksh? >> >> Daniel, Thanks for pointing this out. >> >> It also does not seem to be the lines that I changed. >> >> Jon, I'm running the webrev script with ksh and it seems to work >> fine. Do you know which version ksh and which platform Eric is using? >> >> Thanks, >> Bengt >> >> >>> >>> best regards, >>> >>> -- daniel >>> >>> >>> >>> >>>> >>>> -- Jon >>>> >>>> On 10/03/2014 12:58 AM, Bengt Rutisson wrote: >>>>> >>>>> On 2014-10-02 23:39, John Coomes wrote: >>>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>>> On 2014-10-02 01:08, John Coomes wrote: >>>>>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>>>>> Hi Daniel, >>>>>>>>> >>>>>>>>> On 10/1/14 4:27 PM, Daniel Fuchs wrote: >>>>>>>>>> Hi Bengt, >>>>>>>>>> >>>>>>>>>> The new version looks good to me, but I am not a reviewer >>>>>>>>>> fore CODE_TOOLS. >>>>>>>>> Thanks for looking at this Daniel! >>>>>>>>> >>>>>>>>>> Hopefully someone who is will step in :-) >>>>>>>>> Yes, and I am not a committer in code-tools so I need a sponsor >>>>>>>>> for the >>>>>>>>> patch too. >>>>>>>> Looks good to me; I'll sponsor it. Send me (privately) the >>>>>>>> result of >>>>>>>> "hg export --git" and I'll push that. >>>>>>> Thanks for looking at this, John! And thanks for sponsoring the >>>>>>> change. >>>>>>> I'll send you the export in a separate email. >>>>>> Got it; it's been pushed. >>>>> >>>>> Thanks for pushing this, John! >>>>> >>>>> Bengt >>>>> >>>>>> >>>>>> -John >>>>>> >>>>>>>>>> best regards, >>>>>>>>>> >>>>>>>>>> -- daniel >>>>>>>>>> >>>>>>>>>> On 01/10/14 15:57, Bengt Rutisson wrote: >>>>>>>>>>> Hi Daniel, >>>>>>>>>>> >>>>>>>>>>> Thanks for looking at this! >>>>>>>>>>> >>>>>>>>>>> On 2014-10-01 15:53, Daniel Fuchs wrote: >>>>>>>>>>>> Hi Bengt, >>>>>>>>>>>> >>>>>>>>>>>> This is a really cool feature! >>>>>>>>>>> Thanks! >>>>>>>>>>> >>>>>>>>>>>> I have downloaded your patch and applied it in my >>>>>>>>>>>> local webrev repo - and played with the new >>>>>>>>>>>> webrev in a couple of repositories where I have >>>>>>>>>>>> pending uncommitted changes. >>>>>>>>>>>> >>>>>>>>>>>> This seems to work well. >>>>>>>>>>>> >>>>>>>>>>>> I have used: >>>>>>>>>>>> >>>>>>>>>>>> webrev -fN from top level repo >>>>>>>>>>>> webrev -N from jdk repo >>>>>>>>>>>> webrev -fN from jdk repo (with changes in test/closed) >>>>>>>>>>>> >>>>>>>>>>> Great that you tired it out. >>>>>>>>>>> >>>>>>>>>>>> I also had a cursory look at your patch. The only thing >>>>>>>>>>>> I noticed is that 'typeset' is not consistently used in >>>>>>>>>>>> the original webrev file. I'm not sure whether that's >>>>>>>>>>>> intended or not. >>>>>>>>>>>> I believe that's ok - but I've been bitten by not using >>>>>>>>>>>> typeset before ;-( - maybe - for the sake of uniformity - >>>>>>>>>>>> you could use typeset at least in those functions that >>>>>>>>>>>> already use it for their parameters? For instance >>>>>>>>>>>> lines 532-534, and possibly line 560 as well? >>>>>>>>>>>> Or did you intentionally not used it? >>>>>>>>>>> I also noticed the inconsistent use of typeset. I fixed the >>>>>>>>>>> lines you >>>>>>>>>>> pointed out. I wasn't sure which way to go. But I think your >>>>>>>>>>> suggestion >>>>>>>>>>> is good. >>>>>>>>>>> >>>>>>>>>>>> Also you should increment the version of webrev. >>>>>>>>>>>> IIRC that would be 25.6: >>>>>>>>>>>> >>>>>>>>>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>>>>>>>>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >>>>>>>>>>> Thanks, didn't think of that. >>>>>>>>>>> >>>>>>>>>>> New webrev: >>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Diff compared to the first version: >>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Bengt >>>>>>>>>>> >>>>>>>>>>>> best regards, >>>>>>>>>>>> >>>>>>>>>>>> -- daniel >>>>>>>>>>>> >>>>>>>>>>>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>>>>>>>>>>> Hi everyone, >>>>>>>>>>>>> >>>>>>>>>>>>> (This is a patch for webrev, but I am cross posting to the >>>>>>>>>>>>> JDK >>>>>>>>>>>>> 9 dev >>>>>>>>>>>>> list since I'm not sure how many are on the webrev-dev >>>>>>>>>>>>> list and >>>>>>>>>>>>> most JDK >>>>>>>>>>>>> developers might have opinions about this change.) >>>>>>>>>>>>> >>>>>>>>>>>>> Can I get a couple of reviews for this small enhancement to >>>>>>>>>>>>> the webrev >>>>>>>>>>>>> tool? >>>>>>>>>>>>> >>>>>>>>>>>>> CODETOOLS-7901044: Add next/prev links to navigate between >>>>>>>>>>>>> diffs >>>>>>>>>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>>>>>>>>>>> >>>>>>>>>>>>> Webrev: >>>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Background: >>>>>>>>>>>>> When browsing review requests that span many files it is >>>>>>>>>>>>> quite >>>>>>>>>>>>> time >>>>>>>>>>>>> consuming to have to go back to the index page to view to the >>>>>>>>>>>>> next or >>>>>>>>>>>>> previous file. This patch adds links to the next and previous >>>>>>>>>>>>> files in >>>>>>>>>>>>> the diff views (including frames). >>>>>>>>>>>>> >>>>>>>>>>>>> The above webrev is generated with this new version, but >>>>>>>>>>>>> since >>>>>>>>>>>>> it only >>>>>>>>>>>>> contains a single file it is not that interesting. Here is an >>>>>>>>>>>>> example of >>>>>>>>>>>>> what the new webrev looks like for a larger change (the G1 >>>>>>>>>>>>> class >>>>>>>>>>>>> unloading change): >>>>>>>>>>>>> >>>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Bengt >>>>>>>>>>>>> >>>>> >>>> >>> >> > From jonathan.gibbons at oracle.com Tue Oct 14 20:22:43 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 14 Oct 2014 13:22:43 -0700 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <543D7F9D.2000908@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> <542CF2E7.3010202@oracle.com> <21549.50683.903473.289915@mykonos.us.oracle.com> <542E5728.8010709@oracle.com> <543C5031.2020000@oracle.com> <543CE755.6060900@oracle.com> <543D6FC3.7020604@oracle.com> <543D75B4.8060708@oracle.com> <543D7F9D.2000908@oracle.com> Message-ID: <543D8613.9070507@oracle.com> Eric says it was a fresh check out from the webrev repo, and for the rest, he says, I'm not terribly familiar with ksh, but $ ksh -v gives the following: version sh (AT&T Research) 93v- 2014-06-06 The OS is Linux. Oddly enough, it doesn't seem to negatively affect the output that I can tell. -- Jon On 10/14/2014 12:55 PM, Daniel Fuchs wrote: > On 10/14/14 9:12 PM, Jonathan Gibbons wrote: >> Eric, >> >> Can you provide info on the OS and version of ksh you are using that >> caused the problems you experienced with webrev? > And also the version of webrev please :-) > > -- daniel > >> >> -- Jon >> >> On 10/14/2014 11:47 AM, Bengt Rutisson wrote: >>> On 10/14/14 11:05 AM, Daniel Fuchs wrote: >>>> On 14/10/14 00:20, Jonathan Gibbons wrote: >>>>> Bengt, >>>>> >>>>> There may be problems with the latest version of webrev. >>>>> >>>>> Eric McCorkle is reporting syntax errors from his version of ksh. >>>>> >>>>> patch cdiffs udiffs sdiffs frames old new >>>>> src/jdk.javadoc/share/classes/com/sun/tools/javadoc/SeeTagImpl.java >>>>> ../../tl/make/scripts/webrev.ksh[2241]: >>>>> build_old_new[1714]: build_old_new_mercurial[1666]: [: : arithmetic >>>>> syntax error >>>> >>>> Hi Jon, >>>> >>>> These line numbers do not seem to correspond to the latest version >>>> of webrev.ksh. >>>> >>>> line 2241 is a comment >>>> line 1714 is ' if [ -f $F ]; then' in build_old_new_mercurial >>>> (an not in build_old_new) >>>> line 1666 is ' fi' in look_for_prog >>>> (an not build_old_new_mercurial) >>>> >>>> Could you maybe check that we're speaking of the same version of >>>> webrev.ksh? >>> >>> Daniel, Thanks for pointing this out. >>> >>> It also does not seem to be the lines that I changed. >>> >>> Jon, I'm running the webrev script with ksh and it seems to work >>> fine. Do you know which version ksh and which platform Eric is using? >>> >>> Thanks, >>> Bengt >>> >>> >>>> >>>> best regards, >>>> >>>> -- daniel >>>> >>>> >>>> >>>> >>>>> >>>>> -- Jon >>>>> >>>>> On 10/03/2014 12:58 AM, Bengt Rutisson wrote: >>>>>> >>>>>> On 2014-10-02 23:39, John Coomes wrote: >>>>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>>>> On 2014-10-02 01:08, John Coomes wrote: >>>>>>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>>>>>> Hi Daniel, >>>>>>>>>> >>>>>>>>>> On 10/1/14 4:27 PM, Daniel Fuchs wrote: >>>>>>>>>>> Hi Bengt, >>>>>>>>>>> >>>>>>>>>>> The new version looks good to me, but I am not a reviewer >>>>>>>>>>> fore CODE_TOOLS. >>>>>>>>>> Thanks for looking at this Daniel! >>>>>>>>>> >>>>>>>>>>> Hopefully someone who is will step in :-) >>>>>>>>>> Yes, and I am not a committer in code-tools so I need a sponsor >>>>>>>>>> for the >>>>>>>>>> patch too. >>>>>>>>> Looks good to me; I'll sponsor it. Send me (privately) the >>>>>>>>> result of >>>>>>>>> "hg export --git" and I'll push that. >>>>>>>> Thanks for looking at this, John! And thanks for sponsoring the >>>>>>>> change. >>>>>>>> I'll send you the export in a separate email. >>>>>>> Got it; it's been pushed. >>>>>> >>>>>> Thanks for pushing this, John! >>>>>> >>>>>> Bengt >>>>>> >>>>>>> >>>>>>> -John >>>>>>> >>>>>>>>>>> best regards, >>>>>>>>>>> >>>>>>>>>>> -- daniel >>>>>>>>>>> >>>>>>>>>>> On 01/10/14 15:57, Bengt Rutisson wrote: >>>>>>>>>>>> Hi Daniel, >>>>>>>>>>>> >>>>>>>>>>>> Thanks for looking at this! >>>>>>>>>>>> >>>>>>>>>>>> On 2014-10-01 15:53, Daniel Fuchs wrote: >>>>>>>>>>>>> Hi Bengt, >>>>>>>>>>>>> >>>>>>>>>>>>> This is a really cool feature! >>>>>>>>>>>> Thanks! >>>>>>>>>>>> >>>>>>>>>>>>> I have downloaded your patch and applied it in my >>>>>>>>>>>>> local webrev repo - and played with the new >>>>>>>>>>>>> webrev in a couple of repositories where I have >>>>>>>>>>>>> pending uncommitted changes. >>>>>>>>>>>>> >>>>>>>>>>>>> This seems to work well. >>>>>>>>>>>>> >>>>>>>>>>>>> I have used: >>>>>>>>>>>>> >>>>>>>>>>>>> webrev -fN from top level repo >>>>>>>>>>>>> webrev -N from jdk repo >>>>>>>>>>>>> webrev -fN from jdk repo (with changes in test/closed) >>>>>>>>>>>>> >>>>>>>>>>>> Great that you tired it out. >>>>>>>>>>>> >>>>>>>>>>>>> I also had a cursory look at your patch. The only thing >>>>>>>>>>>>> I noticed is that 'typeset' is not consistently used in >>>>>>>>>>>>> the original webrev file. I'm not sure whether that's >>>>>>>>>>>>> intended or not. >>>>>>>>>>>>> I believe that's ok - but I've been bitten by not using >>>>>>>>>>>>> typeset before ;-( - maybe - for the sake of uniformity - >>>>>>>>>>>>> you could use typeset at least in those functions that >>>>>>>>>>>>> already use it for their parameters? For instance >>>>>>>>>>>>> lines 532-534, and possibly line 560 as well? >>>>>>>>>>>>> Or did you intentionally not used it? >>>>>>>>>>>> I also noticed the inconsistent use of typeset. I fixed the >>>>>>>>>>>> lines you >>>>>>>>>>>> pointed out. I wasn't sure which way to go. But I think your >>>>>>>>>>>> suggestion >>>>>>>>>>>> is good. >>>>>>>>>>>> >>>>>>>>>>>>> Also you should increment the version of webrev. >>>>>>>>>>>>> IIRC that would be 25.6: >>>>>>>>>>>>> >>>>>>>>>>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>>>>>>>>>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >>>>>>>>>>>> Thanks, didn't think of that. >>>>>>>>>>>> >>>>>>>>>>>> New webrev: >>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Diff compared to the first version: >>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Bengt >>>>>>>>>>>> >>>>>>>>>>>>> best regards, >>>>>>>>>>>>> >>>>>>>>>>>>> -- daniel >>>>>>>>>>>>> >>>>>>>>>>>>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>>>>>>>>>>>> Hi everyone, >>>>>>>>>>>>>> >>>>>>>>>>>>>> (This is a patch for webrev, but I am cross posting to >>>>>>>>>>>>>> the JDK >>>>>>>>>>>>>> 9 dev >>>>>>>>>>>>>> list since I'm not sure how many are on the webrev-dev >>>>>>>>>>>>>> list and >>>>>>>>>>>>>> most JDK >>>>>>>>>>>>>> developers might have opinions about this change.) >>>>>>>>>>>>>> >>>>>>>>>>>>>> Can I get a couple of reviews for this small enhancement to >>>>>>>>>>>>>> the webrev >>>>>>>>>>>>>> tool? >>>>>>>>>>>>>> >>>>>>>>>>>>>> CODETOOLS-7901044: Add next/prev links to navigate >>>>>>>>>>>>>> between diffs >>>>>>>>>>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>>>>>>>>>>>> >>>>>>>>>>>>>> Webrev: >>>>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Background: >>>>>>>>>>>>>> When browsing review requests that span many files it is >>>>>>>>>>>>>> quite >>>>>>>>>>>>>> time >>>>>>>>>>>>>> consuming to have to go back to the index page to view to >>>>>>>>>>>>>> the >>>>>>>>>>>>>> next or >>>>>>>>>>>>>> previous file. This patch adds links to the next and >>>>>>>>>>>>>> previous >>>>>>>>>>>>>> files in >>>>>>>>>>>>>> the diff views (including frames). >>>>>>>>>>>>>> >>>>>>>>>>>>>> The above webrev is generated with this new version, but >>>>>>>>>>>>>> since >>>>>>>>>>>>>> it only >>>>>>>>>>>>>> contains a single file it is not that interesting. Here >>>>>>>>>>>>>> is an >>>>>>>>>>>>>> example of >>>>>>>>>>>>>> what the new webrev looks like for a larger change (the >>>>>>>>>>>>>> G1 class >>>>>>>>>>>>>> unloading change): >>>>>>>>>>>>>> >>>>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Bengt >>>>>>>>>>>>>> >>>>>> >>>>> >>>> >>> >> > From daniel.fuchs at oracle.com Tue Oct 14 20:58:36 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 14 Oct 2014 22:58:36 +0200 Subject: RFR: CODETOOLS-7901044: Add next/prev links to navigate between diffs In-Reply-To: <543D8613.9070507@oracle.com> References: <542BC1C9.9000204@oracle.com> <542C0762.5070700@oracle.com> <542C083E.40208@oracle.com> <542C0F44.1000009@oracle.com> <542C6DF1.1060409@oracle.com> <21548.35184.576946.43474@mykonos.us.oracle.com> <542CF2E7.3010202@oracle.com> <21549.50683.903473.289915@mykonos.us.oracle.com> <542E5728.8010709@oracle.com> <543C5031.2020000@oracle.com> <543CE755.6060900@oracle.com> <543D6FC3.7020604@oracle.com> <543D75B4.8060708@oracle.com> <543D7F9D.2000908@oracle.com> <543D8613.9070507@oracle.com> Message-ID: <543D8E7C.5020702@oracle.com> On 10/14/14 10:22 PM, Jonathan Gibbons wrote: > Eric says it was a fresh check out from the webrev repo, and for the > rest, he says, Is Eric using the webrev from codetools? because from the line numbers it doesn't look like he is. In addition this path: ../../tl/make/scripts/webrev.ksh makes me think it might not be a webrev from the codetools repo - but some old version of webrev from the time when it was checked in the jdk tl repo... I'd suggest trying: `which webrev.ksh` and verifying that it's indeed ../../tl/make/scripts/webrev.ksh and then looking at the version string in ../../tl/make/scripts/webrev.ksh. best regards, -- daniel > > I'm not terribly familiar with ksh, but $ ksh -v gives the following: > > version sh (AT&T Research) 93v- 2014-06-06 > > > The OS is Linux. > > > Oddly enough, it doesn't seem to negatively affect the output that I can > tell. > > > -- Jon > > > > On 10/14/2014 12:55 PM, Daniel Fuchs wrote: >> On 10/14/14 9:12 PM, Jonathan Gibbons wrote: >>> Eric, >>> >>> Can you provide info on the OS and version of ksh you are using that >>> caused the problems you experienced with webrev? >> And also the version of webrev please :-) >> >> -- daniel >> >>> >>> -- Jon >>> >>> On 10/14/2014 11:47 AM, Bengt Rutisson wrote: >>>> On 10/14/14 11:05 AM, Daniel Fuchs wrote: >>>>> On 14/10/14 00:20, Jonathan Gibbons wrote: >>>>>> Bengt, >>>>>> >>>>>> There may be problems with the latest version of webrev. >>>>>> >>>>>> Eric McCorkle is reporting syntax errors from his version of ksh. >>>>>> >>>>>> patch cdiffs udiffs sdiffs frames old new >>>>>> src/jdk.javadoc/share/classes/com/sun/tools/javadoc/SeeTagImpl.java >>>>>> ../../tl/make/scripts/webrev.ksh[2241]: >>>>>> build_old_new[1714]: build_old_new_mercurial[1666]: [: : arithmetic >>>>>> syntax error >>>>> >>>>> Hi Jon, >>>>> >>>>> These line numbers do not seem to correspond to the latest version >>>>> of webrev.ksh. >>>>> >>>>> line 2241 is a comment >>>>> line 1714 is ' if [ -f $F ]; then' in build_old_new_mercurial >>>>> (an not in build_old_new) >>>>> line 1666 is ' fi' in look_for_prog >>>>> (an not build_old_new_mercurial) >>>>> >>>>> Could you maybe check that we're speaking of the same version of >>>>> webrev.ksh? >>>> >>>> Daniel, Thanks for pointing this out. >>>> >>>> It also does not seem to be the lines that I changed. >>>> >>>> Jon, I'm running the webrev script with ksh and it seems to work >>>> fine. Do you know which version ksh and which platform Eric is using? >>>> >>>> Thanks, >>>> Bengt >>>> >>>> >>>>> >>>>> best regards, >>>>> >>>>> -- daniel >>>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> -- Jon >>>>>> >>>>>> On 10/03/2014 12:58 AM, Bengt Rutisson wrote: >>>>>>> >>>>>>> On 2014-10-02 23:39, John Coomes wrote: >>>>>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>>>>> On 2014-10-02 01:08, John Coomes wrote: >>>>>>>>>> Bengt Rutisson (bengt.rutisson at oracle.com) wrote: >>>>>>>>>>> Hi Daniel, >>>>>>>>>>> >>>>>>>>>>> On 10/1/14 4:27 PM, Daniel Fuchs wrote: >>>>>>>>>>>> Hi Bengt, >>>>>>>>>>>> >>>>>>>>>>>> The new version looks good to me, but I am not a reviewer >>>>>>>>>>>> fore CODE_TOOLS. >>>>>>>>>>> Thanks for looking at this Daniel! >>>>>>>>>>> >>>>>>>>>>>> Hopefully someone who is will step in :-) >>>>>>>>>>> Yes, and I am not a committer in code-tools so I need a sponsor >>>>>>>>>>> for the >>>>>>>>>>> patch too. >>>>>>>>>> Looks good to me; I'll sponsor it. Send me (privately) the >>>>>>>>>> result of >>>>>>>>>> "hg export --git" and I'll push that. >>>>>>>>> Thanks for looking at this, John! And thanks for sponsoring >>>>>>>>> the change. >>>>>>>>> I'll send you the export in a separate email. >>>>>>>> Got it; it's been pushed. >>>>>>> >>>>>>> Thanks for pushing this, John! >>>>>>> >>>>>>> Bengt >>>>>>> >>>>>>>> >>>>>>>> -John >>>>>>>> >>>>>>>>>>>> best regards, >>>>>>>>>>>> >>>>>>>>>>>> -- daniel >>>>>>>>>>>> >>>>>>>>>>>> On 01/10/14 15:57, Bengt Rutisson wrote: >>>>>>>>>>>>> Hi Daniel, >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks for looking at this! >>>>>>>>>>>>> >>>>>>>>>>>>> On 2014-10-01 15:53, Daniel Fuchs wrote: >>>>>>>>>>>>>> Hi Bengt, >>>>>>>>>>>>>> >>>>>>>>>>>>>> This is a really cool feature! >>>>>>>>>>>>> Thanks! >>>>>>>>>>>>> >>>>>>>>>>>>>> I have downloaded your patch and applied it in my >>>>>>>>>>>>>> local webrev repo - and played with the new >>>>>>>>>>>>>> webrev in a couple of repositories where I have >>>>>>>>>>>>>> pending uncommitted changes. >>>>>>>>>>>>>> >>>>>>>>>>>>>> This seems to work well. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I have used: >>>>>>>>>>>>>> >>>>>>>>>>>>>> webrev -fN from top level repo >>>>>>>>>>>>>> webrev -N from jdk repo >>>>>>>>>>>>>> webrev -fN from jdk repo (with changes in test/closed) >>>>>>>>>>>>>> >>>>>>>>>>>>> Great that you tired it out. >>>>>>>>>>>>> >>>>>>>>>>>>>> I also had a cursory look at your patch. The only thing >>>>>>>>>>>>>> I noticed is that 'typeset' is not consistently used in >>>>>>>>>>>>>> the original webrev file. I'm not sure whether that's >>>>>>>>>>>>>> intended or not. >>>>>>>>>>>>>> I believe that's ok - but I've been bitten by not using >>>>>>>>>>>>>> typeset before ;-( - maybe - for the sake of uniformity - >>>>>>>>>>>>>> you could use typeset at least in those functions that >>>>>>>>>>>>>> already use it for their parameters? For instance >>>>>>>>>>>>>> lines 532-534, and possibly line 560 as well? >>>>>>>>>>>>>> Or did you intentionally not used it? >>>>>>>>>>>>> I also noticed the inconsistent use of typeset. I fixed the >>>>>>>>>>>>> lines you >>>>>>>>>>>>> pointed out. I wasn't sure which way to go. But I think your >>>>>>>>>>>>> suggestion >>>>>>>>>>>>> is good. >>>>>>>>>>>>> >>>>>>>>>>>>>> Also you should increment the version of webrev. >>>>>>>>>>>>>> IIRC that would be 25.6: >>>>>>>>>>>>>> >>>>>>>>>>>>>> - WEBREV_UPDATED=25.5-hg+openjdk.java.net >>>>>>>>>>>>>> + WEBREV_UPDATED=25.6-hg+openjdk.java.net >>>>>>>>>>>>> Thanks, didn't think of that. >>>>>>>>>>>>> >>>>>>>>>>>>> New webrev: >>>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.01/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Diff compared to the first version: >>>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00-01.diff/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Bengt >>>>>>>>>>>>> >>>>>>>>>>>>>> best regards, >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- daniel >>>>>>>>>>>>>> >>>>>>>>>>>>>> On 01/10/14 10:56, Bengt Rutisson wrote: >>>>>>>>>>>>>>> Hi everyone, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> (This is a patch for webrev, but I am cross posting to >>>>>>>>>>>>>>> the JDK >>>>>>>>>>>>>>> 9 dev >>>>>>>>>>>>>>> list since I'm not sure how many are on the webrev-dev >>>>>>>>>>>>>>> list and >>>>>>>>>>>>>>> most JDK >>>>>>>>>>>>>>> developers might have opinions about this change.) >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Can I get a couple of reviews for this small enhancement to >>>>>>>>>>>>>>> the webrev >>>>>>>>>>>>>>> tool? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> CODETOOLS-7901044: Add next/prev links to navigate >>>>>>>>>>>>>>> between diffs >>>>>>>>>>>>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901044 >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Webrev: >>>>>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/ >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Background: >>>>>>>>>>>>>>> When browsing review requests that span many files it is >>>>>>>>>>>>>>> quite >>>>>>>>>>>>>>> time >>>>>>>>>>>>>>> consuming to have to go back to the index page to view >>>>>>>>>>>>>>> to the >>>>>>>>>>>>>>> next or >>>>>>>>>>>>>>> previous file. This patch adds links to the next and >>>>>>>>>>>>>>> previous >>>>>>>>>>>>>>> files in >>>>>>>>>>>>>>> the diff views (including frames). >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> The above webrev is generated with this new version, but >>>>>>>>>>>>>>> since >>>>>>>>>>>>>>> it only >>>>>>>>>>>>>>> contains a single file it is not that interesting. Here >>>>>>>>>>>>>>> is an >>>>>>>>>>>>>>> example of >>>>>>>>>>>>>>> what the new webrev looks like for a larger change (the >>>>>>>>>>>>>>> G1 class >>>>>>>>>>>>>>> unloading change): >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901044/webrev.00/example/ >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>> Bengt >>>>>>>>>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> >