RFR: CODETOOLS-7901397 - Flag -b is ignored in webrev
Jesper Wilhelmsson
jesper.wilhelmsson at oracle.com
Tue Apr 28 15:17:20 UTC 2015
Right! Good catch!
I updated to 25.8.
/Jesper
Daniel Fuchs skrev den 28/4/15 16:59:
> On 28/04/15 16:54, Jonathan Gibbons wrote:
>> I'll sponsor the patch for you.
>
> Oh - the version needs to be updated too. Sorry I didn't catch that before.
>
> cheers,
>
> -- daniel
>
>>
>> -- Jon
>>
>> On 04/28/2015 06:56 AM, Jesper Wilhelmsson wrote:
>>> Thanks for reviewing!
>>>
>>> I will also need a sponsor since I'm not a committer in the Code-tools
>>> project.
>>>
>>> Thanks,
>>> /Jesper
>>>
>>>
>>> Daniel D. Daugherty skrev den 28/4/15 15:48:
>>>> > Webrev: http://cr.openjdk.java.net/~jwilhelm/CT-7901397/webrev.00/
>>>>
>>>> webrev.ksh
>>>> No comments.
>>>>
>>>>
>>>> I have a similar change to a much older version of webrev that I've
>>>> been fixing relative to /java/devtools/share/bin/webrev so this
>>>> looks good to me.
>>>>
>>>> I'll have to check out that project since I've done webrev fixes
>>>> in the past.
>>>>
>>>> Dan
>>>>
>>>>
>>>>
>>>>
>>>> On 4/28/15 6:52 AM, Jesper Wilhelmsson wrote:
>>>>> Widening the audience since I didn't get any replies on webrev-dev.
>>>>> Is anyone
>>>>> reading that list?
>>>>>
>>>>> Thanks,
>>>>> /Jesper
>>>>>
>>>>>
>>>>> Jesper Wilhelmsson skrev den 20/4/15 17:04:
>>>>>> Hi,
>>>>>>
>>>>>> Please review this fix to make webrev care about the -b flag and
>>>>>> make it
>>>>>> possible to produce diffs with whitespace changes.
>>>>>>
>>>>>> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7901397
>>>>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/CT-7901397/webrev.00/
>>>>>>
>>>>>> I will also need a sponsor to push this change.
>>>>>>
>>>>>> Thanks,
>>>>>> /Jesper
>>>>
>>
>
More information about the webrev-dev
mailing list