RFR: CODETOOLS-7901397 - Flag -b is ignored in webrev

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Tue Apr 28 21:38:24 UTC 2015


Oh. Sorry! Why can't the script be executable?
/Jesper

Jonathan Gibbons skrev den 28/4/15 22:56:
> Pushed -- but I did have to edit out the mode change lines in the patch.
>
> -- Jon
>
>
> On 04/28/2015 08:28 AM, Jesper Wilhelmsson wrote:
>> Thanks!
>>
>> Patch attached.
>> /Jesper
>>
>> Jonathan Gibbons skrev den 28/4/15 16:54:
>>> I'll sponsor the patch for you.
>>>
>>> -- Jon
>>>
>>> On 04/28/2015 06:56 AM, Jesper Wilhelmsson wrote:
>>>> Thanks for reviewing!
>>>>
>>>> I will also need a sponsor since I'm not a committer in the Code-tools project.
>>>>
>>>> Thanks,
>>>> /Jesper
>>>>
>>>>
>>>> Daniel D. Daugherty skrev den 28/4/15 15:48:
>>>>>  > Webrev: http://cr.openjdk.java.net/~jwilhelm/CT-7901397/webrev.00/
>>>>>
>>>>> webrev.ksh
>>>>>      No comments.
>>>>>
>>>>>
>>>>> I have a similar change to a much older version of webrev that I've
>>>>> been fixing relative to /java/devtools/share/bin/webrev so this
>>>>> looks good to me.
>>>>>
>>>>> I'll have to check out that project since I've done webrev fixes
>>>>> in the past.
>>>>>
>>>>> Dan
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On 4/28/15 6:52 AM, Jesper Wilhelmsson wrote:
>>>>>> Widening the audience since I didn't get any replies on webrev-dev. Is anyone
>>>>>> reading that list?
>>>>>>
>>>>>> Thanks,
>>>>>> /Jesper
>>>>>>
>>>>>>
>>>>>> Jesper Wilhelmsson skrev den 20/4/15 17:04:
>>>>>>> Hi,
>>>>>>>
>>>>>>> Please review this fix to make webrev care about the -b flag and make it
>>>>>>> possible to produce diffs with whitespace changes.
>>>>>>>
>>>>>>> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7901397
>>>>>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/CT-7901397/webrev.00/
>>>>>>>
>>>>>>> I will also need a sponsor to push this change.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> /Jesper
>>>>>
>>>
>


More information about the webrev-dev mailing list