RFR (S): CODETOOLS-7901317: Add flag to disable comments in webrev

Daniel Fuchs daniel.fuchs at oracle.com
Tue Mar 17 13:48:37 UTC 2015


Hi Bengt,

I imported your patch and tested it on my machine.
I had no issue - it worked as expected.
I'm not seeing any issue in the code either, but I'm
not a (R)eviewer for webrev.

best regards,

-- daniel

On 02/03/15 17:40, Bengt Rutisson wrote:
>
> Hi everyone,
>
> I've been missing the possibility to produce a webrev that does not
> include the comments from the changesets. I often use mq to track a set
> of changes and when I create a webrev I normally don't want all the
> names of my mq patches to appear in the webrev.
>
> Tom Rodrigues once had a version of webrev where -C meant that no
> comments were includes. I've added this flag to the offical webrev script.
>
> Using this review request as an examle. Here is a version with comments:
> http://cr.openjdk.java.net/~brutisso/7901317/webrev.00-with-comment/
>
> Here's the same without comment (so produced with "$ ksh webrev.ksh -C":
> http://cr.openjdk.java.net/~brutisso/7901317/webrev.00-without-comment/
>
> Bug report:
> https://bugs.openjdk.java.net/browse/CODETOOLS-7901317
>
> I need a sponsor for this fix as I am not a committer in the Code-tools
> project.
>
> Thanks,
> Bengt



More information about the webrev-dev mailing list