From bengt.rutisson at oracle.com Tue May 5 08:20:50 2015 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Tue, 05 May 2015 10:20:50 +0200 Subject: RFR: CODETOOLS-7901115: webrev -N -r generates broken patch files Message-ID: <55487D62.5020303@oracle.com> Hi everyone, Can I have a couple of reviews for this change to fix a P1 issue in the webrev script? I also need a sponsor to push the change. http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901115/webrev.00/ https://bugs.openjdk.java.net/browse/CODETOOLS-7901115 There are some details for what is happening in the bug report. The conclusion is that the problem was introduced by this change: http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a Since this is a feature (a good feature in my opinion) but causes problems we decided that the easiest way forward is to just back out this change now to make sure we can trust the generated patch files again. Later we can try to implement the feature to generate hg exports for "webrev -r" again. So, the changes proposed in this review request basically just undoes what was done for 09eb35524f9a. Thanks, Bengt From stuart.marks at oracle.com Tue May 5 20:21:59 2015 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 05 May 2015 13:21:59 -0700 Subject: RFR: CODETOOLS-7901115: webrev -N -r generates broken patch files In-Reply-To: <55487D62.5020303@oracle.com> References: <55487D62.5020303@oracle.com> Message-ID: <55492667.8020008@oracle.com> In case anyone is wondering, the changeset that Bengt is proposing to revert was mine. He and I have discussed this, and reverting it seems to be the best course of action in the short term. This script has too many %@#$& global variables, otherwise I think we'd fix it instead of backing it out. s'marks On 5/5/15 1:20 AM, Bengt Rutisson wrote: > > Hi everyone, > > Can I have a couple of reviews for this change to fix a P1 issue in the webrev > script? I also need a sponsor to push the change. > > http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901115/webrev.00/ > https://bugs.openjdk.java.net/browse/CODETOOLS-7901115 > > There are some details for what is happening in the bug report. The conclusion > is that the problem was introduced by this change: > > http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a > > Since this is a feature (a good feature in my opinion) but causes problems we > decided that the easiest way forward is to just back out this change now to make > sure we can trust the generated patch files again. Later we can try to implement > the feature to generate hg exports for "webrev -r" again. > > So, the changes proposed in this review request basically just undoes what was > done for 09eb35524f9a. > > Thanks, > Bengt From magnus.ihse.bursie at oracle.com Tue May 5 21:20:01 2015 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 05 May 2015 23:20:01 +0200 Subject: RFR: CODETOOLS-7901115: webrev -N -r generates broken patch files In-Reply-To: <55487D62.5020303@oracle.com> References: <55487D62.5020303@oracle.com> Message-ID: <55493401.6020208@oracle.com> On 2015-05-05 10:20, Bengt Rutisson wrote: > > Hi everyone, > > Can I have a couple of reviews for this change to fix a P1 issue in > the webrev script? I also need a sponsor to push the change. > > http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901115/webrev.00/ > https://bugs.openjdk.java.net/browse/CODETOOLS-7901115 > > There are some details for what is happening in the bug report. The > conclusion is that the problem was introduced by this change: > > http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a > > Since this is a feature (a good feature in my opinion) but causes > problems we decided that the easiest way forward is to just back out > this change now to make sure we can trust the generated patch files > again. Later we can try to implement the feature to generate hg > exports for "webrev -r" again. > > So, the changes proposed in this review request basically just undoes > what was done for 09eb35524f9a. Looks good to me. /Magnus > > Thanks, > Bengt From jonathan.gibbons at oracle.com Tue May 5 21:21:52 2015 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 05 May 2015 14:21:52 -0700 Subject: RFR: CODETOOLS-7901115: webrev -N -r generates broken patch files In-Reply-To: <55493401.6020208@oracle.com> References: <55487D62.5020303@oracle.com> <55493401.6020208@oracle.com> Message-ID: <55493470.4000708@oracle.com> OK, I'll push the change. -- Jon On 05/05/2015 02:20 PM, Magnus Ihse Bursie wrote: > On 2015-05-05 10:20, Bengt Rutisson wrote: >> >> Hi everyone, >> >> Can I have a couple of reviews for this change to fix a P1 issue in >> the webrev script? I also need a sponsor to push the change. >> >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901115/webrev.00/ >> https://bugs.openjdk.java.net/browse/CODETOOLS-7901115 >> >> There are some details for what is happening in the bug report. The >> conclusion is that the problem was introduced by this change: >> >> http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a >> >> Since this is a feature (a good feature in my opinion) but causes >> problems we decided that the easiest way forward is to just back out >> this change now to make sure we can trust the generated patch files >> again. Later we can try to implement the feature to generate hg >> exports for "webrev -r" again. >> >> So, the changes proposed in this review request basically just undoes >> what was done for 09eb35524f9a. > > Looks good to me. > > /Magnus > >> >> Thanks, >> Bengt > From magnus.ihse.bursie at oracle.com Tue May 5 21:22:56 2015 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 05 May 2015 23:22:56 +0200 Subject: RFR: CODETOOLS-7901397 - Flag -b is ignored in webrev In-Reply-To: <553FFE11.1040402@oracle.com> References: <5535157D.4040105@oracle.com> <553F8285.3020900@oracle.com> <553F8FA0.4050201@oracle.com> <553F91A1.3060405@oracle.com> <553F9F1C.8060907@oracle.com> <553FA728.2090001@oracle.com> <553FF40D.8030908@oracle.com> <553FFDD0.2000901@oracle.com> <553FFE11.1040402@oracle.com> Message-ID: <554934B0.30308@oracle.com> On 2015-04-28 23:39, Jonathan Gibbons wrote: > jcheck disallows executable files. Why are we running jcheck on the webrev repo? /Magnus > > -- Jon > > > On 04/28/2015 02:38 PM, Jesper Wilhelmsson wrote: >> Oh. Sorry! Why can't the script be executable? >> /Jesper >> >> Jonathan Gibbons skrev den 28/4/15 22:56: >>> Pushed -- but I did have to edit out the mode change lines in the >>> patch. >>> >>> -- Jon >>> >>> >>> On 04/28/2015 08:28 AM, Jesper Wilhelmsson wrote: >>>> Thanks! >>>> >>>> Patch attached. >>>> /Jesper >>>> >>>> Jonathan Gibbons skrev den 28/4/15 16:54: >>>>> I'll sponsor the patch for you. >>>>> >>>>> -- Jon >>>>> >>>>> On 04/28/2015 06:56 AM, Jesper Wilhelmsson wrote: >>>>>> Thanks for reviewing! >>>>>> >>>>>> I will also need a sponsor since I'm not a committer in the >>>>>> Code-tools project. >>>>>> >>>>>> Thanks, >>>>>> /Jesper >>>>>> >>>>>> >>>>>> Daniel D. Daugherty skrev den 28/4/15 15:48: >>>>>>> > Webrev: >>>>>>> http://cr.openjdk.java.net/~jwilhelm/CT-7901397/webrev.00/ >>>>>>> >>>>>>> webrev.ksh >>>>>>> No comments. >>>>>>> >>>>>>> >>>>>>> I have a similar change to a much older version of webrev that I've >>>>>>> been fixing relative to /java/devtools/share/bin/webrev so this >>>>>>> looks good to me. >>>>>>> >>>>>>> I'll have to check out that project since I've done webrev fixes >>>>>>> in the past. >>>>>>> >>>>>>> Dan >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 4/28/15 6:52 AM, Jesper Wilhelmsson wrote: >>>>>>>> Widening the audience since I didn't get any replies on >>>>>>>> webrev-dev. Is anyone >>>>>>>> reading that list? >>>>>>>> >>>>>>>> Thanks, >>>>>>>> /Jesper >>>>>>>> >>>>>>>> >>>>>>>> Jesper Wilhelmsson skrev den 20/4/15 17:04: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Please review this fix to make webrev care about the -b flag >>>>>>>>> and make it >>>>>>>>> possible to produce diffs with whitespace changes. >>>>>>>>> >>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7901397 >>>>>>>>> Webrev: >>>>>>>>> http://cr.openjdk.java.net/~jwilhelm/CT-7901397/webrev.00/ >>>>>>>>> >>>>>>>>> I will also need a sponsor to push this change. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> /Jesper >>>>>>> >>>>> >>> > From jonathan.gibbons at oracle.com Tue May 5 21:24:11 2015 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 05 May 2015 14:24:11 -0700 Subject: RFR: CODETOOLS-7901397 - Flag -b is ignored in webrev In-Reply-To: <554934B0.30308@oracle.com> References: <5535157D.4040105@oracle.com> <553F8285.3020900@oracle.com> <553F8FA0.4050201@oracle.com> <553F91A1.3060405@oracle.com> <553F9F1C.8060907@oracle.com> <553FA728.2090001@oracle.com> <553FF40D.8030908@oracle.com> <553FFDD0.2000901@oracle.com> <553FFE11.1040402@oracle.com> <554934B0.30308@oracle.com> Message-ID: <554934FB.508@oracle.com> Because that's the way the repo was set up by those who set up the repo. -- Jon On 05/05/2015 02:22 PM, Magnus Ihse Bursie wrote: > On 2015-04-28 23:39, Jonathan Gibbons wrote: >> jcheck disallows executable files. > > Why are we running jcheck on the webrev repo? > > /Magnus > >> >> -- Jon >> >> >> On 04/28/2015 02:38 PM, Jesper Wilhelmsson wrote: >>> Oh. Sorry! Why can't the script be executable? >>> /Jesper >>> >>> Jonathan Gibbons skrev den 28/4/15 22:56: >>>> Pushed -- but I did have to edit out the mode change lines in the >>>> patch. >>>> >>>> -- Jon >>>> >>>> >>>> On 04/28/2015 08:28 AM, Jesper Wilhelmsson wrote: >>>>> Thanks! >>>>> >>>>> Patch attached. >>>>> /Jesper >>>>> >>>>> Jonathan Gibbons skrev den 28/4/15 16:54: >>>>>> I'll sponsor the patch for you. >>>>>> >>>>>> -- Jon >>>>>> >>>>>> On 04/28/2015 06:56 AM, Jesper Wilhelmsson wrote: >>>>>>> Thanks for reviewing! >>>>>>> >>>>>>> I will also need a sponsor since I'm not a committer in the >>>>>>> Code-tools project. >>>>>>> >>>>>>> Thanks, >>>>>>> /Jesper >>>>>>> >>>>>>> >>>>>>> Daniel D. Daugherty skrev den 28/4/15 15:48: >>>>>>>> > Webrev: >>>>>>>> http://cr.openjdk.java.net/~jwilhelm/CT-7901397/webrev.00/ >>>>>>>> >>>>>>>> webrev.ksh >>>>>>>> No comments. >>>>>>>> >>>>>>>> >>>>>>>> I have a similar change to a much older version of webrev that >>>>>>>> I've >>>>>>>> been fixing relative to /java/devtools/share/bin/webrev so this >>>>>>>> looks good to me. >>>>>>>> >>>>>>>> I'll have to check out that project since I've done webrev fixes >>>>>>>> in the past. >>>>>>>> >>>>>>>> Dan >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 4/28/15 6:52 AM, Jesper Wilhelmsson wrote: >>>>>>>>> Widening the audience since I didn't get any replies on >>>>>>>>> webrev-dev. Is anyone >>>>>>>>> reading that list? >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> /Jesper >>>>>>>>> >>>>>>>>> >>>>>>>>> Jesper Wilhelmsson skrev den 20/4/15 17:04: >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Please review this fix to make webrev care about the -b flag >>>>>>>>>> and make it >>>>>>>>>> possible to produce diffs with whitespace changes. >>>>>>>>>> >>>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7901397 >>>>>>>>>> Webrev: >>>>>>>>>> http://cr.openjdk.java.net/~jwilhelm/CT-7901397/webrev.00/ >>>>>>>>>> >>>>>>>>>> I will also need a sponsor to push this change. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> /Jesper >>>>>>>> >>>>>> >>>> >> > From magnus.ihse.bursie at oracle.com Tue May 5 21:46:06 2015 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 05 May 2015 23:46:06 +0200 Subject: RFR: CODETOOLS-7901416 Fix incorrect awk substr indexing in webrev Message-ID: <55493A1E.70901@oracle.com> There are several cases of calls to the substr function in awk expressions in webrev, that assume 0 is the first position in the string. According to awk syntax, strings are 1-indexed. However, several awk implementations treat the incorrect 0 as an 1. Not so for mawk, which is the default awk implementation on Ubuntu. Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7901416 WebRev: http://cr.openjdk.java.net/~ihse/CODETOOLS-7901416-fix-awk-substr-to-1/webrev.01 /Magnus From jonathan.gibbons at oracle.com Tue May 5 23:48:55 2015 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 05 May 2015 23:48:55 +0000 Subject: hg: code-tools/webrev: 7901304: IDPREFIX should be configurable from the environment much like BUGURL a Message-ID: <201505052348.t45Nmtda004668@aojmv0008.oracle.com> Changeset: 48291a35a740 Author: simonis Date: 2015-05-05 16:47 -0700 URL: http://hg.openjdk.java.net/code-tools/webrev/rev/48291a35a740 7901304: IDPREFIX should be configurable from the environment much like BUGURL a lready is ! webrev.ksh From jonathan.gibbons at oracle.com Tue May 5 23:50:13 2015 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 05 May 2015 16:50:13 -0700 Subject: RFR(S): 7901304: IDPREFIX should be configurable from the environment much like BUGURL already is In-Reply-To: <5542C82C.5070102@oracle.com> References: <5541514C.6090604@oracle.com> <5542C82C.5070102@oracle.com> Message-ID: <55495735.4010104@oracle.com> Done. http://hg.openjdk.java.net/code-tools/webrev/rev/48291a35a740 -- Jon On 04/30/2015 05:26 PM, Jonathan Gibbons wrote: > > On 04/30/2015 03:07 AM, Volker Simonis wrote: >> On Wed, Apr 29, 2015 at 11:46 PM, Jonathan Gibbons >> wrote: >>> On 02/13/2015 10:01 AM, Volker Simonis wrote: >>>> Hi, >>>> >>>> could somebody please review and sponsor the following small change: >>>> >>>> http://cr.openjdk.java.net/~simonis/webrevs/2015/7901304/ >>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901304 >>>> >>>> It is possible to configure the bug url for links to the corresponding >>>> OpenJDK bugs by setting the environment variable WEBREV_BUGURL. >>>> >>>> Unfortunately it is not possible to configure the IDPREFIX which is >>>> hard-wired to "JDK-". This makes it impossible to create links to the >>>> bug systems for projects like CODETOOLS. >>>> >>>> The fix is easy - just read IDPREFIX from the environment if there >>>> exists an environment variable called WEBREV_IDPREFIX (by the way, the >>>> result can be seen in the webrev which correctly links to the >>>> corresponding codetools bug :). >>>> >>>> I've also slightly reordered the place where WEBREV_BUGURL and >>>> WEBREV_IDPREFIX are initialized to make it possible to print their >>>> default values in the webrev usage text. >>>> >>>> Regards, >>>> Volker >>> >>> Volker, >>> >>> This looks like a useful patch. >>> >> Thanks! >> >>> Note that round about line 30, there is a variable WEBREV_UPDATED >>> which we have been inconsistent in updated, but have been more >>> consistent of late. The number gets updated; the additional string >>> after the "-" looks a bit moire cryptic. >>> >> Not sure if I understand you right. Do you want me to bump the version >> number in WEBREV_UPDATED in my change? >> >> I need a sponsor anyway as I can't commit to the code-tools repo. Will >> you sponsor this change? >> >> Thank you and best regards, >> Volker >> >>> -- Jon > > I'll sponsor it; I'll update the WEBREV_UPDATED unless you send me a > new patch before I get round to it. > > -- Jon From jonathan.gibbons at oracle.com Tue May 5 23:57:26 2015 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 05 May 2015 23:57:26 +0000 Subject: hg: code-tools/webrev: 7901115: webrev -N -r generates broken patch files Message-ID: <201505052357.t45NvQ0L006716@aojmv0008.oracle.com> Changeset: 935f1eaa4691 Author: brutisso Date: 2015-05-05 16:57 -0700 URL: http://hg.openjdk.java.net/code-tools/webrev/rev/935f1eaa4691 7901115: webrev -N -r generates broken patch files (backout http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a) ! webrev.ksh From jonathan.gibbons at oracle.com Tue May 5 23:58:42 2015 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 05 May 2015 16:58:42 -0700 Subject: RFR: CODETOOLS-7901115: webrev -N -r generates broken patch files In-Reply-To: <55493470.4000708@oracle.com> References: <55487D62.5020303@oracle.com> <55493401.6020208@oracle.com> <55493470.4000708@oracle.com> Message-ID: <55495932.5050005@oracle.com> Done. http://hg.openjdk.java.net/code-tools/webrev/rev/935f1eaa4691 -- Jon On 05/05/2015 02:21 PM, Jonathan Gibbons wrote: > OK, I'll push the change. > > -- Jon > > > On 05/05/2015 02:20 PM, Magnus Ihse Bursie wrote: >> On 2015-05-05 10:20, Bengt Rutisson wrote: >>> >>> Hi everyone, >>> >>> Can I have a couple of reviews for this change to fix a P1 issue in >>> the webrev script? I also need a sponsor to push the change. >>> >>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901115/webrev.00/ >>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901115 >>> >>> There are some details for what is happening in the bug report. The >>> conclusion is that the problem was introduced by this change: >>> >>> http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a >>> >>> Since this is a feature (a good feature in my opinion) but causes >>> problems we decided that the easiest way forward is to just back out >>> this change now to make sure we can trust the generated patch files >>> again. Later we can try to implement the feature to generate hg >>> exports for "webrev -r" again. >>> >>> So, the changes proposed in this review request basically just >>> undoes what was done for 09eb35524f9a. >> >> Looks good to me. >> >> /Magnus >> >>> >>> Thanks, >>> Bengt >> > From bengt.rutisson at oracle.com Wed May 6 06:38:12 2015 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 06 May 2015 08:38:12 +0200 Subject: RFR: CODETOOLS-7901115: webrev -N -r generates broken patch files In-Reply-To: <55492667.8020008@oracle.com> References: <55487D62.5020303@oracle.com> <55492667.8020008@oracle.com> Message-ID: <5549B6D4.7060301@oracle.com> On 05/05/15 22:21, Stuart Marks wrote: > In case anyone is wondering, the changeset that Bengt is proposing to > revert was mine. He and I have discussed this, and reverting it seems > to be the best course of action in the short term. Thanks for clarifying this, Stuart! I should have written more about it in my original post. > > This script has too many %@#$& global variables, otherwise I think > we'd fix it instead of backing it out. Totally agree! Bengt > > s'marks > > On 5/5/15 1:20 AM, Bengt Rutisson wrote: >> >> Hi everyone, >> >> Can I have a couple of reviews for this change to fix a P1 issue in >> the webrev >> script? I also need a sponsor to push the change. >> >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901115/webrev.00/ >> https://bugs.openjdk.java.net/browse/CODETOOLS-7901115 >> >> There are some details for what is happening in the bug report. The >> conclusion >> is that the problem was introduced by this change: >> >> http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a >> >> Since this is a feature (a good feature in my opinion) but causes >> problems we >> decided that the easiest way forward is to just back out this change >> now to make >> sure we can trust the generated patch files again. Later we can try >> to implement >> the feature to generate hg exports for "webrev -r" again. >> >> So, the changes proposed in this review request basically just undoes >> what was >> done for 09eb35524f9a. >> >> Thanks, >> Bengt From bengt.rutisson at oracle.com Wed May 6 06:38:38 2015 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 06 May 2015 08:38:38 +0200 Subject: RFR: CODETOOLS-7901115: webrev -N -r generates broken patch files In-Reply-To: <55493401.6020208@oracle.com> References: <55487D62.5020303@oracle.com> <55493401.6020208@oracle.com> Message-ID: <5549B6EE.1080301@oracle.com> On 05/05/15 23:20, Magnus Ihse Bursie wrote: > On 2015-05-05 10:20, Bengt Rutisson wrote: >> >> Hi everyone, >> >> Can I have a couple of reviews for this change to fix a P1 issue in >> the webrev script? I also need a sponsor to push the change. >> >> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901115/webrev.00/ >> https://bugs.openjdk.java.net/browse/CODETOOLS-7901115 >> >> There are some details for what is happening in the bug report. The >> conclusion is that the problem was introduced by this change: >> >> http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a >> >> Since this is a feature (a good feature in my opinion) but causes >> problems we decided that the easiest way forward is to just back out >> this change now to make sure we can trust the generated patch files >> again. Later we can try to implement the feature to generate hg >> exports for "webrev -r" again. >> >> So, the changes proposed in this review request basically just undoes >> what was done for 09eb35524f9a. > > Looks good to me. Thanks for reviewing this, Magnus! Bengt > > /Magnus > >> >> Thanks, >> Bengt > From bengt.rutisson at oracle.com Wed May 6 06:39:32 2015 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 06 May 2015 08:39:32 +0200 Subject: RFR: CODETOOLS-7901115: webrev -N -r generates broken patch files In-Reply-To: <55495932.5050005@oracle.com> References: <55487D62.5020303@oracle.com> <55493401.6020208@oracle.com> <55493470.4000708@oracle.com> <55495932.5050005@oracle.com> Message-ID: <5549B724.4090603@oracle.com> On 06/05/15 01:58, Jonathan Gibbons wrote: > Done. > http://hg.openjdk.java.net/code-tools/webrev/rev/935f1eaa4691 Thanks, Jon! Very quick turn around on this fix! Thanks everyone involved! Bengt > > -- Jon > > On 05/05/2015 02:21 PM, Jonathan Gibbons wrote: >> OK, I'll push the change. >> >> -- Jon >> >> >> On 05/05/2015 02:20 PM, Magnus Ihse Bursie wrote: >>> On 2015-05-05 10:20, Bengt Rutisson wrote: >>>> >>>> Hi everyone, >>>> >>>> Can I have a couple of reviews for this change to fix a P1 issue in >>>> the webrev script? I also need a sponsor to push the change. >>>> >>>> http://cr.openjdk.java.net/~brutisso/CODETOOLS-7901115/webrev.00/ >>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7901115 >>>> >>>> There are some details for what is happening in the bug report. The >>>> conclusion is that the problem was introduced by this change: >>>> >>>> http://hg.openjdk.java.net/code-tools/webrev/rev/09eb35524f9a >>>> >>>> Since this is a feature (a good feature in my opinion) but causes >>>> problems we decided that the easiest way forward is to just back >>>> out this change now to make sure we can trust the generated patch >>>> files again. Later we can try to implement the feature to generate >>>> hg exports for "webrev -r" again. >>>> >>>> So, the changes proposed in this review request basically just >>>> undoes what was done for 09eb35524f9a. >>> >>> Looks good to me. >>> >>> /Magnus >>> >>>> >>>> Thanks, >>>> Bengt >>> >> > From daniel.fuchs at oracle.com Wed May 6 09:16:05 2015 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Wed, 06 May 2015 11:16:05 +0200 Subject: RFR: CODETOOLS-7901416 Fix incorrect awk substr indexing in webrev In-Reply-To: <55493A1E.70901@oracle.com> References: <55493A1E.70901@oracle.com> Message-ID: <5549DBD5.2050308@oracle.com> On 05/05/15 23:46, Magnus Ihse Bursie wrote: > There are several cases of calls to the substr function in awk > expressions in webrev, that assume 0 is the first position in the string. > > According to awk syntax, strings are 1-indexed. However, several awk > implementations treat the incorrect 0 as an 1. Not so for mawk, which is > the default awk implementation on Ubuntu. > > Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7901416 > WebRev: > http://cr.openjdk.java.net/~ihse/CODETOOLS-7901416-fix-awk-substr-to-1/webrev.01 Looks good to me Magnus. Thanks for catching that. This substr syntax in awk has already given me pain in the head when I ported webrev from 'forest' to 'trees'. I have imported your patch and tested it on a few repos I have, including one test repo that has renames and new files and deleted files - and webrev is still working :-) Not a Reviewer for CODETOOLS though. best regards, -- daniel > > > /Magnus > From jonathan.gibbons at oracle.com Wed May 6 16:55:00 2015 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 06 May 2015 09:55:00 -0700 Subject: RFR: CODETOOLS-7901416 Fix incorrect awk substr indexing in webrev In-Reply-To: <5549DBD5.2050308@oracle.com> References: <55493A1E.70901@oracle.com> <5549DBD5.2050308@oracle.com> Message-ID: <554A4764.6050905@oracle.com> OK, will push. -- Jon On 05/06/2015 02:16 AM, Daniel Fuchs wrote: > On 05/05/15 23:46, Magnus Ihse Bursie wrote: >> There are several cases of calls to the substr function in awk >> expressions in webrev, that assume 0 is the first position in the >> string. >> >> According to awk syntax, strings are 1-indexed. However, several awk >> implementations treat the incorrect 0 as an 1. Not so for mawk, which is >> the default awk implementation on Ubuntu. >> >> Bug: https://bugs.openjdk.java.net/browse/CODETOOLS-7901416 >> WebRev: >> http://cr.openjdk.java.net/~ihse/CODETOOLS-7901416-fix-awk-substr-to-1/webrev.01 >> > > Looks good to me Magnus. > > Thanks for catching that. This substr syntax in awk has already > given me pain in the head when I ported webrev from 'forest' to > 'trees'. > > I have imported your patch and tested it on a few repos I have, > including one test repo that has renames and new files and deleted > files - and webrev is still working :-) > > Not a Reviewer for CODETOOLS though. > > > best regards, > > -- daniel > >> >> >> /Magnus >> >