RFR (S): CODETOOLS-7902158: webrev doesn't handle moved files correctly

Daniel Fuchs daniel.fuchs at oracle.com
Wed Apr 18 09:47:19 UTC 2018


Hi Gerard,

Thanks a lot for this fix! I am not a (R)eviewer for
code-tools.

I believe you will need to bump up the revision at
line 30:

   30 WEBREV_UPDATED=25.16-hg+openjdk.java.net

Maybe 25.17 ?

That said I have imported you patch and tested it against
my small nested test repos [1]  which I used to verify
my patch when I tweaked webrev to use `trees` instead of `forests`
and the result does look good.

Thanks for finding how to fix that issues with links
in renames!

best regards,

-- daniel

webrev to test renames generated with your patch:

[1] http://cr.openjdk.java.net/~dfuchs/testrenames/webrev/

On 17/04/2018 16:04, Gerard Ziemski wrote:
> (resending, adding codetools-dev at openjdk.java.net)
> 
> hi all,
> 
> Please review this small change that fixes “previous” and “next” links for moved (renamed) files.
> 
> https://bugs.openjdk.java.net/browse/CODETOOLS-7902158
> http://cr.openjdk.java.net/~gziemski/7902158_rev1/webrev/
> 
> 
> cheers
> 



More information about the webrev-dev mailing list