RFR (S): CODETOOLS-7902158: webrev doesn't handle moved files correctly
Jonathan Gibbons
jonathan.gibbons at oracle.com
Wed Apr 18 23:04:54 UTC 2018
Code Tools is a different Project, with a different set of Committers.
http://openjdk.java.net/census#code-tools
Either you can send me an updated patch (with new version number) or I
can do that tomorrow for you.
-- Jon
On 04/18/2018 08:22 AM, Gerard Ziemski wrote:
> hi Jonathan,
>
> Thank you for sponsoring, though I do have access to jdk and I am a committer, so I think I can check it in myself - unless code-tools committers is a different group?
>
> Daniel said we need to bump up the webrev’s version number (?):
>
>> I believe you will need to bump up the revision at
>> line 30:
>>
>> 30 WEBREV_UPDATED=25.16-hg+openjdk.java.net
>>
>> Maybe 25.17 ?
>
>
> cheers
>
>
>> On Apr 18, 2018, at 10:10 AM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
>>
>> Thanks for the reviews; I'll sponsor the change.
>>
>> -- Jon
>>
>>
>> On 4/18/18 2:47 AM, Magnus Ihse Bursie wrote:
>>> On 2018-04-17 17:04, Gerard Ziemski wrote:
>>>> (resending, adding codetools-dev at openjdk.java.net)
>>>>
>>>> hi all,
>>>>
>>>> Please review this small change that fixes “previous” and “next” links for moved (renamed) files.
>>>>
>>>> https://bugs.openjdk.java.net/browse/CODETOOLS-7902158
>>>> http://cr.openjdk.java.net/~gziemski/7902158_rev1/webrev/
>>> Looks good to me.
>>>
>>> /Magnus
>>>>
>>>> cheers
>>>>
More information about the webrev-dev
mailing list