pd_InlineSmallCode ?

[Xerxes Ranby]

On 2010-08-08 01:21, Rob Savoye wrote:
> Following the suggestion to use a pre pr484 revision of icedtea6, I get
> this error message which seems unrelated to my changes. I'm wondering if
> I need to use a new revision, I'm using this now:
>
>    hg clone -rf50bc2a9120e http://icedtea.classpath.org/hg/icedtea6
>    hg di -r373a443db017 ports/hotspot/make | patch -p1 -R
>
> With the full error being:
>
> /home/rsavoye/build/icedtea6/openjdk-ecj/hotspot/src/share/vm/runtime/globals.cpp:34:
> error: 'pd_InlineSmallCode' was not declared in this scope
> make[7]: *** [globals.o] Error 1
>
> I have the beginnings of a patch to fix the ARM calling convention at:
> http://www.senecass.com/projects/OpenJDK-ARM/thumb2-call.patch, but
> can't test it till I get past the problem with pd_InlineSmallCode.
>    

Just make sure

define_pd_global(intx,  InlineSmallCode,      1000);

exist in

openjdk/hotspot/src/cpu/zero/vm/globals_zero.hpp

http://icedtea.classpath.org/hg/icedtea6/rev/caa91bae0c5c

and you build should continue fine.


> All this patch does is add an THREAD_LAST_JAVA_FP offset to the defines
> in asm_helper.cpp, and then use that instead of THREAD_LAST_JAVA_SP.
> This seems too simple a change, so I'm gonna assume it's not complete. :-)
>    

I love the simplicity of this patch by making use of the asm_helper.

Hi I think you need to update all uses if THREAD_LAST_JAVA_SP to 
THREAD_LAST_JAVA_FP in
ports/hotspot/src/cpu/zero/vm/bytecodes_arm.def
and
ports/hotspot/src/cpu/zero/vm/cppInterpreter_arm.S
as well to fix the interpreter.


> 	- rob -
>
>    

Cheers
Xerxes