latest pr323 patch for ARM
Gary Benson
gbenson at redhat.com
Mon Aug 16 02:15:05 PDT 2010
Rob Savoye wrote:
> I've got a greatly improved patch for pr323 to fix the ARM assembler:
> http://www.senecass.com/projects/OpenJDK-ARM/thumb2-081310.patch
All the bits that look like this:
@@ -1814,7 +1814,7 @@
mov r3, #0
ldr r2, [tmp_xxx, #THREAD_TOP_ZERO_FRAME]
- str r3, [tmp_xxx, #THREAD_LAST_JAVA_SP]
+ str r3, [tmp_xxx, #THREAD_LAST_JAVA_FP]
ldr r0, [istate, #ISTATE_METHOD]
ldr r3, [r2, #0]
ldrh r0, [r0, #40]
are wrong, I think. To clear the frame pointer, you set
last_Java_*sp* to zero. So that should have been left as is.
If last_Java_sp is zero then the frame pointer is cleared and
the value of last_Java_fp is never read.
By the way, it's worth trying this with a debug build, so that
assertions are on.
Cheers,
Gary
--
http://gbenson.net/
More information about the zero-dev
mailing list