updated ARM assembler patch

Gary Benson gbenson at redhat.com
Fri Aug 27 01:29:42 PDT 2010


Rob Savoye wrote:
> I've got a new version of the ARM assembler patch at:
> http://www.senecass.com/projects/OpenJDK-ARM/thumb2-082510.patch

These bits look right:

-     str  r0, [r9, #THREAD_LAST_JAVA_SP]
+
+@      set SP to zero before setting the FP
+       str r5, [r9, #THREAD_LAST_JAVA_SP]
+@      set FP to the top zero frame
+       str r0, [r9, #THREAD_LAST_JAVA_FP]
+@      get the stack pointer, use r1 as it gets reset
+       ldr r1, [r9, #THREAD_JAVA_SP]
+@      set SP to the current top of stack
+       str r1, [r9, #THREAD_LAST_JAVA_SP]

(assuming that r1 is the _Zero_ stack pointer, not the ABI stack pointer.)
These bits are still wrong:

-     str  r5, [r9, #THREAD_LAST_JAVA_SP]
+
+@      set FP to the top zero frame, which is 0
+       str r5, [r9, #THREAD_LAST_JAVA_FP]
+

In fact, the original was right (you clear last_Java_SP to wipe the frame
anchor.)

Cheers,
Gary

-- 
http://gbenson.net/


More information about the zero-dev mailing list