From alejandro.murillo at oracle.com Fri Jan 18 02:56:26 2013 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 18 Jan 2013 03:56:26 -0700 Subject: RFR: 8000780 back ported Fix zero fail to build in JDK7u-dev [updated] In-Reply-To: References: <50D4F1FA.7090008@LGonQn.Org> <50D5017B.20305@oracle.com> <50D53CDD.9090109@LGonQn.Org> <50D5F5EA.2020902@oracle.com> <50D5F8BF.1030000@LGonQn.Org> Message-ID: <50F92A5A.4090000@oracle.com> Hi Chris (Phillips) I just got a snapshot of hs24 and bumped the build number to b31, so we can resume pushing bug fixes to it. Unfortunately the patch in the webrev at [1] does not apply cleanly anymore, Can you guys reapply the changes to clean clone of [2] and send the new webrev? Then if the previous reviewers approve it, I will push that soon after so it makes it into next week snapshot. Apologies for the extra work [1]http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero-hs24b29_20121222/ [2] http://hg.openjdk.java.net/hsx/hsx24/hotspot Thanks Alejandro On 1/2/2013 1:02 PM, Christian Thalinger wrote: > On Dec 22, 2012, at 10:15 AM, Chris Phillips @ T O wrote: > >> Hi Alejandro, >> Oops emails crossed in the net ... >> See my latest email , I had to regenerate the webrev and patch - >> This webrev s/b ok: >> >> Webrev: >> http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero-hs24b29_20121222/ > That looks good. -- Chris > >> Chris >> >> On 22/12/12 01:03 PM, Alejandro E Murillo wrote: >>> Hi Chris, >>> In that case is not necessary. >>> I initially thought the webrev was against jdk7u/jdk7u-dev/hotspot >>> but looks like it is against hsx/hsx24/hotspot. >>> BTW, I went to check the webrev link and is unreachable, can you check >>> that? >>> Thanks >>> Alejandro >>> >>> On 12/21/2012 9:53 PM, Chris Phillips @ T O wrote: >>>> Hi Alejandro, >>>> >>>> The only change since I tested this afternoon is the change >>>> for the hotspot_version. I will re-run tests if you wish but it seems >>>> unnecessary. >>>> >>>> Cheers! >>>> Chris >>>> >>>> On 21/12/12 07:40 PM, Alejandro E Murillo wrote: >>>>> On 12/21/2012 4:34 PM, Chris Phillips @ T O wrote: >>>>>> Hi >>>>>> >>>>>> {Not sure if this needs a new bug or not, it definitely needs a >>>>>> sponsor >>>>>> - Twisti ? } >>>>>> >>>>>> Attached is a backport (essentially resurrection of the Permgen code) >>>>>> of 8000780 now updated with Roman Kennke's comments. Checked and built >>>>>> against hsx24b28. (Current jdk7u-dev hs) >>>>>> >>>>>> Please review. >>>>>> >>>>>> Cheers! >>>>>> Chris >>>>>> PS >>>>>> Webrev is here: >>>>>> http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero/hs24b28/ >>>>>> >>>>> Hi >>>>> jdk7u-dev/hotspot corresponds to hs24-b27. >>>>> I just got the hs24 snapshot for b28 and bumped the number to b29, >>>>> Can you rework the patch/webrev against this repo: >>>>> >>>>> http://hg.openjdk.java.net/hsx/hsx24/hotspot >>>>> >>>>> once it's reviewed I can push it >>>>> >>>>> Thanks >>>>> >>> From ChrisPhi at LGonQn.Org Fri Jan 18 08:37:33 2013 From: ChrisPhi at LGonQn.Org (Chris Phillips @ T O) Date: Fri, 18 Jan 2013 11:37:33 -0500 Subject: RFR: 8000780 back ported Fix zero fail to build in JDK7u-dev [updated] In-Reply-To: <50F92A5A.4090000@oracle.com> References: <50D4F1FA.7090008@LGonQn.Org> <50D5017B.20305@oracle.com> <50D53CDD.9090109@LGonQn.Org> <50D5F5EA.2020902@oracle.com> <50D5F8BF.1030000@LGonQn.Org> <50F92A5A.4090000@oracle.com> Message-ID: <50F97A4D.50606@LGonQn.Org> Hi Alejandro, Have updated the webrev (just off by one line in 1 file) and built both normal hotspot and zero on x86_64 based on the hsx24 repo head: http://integral-portal.lgonqn.org/temp/ChrisPhi/hsx24b31-8000780-zero_20130118_webrev/ [Also now contains updated copyrights] Cheers! Chris On 18/01/13 05:56 AM, Alejandro E Murillo wrote: > > Hi Chris (Phillips) > I just got a snapshot of hs24 and bumped the build number to b31, > so we can resume pushing bug fixes to it. > Unfortunately the patch in the webrev at [1] does not apply cleanly > anymore, > Can you guys reapply the changes to clean clone of [2] and send the > new webrev? > Then if the previous reviewers approve it, I will push that soon > after so it makes > it into next week snapshot. Apologies for the extra work > > [1]http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero-hs24b29_20121222/ > > [2] http://hg.openjdk.java.net/hsx/hsx24/hotspot > > > > Thanks > Alejandro > > > On 1/2/2013 1:02 PM, Christian Thalinger wrote: >> On Dec 22, 2012, at 10:15 AM, Chris Phillips @ T >> O wrote: >> >>> Hi Alejandro, >>> Oops emails crossed in the net ... >>> See my latest email , I had to regenerate the webrev and patch - >>> This webrev s/b ok: >>> >>> Webrev: >>> http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero-hs24b29_20121222/ >>> >> That looks good. -- Chris >> >>> Chris >>> >>> On 22/12/12 01:03 PM, Alejandro E Murillo wrote: >>>> Hi Chris, >>>> In that case is not necessary. >>>> I initially thought the webrev was against jdk7u/jdk7u-dev/hotspot >>>> but looks like it is against hsx/hsx24/hotspot. >>>> BTW, I went to check the webrev link and is unreachable, can you check >>>> that? >>>> Thanks >>>> Alejandro >>>> >>>> On 12/21/2012 9:53 PM, Chris Phillips @ T O wrote: >>>>> Hi Alejandro, >>>>> >>>>> The only change since I tested this afternoon is the change >>>>> for the hotspot_version. I will re-run tests if you wish but it seems >>>>> unnecessary. >>>>> >>>>> Cheers! >>>>> Chris >>>>> >>>>> On 21/12/12 07:40 PM, Alejandro E Murillo wrote: >>>>>> On 12/21/2012 4:34 PM, Chris Phillips @ T O wrote: >>>>>>> Hi >>>>>>> >>>>>>> {Not sure if this needs a new bug or not, it definitely needs a >>>>>>> sponsor >>>>>>> - Twisti ? } >>>>>>> >>>>>>> Attached is a backport (essentially resurrection of the Permgen >>>>>>> code) >>>>>>> of 8000780 now updated with Roman Kennke's comments. Checked and >>>>>>> built >>>>>>> against hsx24b28. (Current jdk7u-dev hs) >>>>>>> >>>>>>> Please review. >>>>>>> >>>>>>> Cheers! >>>>>>> Chris >>>>>>> PS >>>>>>> Webrev is here: >>>>>>> http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero/hs24b28/ >>>>>>> >>>>>>> >>>>>> Hi >>>>>> jdk7u-dev/hotspot corresponds to hs24-b27. >>>>>> I just got the hs24 snapshot for b28 and bumped the number to b29, >>>>>> Can you rework the patch/webrev against this repo: >>>>>> >>>>>> http://hg.openjdk.java.net/hsx/hsx24/hotspot >>>>>> >>>>>> once it's reviewed I can push it >>>>>> >>>>>> Thanks >>>>>> >>>> > > > From alejandro.murillo at oracle.com Mon Jan 21 02:15:05 2013 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Mon, 21 Jan 2013 03:15:05 -0700 Subject: RFR: 8000780 back ported Fix zero fail to build in JDK7u-dev [updated] In-Reply-To: <50F9C5FD.4050706@oracle.com> References: <50D4F1FA.7090008@LGonQn.Org> <50D5017B.20305@oracle.com> <50D53CDD.9090109@LGonQn.Org> <50D5F5EA.2020902@oracle.com> <50D5F8BF.1030000@LGonQn.Org> <50F92A5A.4090000@oracle.com> <50F97A4D.50606@LGonQn.Org> <50F9C5FD.4050706@oracle.com> Message-ID: <50FD1529.7010303@oracle.com> Thanks Vladimir, I pushed this on Friday, will be in 7u/7u/hotspot next time we take a snapshot of hs24 cheers Alejandro On 1/18/2013 3:00 PM, Vladimir Kozlov wrote: > Looks good. > > Vladimir > > On 1/18/13 8:37 AM, Chris Phillips @ T O wrote: >> Hi Alejandro, >> >> Have updated the webrev (just off by one line in 1 file) and built both >> normal >> hotspot and zero on x86_64 based on the hsx24 repo head: >> http://integral-portal.lgonqn.org/temp/ChrisPhi/hsx24b31-8000780-zero_20130118_webrev/ >> [Also now contains updated copyrights] >> >> Cheers! >> Chris >> >> On 18/01/13 05:56 AM, Alejandro E Murillo wrote: >>> >>> Hi Chris (Phillips) >>> I just got a snapshot of hs24 and bumped the build number to b31, >>> so we can resume pushing bug fixes to it. >>> Unfortunately the patch in the webrev at [1] does not apply cleanly >>> anymore, >>> Can you guys reapply the changes to clean clone of [2] and send the >>> new webrev? >>> Then if the previous reviewers approve it, I will push that soon >>> after so it makes >>> it into next week snapshot. Apologies for the extra work >>> >>> [1]http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero-hs24b29_20121222/ >>> >>> >>> [2] http://hg.openjdk.java.net/hsx/hsx24/hotspot >>> >>> >>> >>> Thanks >>> Alejandro >>> >>> >>> On 1/2/2013 1:02 PM, Christian Thalinger wrote: >>>> On Dec 22, 2012, at 10:15 AM, Chris Phillips @ T >>>> O wrote: >>>> >>>>> Hi Alejandro, >>>>> Oops emails crossed in the net ... >>>>> See my latest email , I had to regenerate the webrev and patch - >>>>> This webrev s/b ok: >>>>> >>>>> Webrev: >>>>> http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero-hs24b29_20121222/ >>>>> >>>>> >>>> That looks good. -- Chris >>>> >>>>> Chris >>>>> >>>>> On 22/12/12 01:03 PM, Alejandro E Murillo wrote: >>>>>> Hi Chris, >>>>>> In that case is not necessary. >>>>>> I initially thought the webrev was against jdk7u/jdk7u-dev/hotspot >>>>>> but looks like it is against hsx/hsx24/hotspot. >>>>>> BTW, I went to check the webrev link and is unreachable, can you >>>>>> check >>>>>> that? >>>>>> Thanks >>>>>> Alejandro >>>>>> >>>>>> On 12/21/2012 9:53 PM, Chris Phillips @ T O wrote: >>>>>>> Hi Alejandro, >>>>>>> >>>>>>> The only change since I tested this afternoon is the change >>>>>>> for the hotspot_version. I will re-run tests if you wish but it >>>>>>> seems >>>>>>> unnecessary. >>>>>>> >>>>>>> Cheers! >>>>>>> Chris >>>>>>> >>>>>>> On 21/12/12 07:40 PM, Alejandro E Murillo wrote: >>>>>>>> On 12/21/2012 4:34 PM, Chris Phillips @ T O wrote: >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> {Not sure if this needs a new bug or not, it definitely needs a >>>>>>>>> sponsor >>>>>>>>> - Twisti ? } >>>>>>>>> >>>>>>>>> Attached is a backport (essentially resurrection of the Permgen >>>>>>>>> code) >>>>>>>>> of 8000780 now updated with Roman Kennke's comments. Checked and >>>>>>>>> built >>>>>>>>> against hsx24b28. (Current jdk7u-dev hs) >>>>>>>>> >>>>>>>>> Please review. >>>>>>>>> >>>>>>>>> Cheers! >>>>>>>>> Chris >>>>>>>>> PS >>>>>>>>> Webrev is here: >>>>>>>>> http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero/hs24b28/ >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> Hi >>>>>>>> jdk7u-dev/hotspot corresponds to hs24-b27. >>>>>>>> I just got the hs24 snapshot for b28 and bumped the number to b29, >>>>>>>> Can you rework the patch/webrev against this repo: >>>>>>>> >>>>>>>> http://hg.openjdk.java.net/hsx/hsx24/hotspot >>>>>>>> >>>>>>>> once it's reviewed I can push it >>>>>>>> >>>>>>>> Thanks >>>>>>>> >>>>>> >>> >>> >>> From ChrisPhi at LGonQn.Org Mon Jan 21 04:00:18 2013 From: ChrisPhi at LGonQn.Org (Chris Phillips @ T O) Date: Mon, 21 Jan 2013 07:00:18 -0500 Subject: RFR: 8000780 back ported Fix zero fail to build in JDK7u-dev [updated][resend] In-Reply-To: <50FD1529.7010303@oracle.com> References: <50D4F1FA.7090008@LGonQn.Org> <50D5017B.20305@oracle.com> <50D53CDD.9090109@LGonQn.Org> <50D5F5EA.2020902@oracle.com> <50D5F8BF.1030000@LGonQn.Org> <50F92A5A.4090000@oracle.com> <50F97A4D.50606@LGonQn.Org> <50F9C5FD.4050706@oracle.com> <50FD1529.7010303@oracle.com> Message-ID: <50FD2DD2.4030109@LGonQn.Org> Hi On 21/01/13 05:15 AM, Alejandro E Murillo wrote: > > Thanks Vladimir, > I pushed this on Friday, will be in 7u/7u/hotspot next time we take a > snapshot of hs24 > cheers > Alejandro Thanks Alejandro, Vladimir, Christian and Roman! Cheers! Chris