Build failure on zero/openjdk9

[Andrew Hughes]

----- Original Message -----
> Hi Ivan,
> 
> the change looks good and I can sponsor it. But you always need a bug
> ID so yes, please open a bug for it.
> 
> I also put Severin from RedHat on CC to hear his opinion because as
> far as I know he's currently maintaining the Zero port.
> 

It's "Red Hat", not RedHat :)

This looks fine to me, though I'm curious as to why it's causing issues
now. This line of code is present all the way back to OpenJDK 6 and comes
from the original Zero integration.

changeset:   1010:354d3184f6b2
user:        never
date:        Tue Oct 13 12:04:21 2009 -0700
summary:     6890308: integrate zero assembler hotspot changes

A new version of GCC? New flags being enabled by default?

> Regards,
> Volker
> 
> 
> On Wed, May 6, 2015 at 3:01 PM, Ivan Krylov <ivan at azulsystems.com> wrote:
> > Hi folks,
> >
> > Today I found a small error in the printf parameters that prevents openjdk9
> > to build in a zero configuration.
> > Who owns hotspot/src/cpu/zero/vm/frame_zero.cpp ?
> >
> > This is the build error:
> > /home/ivan/openjdk9/hotspot/src/cpu/zero/vm/frame_zero.cpp: In member
> > function ‘void frame::zero_print_on_error(int, outputStream*, char*, int)
> > const’:
> > /home/ivan/openjdk9/hotspot/src/cpu/zero/vm/frame_zero.cpp:216:73: error:
> > format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3
> > has type ‘intptr_t* {aka long int*}’ [-Werror=format=]
> >      st->print_cr(" " PTR_FORMAT ": %-21s = %s", addr, fieldbuf, valuebuf);
> > ^
> > cc1plus: all warnings being treated as errors
> >
> > ---
> >
> > The patch is trivial (I am the OCA signatory as ikrylov)
> >
> > ivan:~/openjdk9/hotspot$ hg diff
> > diff -r 86ab44ce262e src/cpu/zero/vm/frame_zero.cpp
> > --- a/src/cpu/zero/vm/frame_zero.cpp    Thu Apr 30 13:02:03 2015 -0700
> > +++ b/src/cpu/zero/vm/frame_zero.cpp    Wed May 06 15:55:10 2015 +0300
> > @@ -213,7 +213,7 @@
> >      valuebuf[buflen - 1] = '\0';
> >
> >      // Print the result
> > -    st->print_cr(" " PTR_FORMAT ": %-21s = %s", addr, fieldbuf, valuebuf);
> > +    st->print_cr(" " PTR_FORMAT ": %-21s = %s", p2i(addr), fieldbuf,
> > valuebuf);
> >    }
> >  }
> >
> > Can someone push the change or do I need to file the bug/go through code
> > review process?
> >
> > Thanks,
> >
> > Ivan
> >
> >
> >
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07