From doko at ubuntu.com  Tue Dec  4 13:21:52 2018
From: doko at ubuntu.com (Matthias Klose)
Date: Tue, 4 Dec 2018 14:21:52 +0100
Subject: [zero] zero VM fails to build on arm64 and ppc64el
Message-ID: <3181d297-adec-a3f7-bfec-c323530329a5@ubuntu.com>

jdk-12+22 zero fails to build at least on arm64 and ppc64el (it succeeds on
i386, and64, armhf, s390x).  Both builds fail with

/usr/bin/ld:
/<<PKGBUILDDIR>>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in
function `ZeroStack::handle_overflow(Thread*)':
./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to
`JavaThread::thread_state() const'
collect2: error: ld returned 1 exit status
make[4]: *** [lib/CompileJvm.gmk:179:
/<<PKGBUILDDIR>>/build-zero/support/modules_libs/java.base/server/libjvm.so] Error 1
make[4]: *** Waiting for unfinished jobs....
/usr/bin/ld:
/<<PKGBUILDDIR>>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in
function `ZeroStack::handle_overflow(Thread*)':
./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to
`JavaThread::thread_state() const'
collect2: error: ld returned 1 exit status
make[4]: *** [lib/CompileGtest.gmk:60:
/<<PKGBUILDDIR>>/build-zero/hotspot/variant-zero/libjvm/gtest/libjvm.so] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/make/hotspot'
make[3]: *** [make/Main.gmk:257: hotspot-zero-libs] Error 2

Didn't check other zero-only architectures yet.

Matthias

From doko at ubuntu.com  Tue Dec  4 13:54:19 2018
From: doko at ubuntu.com (Matthias Klose)
Date: Tue, 4 Dec 2018 14:54:19 +0100
Subject: [zero] zero VM fails to build on arm64 and ppc64el
In-Reply-To: <cc447091-be0b-8e8a-02e8-b953e8e461ec@redhat.com>
References: <3181d297-adec-a3f7-bfec-c323530329a5@ubuntu.com>
 <cc447091-be0b-8e8a-02e8-b953e8e461ec@redhat.com>
Message-ID: <af8b470c-a658-78c5-99b8-52bd13ee4bdf@ubuntu.com>

On 04.12.18 14:33, Aleksey Shipilev wrote:
> On 12/4/18 2:21 PM, Matthias Klose wrote:
>> jdk-12+22 zero fails to build at least on arm64 and ppc64el (it succeeds on
>> i386, and64, armhf, s390x).  Both builds fail with
>>
>> /usr/bin/ld:
>> /<<PKGBUILDDIR>>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in
>> function `ZeroStack::handle_overflow(Thread*)':
>> ./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to
>> `JavaThread::thread_state() const'
>> collect2: error: ld returned 1 exit status
>> make[4]: *** [lib/CompileJvm.gmk:179:
>> /<<PKGBUILDDIR>>/build-zero/support/modules_libs/java.base/server/libjvm.so] Error 1
>> make[4]: *** Waiting for unfinished jobs....
>> /usr/bin/ld:
>> /<<PKGBUILDDIR>>/build-zero/hotspot/variant-zero/libjvm/objs/stack_zero.o: in
>> function `ZeroStack::handle_overflow(Thread*)':
>> ./make/hotspot/./src/hotspot/cpu/zero/stack_zero.cpp:75: undefined reference to
>> `JavaThread::thread_state() const'
>> collect2: error: ld returned 1 exit status
>> make[4]: *** [lib/CompileGtest.gmk:60:
>> /<<PKGBUILDDIR>>/build-zero/hotspot/variant-zero/libjvm/gtest/libjvm.so] Error 1
>> make[4]: Leaving directory '/<<PKGBUILDDIR>>/make/hotspot'
>> make[3]: *** [make/Main.gmk:257: hotspot-zero-libs] Error 2
> 
> Okay, this deserves a fix.
> 
> But why build aarch64-zero and ppc64el-zero to begin with? Those platforms are fully supported by
> Red Hat's AArch64 port and SAP's PPC64 port, and are cleanly buildable:
>   https://builds.shipilev.net/openjdk-jdk/
> 
> This must be why it went unnoticed: Zero is usually built for platforms without full-fledged ports.

usually the hotspot platforms are faster to build, and before starting to debug
zero-only platforms it might be easier to build and look at hotspot platforms
where zero still builds.  As I said, I didn't build zero-only platforms yet.

From magnus.ihse.bursie at oracle.com  Wed Dec 12 18:28:06 2018
From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie)
Date: Wed, 12 Dec 2018 19:28:06 +0100
Subject: zero broken in jdk/jdk?
Message-ID: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>

I get the following build error when building zero in jdk/jdk:

workspace/build/linux-x64-zero/hotspot/variant-zero/libjvm/objs/os_linux.o: 
In function `os::abort(bool, void*, void const*)':
workspace/open/src/hotspot/os/linux/os_linux.cpp:1358: undefined 
reference to `ClassLoader::close_jrt_image()'
collect2: error: ld returned 1 exit status
lib/CompileJvm.gmk:172: recipe for target 
'workspace/build/linux-x64-zero/support/modules_libs/java.base/server/libjvm.so' 
failed

Is this a known problem?

/Magnus

From ChrisPhi at LGonQn.Org  Wed Dec 12 18:53:36 2018
From: ChrisPhi at LGonQn.Org ("Chris Phillips"@T O)
Date: Wed, 12 Dec 2018 13:53:36 -0500
Subject: zero broken in jdk/jdk? [resend ]
In-Reply-To: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
References: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
Message-ID: <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>

Hi Magnus,

On 12/12/18 01:28 PM, Magnus Ihse Bursie wrote:
> I get the following build error when building zero in jdk/jdk:
>
> workspace/build/linux-x64-zero/hotspot/variant-zero/libjvm/objs/os_linux.o: 
> In function `os::abort(bool, void*, void const*)':
> workspace/open/src/hotspot/os/linux/os_linux.cpp:1358: undefined 
> reference to `ClassLoader::close_jrt_image()'
> collect2: error: ld returned 1 exit status
> lib/CompileJvm.gmk:172: recipe for target 
> 'workspace/build/linux-x64-zero/support/modules_libs/java.base/server/libjvm.so' 
> failed
>
> Is this a known problem?
>
> /Magnus
>
>
Not seen this before, will take a look.

Chris


-- 
--
--     Woda: "Java: write once, debug anywhere" Hong Zhang
                      http://thehenrys.ca
  | Chris Phillips - Resident cat slave and dubious character      |
  | mailto:NorthernL00n at LGonQn.Org              (416)483-3768      |
  | http://LGonQn.Org/www/Chris.Phillips  cell: (416)505-3610      |
  "EPIC stands for Expects Perfectly Intuitive Compilers" P. Bannon
                   http://www.hazmatmodine.com
  NOTICE:
  This email message is for the sole use of the intended recipient(s)
  and may contain confidential and privileged information.  Any
  unauthorized review, use, disclosure or distribution is prohibited.
  If you are not the intended recipient, please contact the sender by
  reply email and destroy all copies of the original message.
                    "blah blah blah - Ginger!"
--


From ChrisPhi at LGonQn.Org  Wed Dec 12 20:51:31 2018
From: ChrisPhi at LGonQn.Org (Chris Phillips)
Date: Wed, 12 Dec 2018 15:51:31 -0500
Subject: zero broken in jdk/jdk? [resend ]
In-Reply-To: <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>
References: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
 <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>
Message-ID: <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>

Hi Magnus

On 2018-12-12 1:53 p.m., "Chris Phillips"@T O wrote:
> Hi Magnus,
> 
> On 12/12/18 01:28 PM, Magnus Ihse Bursie wrote:
>> I get the following build error when building zero in jdk/jdk:
>>
>> workspace/build/linux-x64-zero/hotspot/variant-zero/libjvm/objs/os_linux.o:
>> In function `os::abort(bool, void*, void const*)':
>> workspace/open/src/hotspot/os/linux/os_linux.cpp:1358: undefined
>> reference to `ClassLoader::close_jrt_image()'
>> collect2: error: ld returned 1 exit status
>> lib/CompileJvm.gmk:172: recipe for target
>> 'workspace/build/linux-x64-zero/support/modules_libs/java.base/server/libjvm.so'
>> failed
>>
>> Is this a known problem?
>>
>> /Magnus
>>
>>
> Not seen this before, will take a look.
> 
> Chris
> 
> 

Yes, somebody broke Zero  (Recent CDS change?)

The following fixes it please do open a bug or shall I?

diff --git a/src/hotspot/os/linux/os_linux.cpp
b/src/hotspot/os/linux/os_linux.cpp
--- a/src/hotspot/os/linux/os_linux.cpp
+++ b/src/hotspot/os/linux/os_linux.cpp
@@ -1354,9 +1354,11 @@
 void os::abort(bool dump_core, void* siginfo, const void* context) {
   os::shutdown();
   if (dump_core) {
+#ifndef INCLUDE_CDS
     if (UseSharedSpaces && DumpPrivateMappingsInCore) {
       ClassLoader::close_jrt_image();
     }
+#endif
 #ifndef PRODUCT
     fdStream out(defaultStream::output_fd());
     out.print_raw("Current thread is ");


Chris

From ChrisPhi at LGonQn.Org  Wed Dec 12 20:58:26 2018
From: ChrisPhi at LGonQn.Org (Chris Phillips)
Date: Wed, 12 Dec 2018 15:58:26 -0500
Subject: zero broken in jdk/jdk? [resend ]
In-Reply-To: <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>
References: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
 <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>
 <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>
Message-ID: <c65b6e87-3196-7abc-9bc4-1b16283b24a9@LGonQn.Org>

Oops.

On 2018-12-12 3:51 p.m., Chris Phillips wrote:
> Hi Magnus
> 
> On 2018-12-12 1:53 p.m., "Chris Phillips"@T O wrote:
>> Hi Magnus,
>>
>> On 12/12/18 01:28 PM, Magnus Ihse Bursie wrote:
>>> I get the following build error when building zero in jdk/jdk:
>>>
>>> workspace/build/linux-x64-zero/hotspot/variant-zero/libjvm/objs/os_linux.o:
>>> In function `os::abort(bool, void*, void const*)':
>>> workspace/open/src/hotspot/os/linux/os_linux.cpp:1358: undefined
>>> reference to `ClassLoader::close_jrt_image()'
>>> collect2: error: ld returned 1 exit status
>>> lib/CompileJvm.gmk:172: recipe for target
>>> 'workspace/build/linux-x64-zero/support/modules_libs/java.base/server/libjvm.so'
>>> failed
>>>
>>> Is this a known problem?
>>>
>>> /Magnus
>>>
>>>
>> Not seen this before, will take a look.
>>
>> Chris
>>
>>
> 
> Yes, somebody broke Zero  (Recent CDS change?)
> 
> The following fixes it please do open a bug or shall I?
> 
> diff --git a/src/hotspot/os/linux/os_linux.cpp
> b/src/hotspot/os/linux/os_linux.cpp
> --- a/src/hotspot/os/linux/os_linux.cpp
> +++ b/src/hotspot/os/linux/os_linux.cpp
> @@ -1354,9 +1354,11 @@
>  void os::abort(bool dump_core, void* siginfo, const void* context) {
>    os::shutdown();
>    if (dump_core) {
> +#ifndef INCLUDE_CDS
#ifdef
______

>      if (UseSharedSpaces && DumpPrivateMappingsInCore) {
>        ClassLoader::close_jrt_image();
>      }
> +#endif
>  #ifndef PRODUCT
>      fdStream out(defaultStream::output_fd());
>      out.print_raw("Current thread is ");
> 
> 
> Chris
> 

diff --git a/src/hotspot/os/linux/os_linux.cpp
b/src/hotspot/os/linux/os_linux.cpp
--- a/src/hotspot/os/linux/os_linux.cpp
+++ b/src/hotspot/os/linux/os_linux.cpp
@@ -1354,9 +1354,11 @@
 void os::abort(bool dump_core, void* siginfo, const void* context) {
   os::shutdown();
   if (dump_core) {
+#ifdef INCLUDE_CDS
     if (UseSharedSpaces && DumpPrivateMappingsInCore) {
       ClassLoader::close_jrt_image();
     }
+#endif

Sigh.


From magnus.ihse.bursie at oracle.com  Wed Dec 12 21:09:28 2018
From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie)
Date: Wed, 12 Dec 2018 22:09:28 +0100
Subject: zero broken in jdk/jdk? [resend ]
In-Reply-To: <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>
References: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
 <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>
 <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>
Message-ID: <22a0927a-bd55-510f-8fc3-dffc0c3ab0ee@oracle.com>



On 2018-12-12 21:51, Chris Phillips wrote:
> Hi Magnus
>
> On 2018-12-12 1:53 p.m., "Chris Phillips"@T O wrote:
>> Hi Magnus,
>>
>> On 12/12/18 01:28 PM, Magnus Ihse Bursie wrote:
>>> I get the following build error when building zero in jdk/jdk:
>>>
>>> workspace/build/linux-x64-zero/hotspot/variant-zero/libjvm/objs/os_linux.o:
>>> In function `os::abort(bool, void*, void const*)':
>>> workspace/open/src/hotspot/os/linux/os_linux.cpp:1358: undefined
>>> reference to `ClassLoader::close_jrt_image()'
>>> collect2: error: ld returned 1 exit status
>>> lib/CompileJvm.gmk:172: recipe for target
>>> 'workspace/build/linux-x64-zero/support/modules_libs/java.base/server/libjvm.so'
>>> failed
>>>
>>> Is this a known problem?
>>>
>>> /Magnus
>>>
>>>
>> Not seen this before, will take a look.
>>
>> Chris
>>
>>
> Yes, somebody broke Zero  (Recent CDS change?)
>
> The following fixes it please do open a bug or shall I?
Please do. My interest in keeping zero buildable is not that high. :)

/Magnus

>
> diff --git a/src/hotspot/os/linux/os_linux.cpp
> b/src/hotspot/os/linux/os_linux.cpp
> --- a/src/hotspot/os/linux/os_linux.cpp
> +++ b/src/hotspot/os/linux/os_linux.cpp
> @@ -1354,9 +1354,11 @@
>   void os::abort(bool dump_core, void* siginfo, const void* context) {
>     os::shutdown();
>     if (dump_core) {
> +#ifndef INCLUDE_CDS
>       if (UseSharedSpaces && DumpPrivateMappingsInCore) {
>         ClassLoader::close_jrt_image();
>       }
> +#endif
>   #ifndef PRODUCT
>       fdStream out(defaultStream::output_fd());
>       out.print_raw("Current thread is ");
>
>
> Chris


From ChrisPhi at LGonQn.Org  Wed Dec 12 21:13:40 2018
From: ChrisPhi at LGonQn.Org (Chris Phillips)
Date: Wed, 12 Dec 2018 16:13:40 -0500
Subject: zero broken in jdk/jdk? [resend ]
In-Reply-To: <c65b6e87-3196-7abc-9bc4-1b16283b24a9@LGonQn.Org>
References: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
 <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>
 <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>
 <c65b6e87-3196-7abc-9bc4-1b16283b24a9@LGonQn.Org>
Message-ID: <38f3e97e-33ac-bb22-ee03-175d29deeab6@LGonQn.Org>


Hi Magnus
Oopsn^ 2

On 2018-12-12 3:58 p.m., Chris Phillips wrote:
> Oops.
> 
> On 2018-12-12 3:51 p.m., Chris Phillips wrote:
>> Hi Magnus
>>
>> On 2018-12-12 1:53 p.m., "Chris Phillips"@T O wrote:
>>> Hi Magnus,
>>>
>>> On 12/12/18 01:28 PM, Magnus Ihse Bursie wrote:
>>>> I get the following build error when building zero in jdk/jdk:
>>>>
>>>> workspace/build/linux-x64-zero/hotspot/variant-zero/libjvm/objs/os_linux.o:
>>>> In function `os::abort(bool, void*, void const*)':
>>>> workspace/open/src/hotspot/os/linux/os_linux.cpp:1358: undefined
>>>> reference to `ClassLoader::close_jrt_image()'
>>>> collect2: error: ld returned 1 exit status
>>>> lib/CompileJvm.gmk:172: recipe for target
>>>> 'workspace/build/linux-x64-zero/support/modules_libs/java.base/server/libjvm.so'
>>>> failed
>>>>
>>>> Is this a known problem?
>>>>
>>>> /Magnus
>>>>
>>>>
>>> Not seen this before, will take a look.
>>>
>>> Chris
>>>
>>>
>>
>> Yes, somebody broke Zero  (Recent CDS change?)
>>
>> The following fixes it please do open a bug or shall I?
>>


This works, not sure why #ifdef INCLUDE_CDS doesn't.

(the body of close_jrt_image is under an ifdef INCLUDE_CDS, but maybe
 there is a higher level #ifdef? )

diff --git a/src/hotspot/os/linux/os_linux.cpp
b/src/hotspot/os/linux/os_linux.cpp
--- a/src/hotspot/os/linux/os_linux.cpp
+++ b/src/hotspot/os/linux/os_linux.cpp
@@ -1354,9 +1354,11 @@
 void os::abort(bool dump_core, void* siginfo, const void* context) {
   os::shutdown();
   if (dump_core) {
+#ifndef ZERO
     if (UseSharedSpaces && DumpPrivateMappingsInCore) {
       ClassLoader::close_jrt_image();
     }
+#endif
 #ifndef PRODUCT
     fdStream out(defaultStream::output_fd());
     out.print_raw("Current thread is ");



From ChrisPhi at LGonQn.Org  Wed Dec 12 22:42:00 2018
From: ChrisPhi at LGonQn.Org (Chris Phillips)
Date: Wed, 12 Dec 2018 17:42:00 -0500
Subject: zero broken in jdk/jdk? [resend ]
In-Reply-To: <38f3e97e-33ac-bb22-ee03-175d29deeab6@LGonQn.Org>
References: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
 <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>
 <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>
 <c65b6e87-3196-7abc-9bc4-1b16283b24a9@LGonQn.Org>
 <38f3e97e-33ac-bb22-ee03-175d29deeab6@LGonQn.Org>
Message-ID: <dfbde82b-a4f2-44fc-df3e-9dd883f01f39@LGonQn.Org>

This change broke Zero,
changeset:   52960:a6182c464b31
user:        jgeorge
date:        Wed Dec 12 10:13:11 2018 +0530
summary:     8200613: SA: jstack throws UnmappedAddressException with a
CDS core file

On 2018-12-12 4:13 p.m., Chris Phillips wrote:
> 
> Hi Magnus
> Oopsn^ 2
> 
> On 2018-12-12 3:58 p.m., Chris Phillips wrote:
>> Oops.
>>
>> On 2018-12-12 3:51 p.m., Chris Phillips wrote:
>>> Hi Magnus
>>>
>>> On 2018-12-12 1:53 p.m., "Chris Phillips"@T O wrote:
>>>> Hi Magnus,
>>>>
>>>> On 12/12/18 01:28 PM, Magnus Ihse Bursie wrote:
>>>>> I get the following build error when building zero in jdk/jdk:
>>>>>
>>>>> workspace/build/linux-x64-zero/hotspot/variant-zero/libjvm/objs/os_linux.o:
>>>>> In function `os::abort(bool, void*, void const*)':
>>>>> workspace/open/src/hotspot/os/linux/os_linux.cpp:1358: undefined
>>>>> reference to `ClassLoader::close_jrt_image()'
>>>>> collect2: error: ld returned 1 exit status
>>>>> lib/CompileJvm.gmk:172: recipe for target
>>>>> 'workspace/build/linux-x64-zero/support/modules_libs/java.base/server/libjvm.so'
>>>>> failed
>>>>>
>>>>> Is this a known problem?
>>>>>
>>>>> /Magnus
>>>>>
>>>>>
>>>> Not seen this before, will take a look.
>>>>
>>>> Chris
>>>>
>>>>
>>>
>>> Yes, somebody broke Zero  (Recent CDS change?)
>>>
>>> The following fixes it please do open a bug or shall I?
>>>
> 
> 
> This works, not sure why #ifdef INCLUDE_CDS doesn't.
> 
> (the body of close_jrt_image is under an ifdef INCLUDE_CDS, but maybe
>  there is a higher level #ifdef? )
> 
> diff --git a/src/hotspot/os/linux/os_linux.cpp
> b/src/hotspot/os/linux/os_linux.cpp
> --- a/src/hotspot/os/linux/os_linux.cpp
> +++ b/src/hotspot/os/linux/os_linux.cpp
> @@ -1354,9 +1354,11 @@
>  void os::abort(bool dump_core, void* siginfo, const void* context) {
>    os::shutdown();
>    if (dump_core) {
> +#ifndef ZERO
>      if (UseSharedSpaces && DumpPrivateMappingsInCore) {
>        ClassLoader::close_jrt_image();
>      }
> +#endif
>  #ifndef PRODUCT
>      fdStream out(defaultStream::output_fd());
>      out.print_raw("Current thread is ");
> 
> 

From sgehwolf at redhat.com  Thu Dec 13 09:11:09 2018
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Thu, 13 Dec 2018 10:11:09 +0100
Subject: zero broken in jdk/jdk? [resend ]
In-Reply-To: <38f3e97e-33ac-bb22-ee03-175d29deeab6@LGonQn.Org>
References: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
 <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>
 <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>
 <c65b6e87-3196-7abc-9bc4-1b16283b24a9@LGonQn.Org>
 <38f3e97e-33ac-bb22-ee03-175d29deeab6@LGonQn.Org>
Message-ID: <949a8057d7f3be272a2a1d7c17e70db757a93121.camel@redhat.com>

On Wed, 2018-12-12 at 16:13 -0500, Chris Phillips wrote:
> Hi Magnus
> Oopsn^ 2
> 
> On 2018-12-12 3:58 p.m., Chris Phillips wrote:
> > Oops.
> > 
> > On 2018-12-12 3:51 p.m., Chris Phillips wrote:
> > > Hi Magnus
> > > 
> > > On 2018-12-12 1:53 p.m., "Chris Phillips"@T O wrote:
> > > > Hi Magnus,
> > > > 
> > > > On 12/12/18 01:28 PM, Magnus Ihse Bursie wrote:
> > > > > I get the following build error when building zero in jdk/jdk:
> > > > > 
> > > > > workspace/build/linux-x64-zero/hotspot/variant-zero/libjvm/objs/os_linux.o:
> > > > > In function `os::abort(bool, void*, void const*)':
> > > > > workspace/open/src/hotspot/os/linux/os_linux.cpp:1358: undefined
> > > > > reference to `ClassLoader::close_jrt_image()'
> > > > > collect2: error: ld returned 1 exit status
> > > > > lib/CompileJvm.gmk:172: recipe for target
> > > > > 'workspace/build/linux-x64-zero/support/modules_libs/java.base/server/libjvm.so'
> > > > > failed
> > > > > 
> > > > > Is this a known problem?
> > > > > 
> > > > > /Magnus
> > > > > 
> > > > > 
> > > > 
> > > > Not seen this before, will take a look.
> > > > 
> > > > Chris
> > > > 
> > > > 
> > > 
> > > Yes, somebody broke Zero  (Recent CDS change?)
> > > 
> > > The following fixes it please do open a bug or shall I?
> > > 
> 
> 
> This works, not sure why #ifdef INCLUDE_CDS doesn't.
> 
> (the body of close_jrt_image is under an ifdef INCLUDE_CDS, but maybe
>  there is a higher level #ifdef? )
> 
> diff --git a/src/hotspot/os/linux/os_linux.cpp
> b/src/hotspot/os/linux/os_linux.cpp
> --- a/src/hotspot/os/linux/os_linux.cpp
> +++ b/src/hotspot/os/linux/os_linux.cpp
> @@ -1354,9 +1354,11 @@
>  void os::abort(bool dump_core, void* siginfo, const void* context) {
>    os::shutdown();
>    if (dump_core) {
> +#ifndef ZERO
>      if (UseSharedSpaces && DumpPrivateMappingsInCore) {
>        ClassLoader::close_jrt_image();
>      }
> +#endif
>  #ifndef PRODUCT
>      fdStream out(defaultStream::output_fd());
>      out.print_raw("Current thread is ");

Hi Chris,

I'll create a bug and post this for RFR.

Thanks,
Severin


From sgehwolf at redhat.com  Thu Dec 13 09:19:45 2018
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Thu, 13 Dec 2018 10:19:45 +0100
Subject: zero broken in jdk/jdk? [resend ]
In-Reply-To: <22a0927a-bd55-510f-8fc3-dffc0c3ab0ee@oracle.com>
References: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
 <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>
 <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>
 <22a0927a-bd55-510f-8fc3-dffc0c3ab0ee@oracle.com>
Message-ID: <dafb0e063a24c821e3ec2dd63a0aa5ef9a8ce0ad.camel@redhat.com>

On Wed, 2018-12-12 at 22:09 +0100, Magnus Ihse Bursie wrote:
> On 2018-12-12 21:51, Chris Phillips wrote:
> > Yes, somebody broke Zero  (Recent CDS change?)
> > 
> > The following fixes it please do open a bug or shall I?
> 
> Please do. My interest in keeping zero buildable is not that high. :)

https://bugs.openjdk.java.net/browse/JDK-8215342

Thanks,
Severin


From ChrisPhi at LGonQn.Org  Thu Dec 13 13:21:29 2018
From: ChrisPhi at LGonQn.Org (Chris Phillips)
Date: Thu, 13 Dec 2018 08:21:29 -0500
Subject: zero broken in jdk/jdk? [resend ]
In-Reply-To: <dafb0e063a24c821e3ec2dd63a0aa5ef9a8ce0ad.camel@redhat.com>
References: <7f860f0c-5edc-0c36-15b6-e28784a81996@oracle.com>
 <f8b36e98-1157-c4a4-6222-88a1aeff01cf@LGonQn.Org>
 <c79ea49b-4224-b7d8-2674-159c05c04b23@LGonQn.Org>
 <22a0927a-bd55-510f-8fc3-dffc0c3ab0ee@oracle.com>
 <dafb0e063a24c821e3ec2dd63a0aa5ef9a8ce0ad.camel@redhat.com>
Message-ID: <b6c4cd92-d8b0-7473-ad66-7209b207a566@LGonQn.Org>

Hi Severin,

On 2018-12-13 4:19 a.m., Severin Gehwolf wrote:
> On Wed, 2018-12-12 at 22:09 +0100, Magnus Ihse Bursie wrote:
>> On 2018-12-12 21:51, Chris Phillips wrote:
>>> Yes, somebody broke Zero  (Recent CDS change?)
>>>
>>> The following fixes it please do open a bug or shall I?
>>
>> Please do. My interest in keeping zero buildable is not that high. :)
> 
> https://bugs.openjdk.java.net/browse/JDK-8215342
> 
> Thanks,
> Severin
> 
> 
> 

Thanks, I unfortunately didn't see
this last night so I had created  a bug too, I'll close as a
dup of yours since that is where the action is happening.

Cheers!
Chris