zgc/zgc and non-PCH builds

[Stefan Karlsson]

Hi Aleksey,

This seems similar to what Volker reported for jdk/hs:
http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-March/030647.html

This is going to be fixed when we rebase ZGC against the latest jdk/hs. 
Alternatively, we simply push a change that adds handles.inline.hpp to 
the include list of arrayKlass.cpp.

Thanks,
StefanK

On 2018-03-27 12:20, Aleksey Shipilev wrote:
> Oh wait!
> 
> fastdebug builds with --disable-precompiled-headers are fine.
> *release* builds are not fine, and they produce the same build failure as below on my desktop.
> 
> -Aleksey
> 
> On 03/27/2018 11:12 AM, Aleksey Shipilev wrote:
>> Strange indeed. I just did a clean re-checkout of zgc/zgc to my desktop and to my CI host, and it
>> built fine. Let me see if that is CI misconfiguration (or maybe I should have purged the repo on CI
>> slave?).
>>
>> -Aleksey
>>
>> On 03/27/2018 10:31 AM, Per Liden wrote:
>>> That's strange. I never build with precompiler-headers and I can't reproduce that.
>>>
>>> /Per
>>>
>>> On 03/27/2018 10:07 AM, Aleksey Shipilev wrote:
>>>> Hi,
>>>>
>>>> My personal CI had started doing non-PCH builds recently, and current zgc/zgc fails with
>>>> --disable-precompiled-headers build with lots of these:
>>>>
>>>> /pool/buildbot/slaves/sobornost/zgc/build/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/arrayKlass.o:
>>>>
>>>> In function `ArrayKlass::complete_create_array_klass(ArrayKlass*, Klass*, ModuleEntry*, Thread*)':
>>>> /pool/buildbot/slaves/sobornost/zgc/build/src/hotspot/share/oops/arrayKlass.cpp:111: undefined
>>>> reference to `Handle::Handle(Thread*, oopDesc*)'
>>>> /pool/buildbot/slaves/sobornost/zgc/build/src/hotspot/share/oops/arrayKlass.cpp:111: undefined
>>>> reference to `Handle::Handle(Thread*, oopDesc*)'
>>>>
>>>> You might want to see if ZGC includes are correct?
>>>>
>>>> Thanks,
>>>> -Aleksey
>>>>
>>
>>
> 
>