Conditional compilation of ZGC
stuart.monteith at linaro.org
Wed May 9 16:16:00 UTC 2018
I'm not a reviewer. I only have a couple of observations to make,
it otherwise looks OK, AFAICT.
Did you intend on changing all of the occurrences of "
predicate(UseAVX == 3); " into "predicate((UseAVX == 3));" in this
You excluded "Z" from the enum here;
src/hotspot/share/gc/shared/gcName.hpp, should you do the same for
line 201 in src/hotspot/share/gc/shared/collectedHeap.hpp ?
On 9 May 2018 at 14:15, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
> Hi all,
> This is the first version of the patch to allow the compilation of ZGC to be
> turned on and off. This patch passes tier1, tier2, and hs-tier3 (except for
> the test in gcbarriers that need to be updated). This mostly shows that we
> can build ZGC on Linux x86_64 and Solaris Sparc, and that the other
> platforms still build without ZGC. It also shows that we don't break the
> other GCs.
> There are a few changes that we want to do for next version:
> 1) .ad file replace the fatal("ZGC specific code") with
> ShouldNotReachHere(), and maybe assert that we are running with ZGC.
> 2) Remove the INCLUDE_ZGC from gcCause and gcName, or add INCLUDE_<GC>
> guards for the other GCs.
> 3) c2_globals.hpp further cleanup. Probably move these flags into a gc/z/c2
More information about the zgc-dev