[aarch64-port-dev ] [Roland Westrelin] Re: Aarch64 port for ZGC, so far

[Andrew Dinn]

Hi Roland,

On 28/11/2018 10:56, Roland Westrelin wrote:
> 
> Just noticed I didn't include the mailing lists in that reply.
I'll take your word for it that the matcher problem Stuart ran into can
be fixed by the tweak you applied to Matcher::clone_address_expressions.
I don't know what ZBarrierSetC2::matcher_find_shared_visit is meant to
do, never mind how it interacts with clone_address_expressions. However,
I don't see any problem having clone_address_expressions return false on
AArch64 when the address is being consumed by a LoadStore.

Anyway, what I really wanted to say was that the fix for the trailing
barrier lookup using an extra precedence link is a very nice, simple
solution.

regards,


Andrew Dinn
-----------