[patch] Missing include from "ZGC: 8212681: Refactor IC locking to use a fine grained CompiledICLocker"

Erik Österlund erik.osterlund at oracle.com
Wed Oct 31 12:16:45 UTC 2018


Hi Aleksey,

Thanks for reporting this! I will sort it out. It's so much nicer to 
find these issues before getting pushed into jdk-jdk.

/Erik

On 2018-10-31 12:56, Aleksey Shipilev wrote:
> This patch:
>    http://hg.openjdk.java.net/zgc/zgc/rev/6551fd25cfa0
>
> Misses a simple include that breaks AArch64 build:
>
> diff -r 3913e1dc09f5 src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp
> --- a/src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp	Mon Oct 22 12:19:23 2018 +0200
> +++ b/src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp	Wed Oct 31 12:54:39 2018 +0100
> @@ -25,6 +25,7 @@
>
>   #include "precompiled.hpp"
>   #include "asm/macroAssembler.hpp"
> +#include "code/compiledIC.hpp"
>   #include "memory/resourceArea.hpp"
>   #include "nativeInst_aarch64.hpp"
>   #include "oops/oop.inline.hpp"
>
> You might want to fold it into zgc/zgc before proposing 8212681 upstream.
>
> Testing: cross-compiled zgc/zgc to AArch64
>
> Thanks,
> -Aleksey
>



More information about the zgc-dev mailing list