[aarch64-port-dev ] RFC: 64 bit literal oops
Stuart Monteith
stuart.monteith at linaro.org
Thu Feb 14 17:52:00 UTC 2019
Thanks for taking a look. I've updated it here:
http://cr.openjdk.java.net/~smonteith/oop64/webrev-20190214/
The stub code size needs to be increased to 14 instructions because of
the construction of 64-bit constants in the main code.
BR,
Stuart
On Tue, 12 Feb 2019 at 18:49, Andrew Haley <aph at redhat.com> wrote:
>
> On 2/11/19 1:27 PM, Stuart Monteith wrote:
> > Thanks for your comments Nick.
> >
> > I've updated the code with your comments:
> > http://cr.openjdk.java.net/~smonteith/oop64/webrev-20190211/
>
> It's pretty close.
>
> Two things:
>
> I don't think you really have to calculate things like
> NativeGeneralJump::instruction_size every time. They don't have to be
> compile-time constants, they can be fields that you initialize
> immediately after you've set Use64BitLiteralAddresses. If you do that
> then you won't need to change so much code.
>
> +// SRDM: Use64BitLiteralAddresses isn't initialized for the static _patch_info_offset to be used.
>
> ?
>
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
More information about the zgc-dev
mailing list