RFR 8217342: Build failed with excluding JFR

Per Liden per.liden at oracle.com
Fri Jan 18 15:46:23 UTC 2019


Hi,

On 1/18/19 4:36 PM, Aleksey Shipilev wrote:
> On 1/18/19 4:18 PM, Zhengyu Gu wrote:
>> Please review this patch that fixes build failures when excluding JFR (configure build with
>> --with-jvm-features=-jfr)
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217342
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8217342/webrev.00/index.html
> 
> Shenandoah parts look good.
> 
> I think zBarrierSet.hpp includes gc/shared/barrierSet.hpp already, so no need for it in
> zBarrierSetC2.cpp?

Agree, only including zBarrierSet.hpp should be enough. Other than that, 
the ZGC parts look good.

/Per


More information about the zgc-dev mailing list