RFR(S): 8246373 AArch64: Refactor register spilling code in ZGC barriers

Erik Österlund erik.osterlund at oracle.com
Wed Jul 22 16:37:22 UTC 2020


Hi Stuart,

Looks good.

Thanks,
/Erik

On 2020-07-22 17:47, Stuart Monteith wrote:
> Thanks Eric,
>        I've got a new webrev that'll hopefully be satisfactory:
> http://cr.openjdk.java.net/~smonteith/8246373/webrev.1/
>
>
> Thanks,
>        Stuart
>
> On 21/07/2020 08:59, Erik Österlund wrote:
>> Looks good, given Andrew's suggestion. Don't need another webrev for 
>> that.
>>
>> Thanks,
>> /Erik
>>
>> On 2020-07-17 09:42, Andrew Haley wrote:
>>> Hi,
>>>
>>> On 16/07/2020 20:29, Stuart Monteith wrote:
>>>> Hello,
>>>>      There is an opportunity to spill/load fewer registers in ZGC 
>>>> barriers. This is targetting JDK 16 jdk/jdk.
>>>>
>>>> JIRA:
>>>> https://bugs.openjdk.java.net/browse/JDK-8246373
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~smonteith/8246373/webrev.0/
>>>>
>>>> Tested with JTReg, SPECjbb2015, and other workloads.
>>> Looks reasonable, but please keep push_call_clobbered_registers(). If
>>> you need to do this, add push_call_clobbered_registers_except(RegSet).
>>> Of course the former can call the latter.
>>>
>>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose 
> the contents to any other person, use it for any purpose, or store or 
> copy the information in any medium. Thank you.



More information about the zgc-dev mailing list