gc/z/TestUncommit times out

[Thomas Stüfe]

Thank you Per, yes, this helps.

Cheers, Thomas

On Wed, Mar 25, 2020 at 9:35 AM Per Liden <per.liden at oracle.com> wrote:

> Hi Thomas,
>
> On 3/25/20 8:14 AM, Thomas Stüfe wrote:
> > Hi,
> >
> > on some of my machines (all not that slow) gc/z/TestUncommit keeps timing
> > out. It needs about 3-4 minutes to run through successfully, which means
> > the default 120 seconds are too short.
> >
> > Is that normal? I ran into this testing our new Metaspace prototype, but
> > the timeouts happen in the stock VM too (jdk15 tip).
> >
> > If that is normal, would it make sense to adjust the test to not hit the
> > timeout on standard machines?
>
> Yes, that test takes 4 minutes or so in total, but each @run should be
> less than 120 second. I've never seen this time out in our testing, but
> I can see that the first @run (which does 3 iterations) is on the
> border. We could lower that to 2 iterations to play it safe. I assume
> that would help you?
>
> --- a/test/hotspot/jtreg/gc/z/TestUncommit.java
> +++ b/test/hotspot/jtreg/gc/z/TestUncommit.java
> @@ -27,7 +27,7 @@
>    * @test TestUncommit
>    * @requires vm.gc.Z & !vm.graal.enabled & vm.compMode != "Xcomp"
>    * @summary Test ZGC uncommit unused memory
> - * @run main/othervm -XX:+UseZGC -Xlog:gc*,gc+stats=off -Xms128M
> -Xmx512M -XX:ZUncommitDelay=10 gc.z.TestUncommit true 3
> + * @run main/othervm -XX:+UseZGC -Xlog:gc*,gc+stats=off -Xms128M
> -Xmx512M -XX:ZUncommitDelay=10 gc.z.TestUncommit true 2
>    * @run main/othervm -XX:+UseZGC -Xlog:gc*,gc+stats=off -Xms512M
> -Xmx512M -XX:ZUncommitDelay=10 gc.z.TestUncommit false 1
>    * @run main/othervm -XX:+UseZGC -Xlog:gc*,gc+stats=off -Xms128M
> -Xmx512M -XX:ZUncommitDelay=10 -XX:-ZUncommit gc.z.TestUncommit false 1
>    */
>
> cheers,
> Per
>